30 replies to this topic

[Dimitrij]

config.plugins.OSDPositionSetup = ConfigSubsection()
config.plugins.OSDPositionSetup.dst_left = ConfigInteger(default=0)
config.plugins.OSDPositionSetup.dst_width = ConfigInteger(default=720)
config.plugins.OSDPositionSetup.dst_top = ConfigInteger(default=0)
config.plugins.OSDPositionSetup.dst_height = ConfigInteger(default=576)

I understood what was the matter. Only these settings are saved.

This is not a mistake in config.save() .

This is a bug in the plugin.

Simple...

					config.plugins.OSDPositionSetup.dst_height.value = 576
				config.misc.do_overscanwizard.value = False
				config.save()
+                               config.misc.do_overscanwizard.save()
				setConfiguredPosition()

 

[Dimitrij]

https://github.com/O...config.py#L1881

config = Config()
config.misc = ConfigSubsection()

Maybe?

config.misc = ConfigSubsection()
config = Config()

 

[Erik Slagter]

Do you say the plugin needs to mark the values that have changed (and therefore should be saved)?

[Dimitrij]

[OSDPositionSetup] add config.misc.do_overscanwizard.save()

[Erik Slagter]

Is that yes or no?

[Dimitrij]

Is that yes or no?

The plugin did not save the values of the settings, in some certain cases.

Why I don’t know.

By the way, I've heard complaints about this for several years.

Therefore, I intervened.

[WanWizard]

Still have not had any feedback on my question why "config.save()" doesn't save ALL config, and why your workaround is needed.

 

Like I wrote before, I'm not if favour of committing workarounds for problems we don't know the cause of...

[Dimitrij]

	def save(self):
		for x in self.content.items.values():
			x.save()

https://github.com/O...config.py#L1790

 

 

Nobody in Enigma uses the "config.save()" function except this plugin.

Edited by Dimitrij, 30 June 2021 - 05:15.

[WanWizard]

My Python isn't good enough to know what that means.  save() does not save 'sub-items' recusrively?

[Dimitrij]

My Python isn't good enough to know what that means. 

My too .
 

[Erik Slagter]

My Python isn't good enough to know what that means.  save() does not save 'sub-items' recusrively?

 

I think it is either that, or it only saves values that are marked as "changed". In that case the solution would to fix that, mark the relevant values as "changed" before calling "save".