Jump to content


Photo

Overscan problems


  • Please log in to reply
30 replies to this topic

Re: Overscan problems #21 Dimitrij

  • PLi® Core member
  • 8,034 posts

+258
Excellent

Posted 20 June 2021 - 08:56

config.plugins.OSDPositionSetup = ConfigSubsection()
config.plugins.OSDPositionSetup.dst_left = ConfigInteger(default=0)
config.plugins.OSDPositionSetup.dst_width = ConfigInteger(default=720)
config.plugins.OSDPositionSetup.dst_top = ConfigInteger(default=0)
config.plugins.OSDPositionSetup.dst_height = ConfigInteger(default=576)

I understood what was the matter. Only these settings are saved.

This is not a mistake in config.save() .

This is a bug in the plugin.

Simple...

					config.plugins.OSDPositionSetup.dst_height.value = 576
				config.misc.do_overscanwizard.value = False
				config.save()
+                               config.misc.do_overscanwizard.save()
				setConfiguredPosition()

 


Duo 4K/Lunix3-4K/Solo 4K


Re: Overscan problems #22 Dimitrij

  • PLi® Core member
  • 8,034 posts

+258
Excellent

Posted 20 June 2021 - 08:57

https://github.com/O...config.py#L1881

config = Config()
config.misc = ConfigSubsection()

Maybe?

config.misc = ConfigSubsection()
config = Config()

 


Duo 4K/Lunix3-4K/Solo 4K


Re: Overscan problems #23 Erik Slagter

  • PLi® Core member
  • 46,758 posts

+535
Excellent

Posted 20 June 2021 - 15:20

Do you say the plugin needs to mark the values that have changed (and therefore should be saved)?


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: Overscan problems #24 Dimitrij

  • PLi® Core member
  • 8,034 posts

+258
Excellent

Posted 27 June 2021 - 16:20

[OSDPositionSetup] add config.misc.do_overscanwizard.save()


Duo 4K/Lunix3-4K/Solo 4K


Re: Overscan problems #25 Erik Slagter

  • PLi® Core member
  • 46,758 posts

+535
Excellent

Posted 29 June 2021 - 17:03

Is that yes or no?


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: Overscan problems #26 Dimitrij

  • PLi® Core member
  • 8,034 posts

+258
Excellent

Posted 29 June 2021 - 19:17

Is that yes or no?

The plugin did not save the values of the settings, in some certain cases.

Why I don’t know.

By the way, I've heard complaints about this for several years.

Therefore, I intervened.


Duo 4K/Lunix3-4K/Solo 4K


Re: Overscan problems #27 WanWizard

  • PLi® Core member
  • 59,563 posts

+1,351
Excellent

Posted 29 June 2021 - 21:04

Still have not had any feedback on my question why "config.save()" doesn't save ALL config, and why your workaround is needed.

 

Like I wrote before, I'm not if favour of committing workarounds for problems we don't know the cause of...


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: Overscan problems #28 Dimitrij

  • PLi® Core member
  • 8,034 posts

+258
Excellent

Posted 30 June 2021 - 05:12

	def save(self):
		for x in self.content.items.values():
			x.save()

https://github.com/O...config.py#L1790

 

 

Nobody in Enigma uses the "config.save()" function except this plugin.


Edited by Dimitrij, 30 June 2021 - 05:15.

Duo 4K/Lunix3-4K/Solo 4K


Re: Overscan problems #29 WanWizard

  • PLi® Core member
  • 59,563 posts

+1,351
Excellent

Posted 30 June 2021 - 10:54

My Python isn't good enough to know what that means.  save() does not save 'sub-items' recusrively?


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: Overscan problems #30 Dimitrij

  • PLi® Core member
  • 8,034 posts

+258
Excellent

Posted 30 June 2021 - 11:56

My Python isn't good enough to know what that means. 

My too :) .
 


Duo 4K/Lunix3-4K/Solo 4K


Re: Overscan problems #31 Erik Slagter

  • PLi® Core member
  • 46,758 posts

+535
Excellent

Posted 11 July 2021 - 14:15

My Python isn't good enough to know what that means.  save() does not save 'sub-items' recusrively?

 

I think it is either that, or it only saves values that are marked as "changed". In that case the solution would to fix that, mark the relevant values as "changed" before calling "save".


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users