371 replies to this topic

[Huevos]

???. Hardknott/Honister is the OpenEmbedded submodule, not the core branch.

[WanWizard]

Yes, and ? What is it you want to say?

[Huevos]

Ok, looks like I am more confusion than help.

[WanWizard]

lol... if you have something to add, please do.

 

it won't be the first time there is confusion because I failed to understand what the remark is about...

[Huevos]

So one of the difficult parts is the asserts. In Py2 the asserts are disabled. In Py3 they are enabled.

 

That means for 10+ years people been committing code to enigma and writing plugins that don't conform to the asserts.

 

So in OpenATV they have chosen to delete the asserts rather than let the writers of crap plugins fix their code.

https://github.com/o...6bfa6d94e02L105

 

So we are now left with a situation where we get the following:

"My plugin works in OpenATV but not OpenViX. OpenATV is better than OpenViX. Your image is rubbish. Why don't you fix it?"

 

Here is another interesting piece of code from OpenATV ChannelSelection:

		try:
			if ChannelSelection.instance:
				raise AssertionError("class InfoBar is a singleton class and just one instance of this class is allowed!")
		except:
			pass

https://github.com/o....py#L2163-L2167

 

So if the assert fails there is no warning. This is a fix for another crap plugin that starts an additional instance of ChannelSelection. And when I provided the correct fix for the plugin to the plugin author it was rejected, because "it works fine in OpenATV so it is not the fault of the plugin".

 

So the question is, do we bow to the demands that these crap plugins run in our images? Or do we stick to our guns and force the authors to fix them (some of whom have abandoned their plugins, or in some cases have passed away)?
 

Edited by Huevos, 30 December 2021 - 11:52.

[littlesat]

"My plugin works in XXX but not YYY. XXXis better than YYY. YYY is rubbish. Why don't you fix it?"

 

Welcome to our world...

 

I know transferring to py3 in a good way is not easy...

 

As I'm kind of out-of-order now due to my private situation so I cannot find rest and time for it (especially concentration is difficult)... every help is welcome... 

It is a bit 'creasy' that each image should perform the same work over and over again... to many forks exist for enigma2... And indeed instead of working together you get this...

 

"My plugin works in XXX but not YYY. XXXis better than YYY. YYY is rubbish. Why don't you fix it?"

 

Not that every help to get is migrated to py3 is welcome... as I currently cannot do is.

Edited by littlesat, 30 December 2021 - 13:53.

[Beeker]

Regarding to python 3.

There are still some things to fix

 

-up/down key in Customize menu

-up/down key in networksetup.

-Entering IP address for DNS, fallback and manually IP not working.

-Crash movielist.

 

And a few other things.

 

At this moment E2 is starts up and most things are working.

 

I have no holiday, but it should be ready soon.

Edited by Beeker, 30 December 2021 - 14:07.

[Taapat]

My personal opinion now about py2 vs py3 is that you need to build code only for py3 compatible and not worry about py2.

Once you switch to py3 you will no longer want to return to py2.

Therefore, I do not see the point in maintaining compatibility.

Additionally, it allows you to modify the code in the hope that active plugin developers will follow.

 

Closed source inactive plugins will die naturally and I hope their users will find alternatives or live without them.

 

I personally don't worry about notifications that your image is rubbish if it comes from some plugin developer.

I also don't create plugins for all images.

But it's not because they're rubbish, but because I don't use them and don't want to waste time on tests and exceptions for them.

Edited by Taapat, 30 December 2021 - 20:42.

[littlesat]

I fully agree with taapat… make the code as clean as possible….
Users of these closed source plugins should stay on ancient images… issue solved…
The code where Beeker says it does not work yet are tricky points…

Edited by littlesat, 31 December 2021 - 08:33.

[WanWizard]

+1

[Beeker]

Python 3 branch OpenPLi is already become python 3 only,
except the #if PY_MAJOR_VERSION >= 3 in c++ files.

Edited by Beeker, 31 December 2021 - 08:28.

[littlesat]

except the #if PY_MAJOR_VERSION >= 3 in c++ files.

 

I would say for now we could keep them but not strive to ensure py2 is stull working.... Once everything is OK then remove them.... The 'main target' here is the py3 part. But do not forget to clean them up . I would leave this for now somewhere on the left side of the 'scrumboard' .

 

I also think we better can leave it to one person (and others giving help when there are issues or something advisable)... with a big team it will take for ever to get results for such project. In addition as we are 'later' now we can learn from other images where we can see how it can be done.... and how we can do it event better.

 

Hopefully this will be one of the things that can be added to OpenPLi 9.x or so.... 

 

I also think we need to do this first before upgrading to a oe where it is (almost) required (I recommend put the upgrade of OE in the 'next sprint').

 

I also prefer to make as less as changes to the current enigma2 at this moment as a lot of changes in the current enigma2 will interfere with Beeker's project. 

 

I hope once py3 is ready I can restart to contribute again... 

Edited by littlesat, 31 December 2021 - 08:38.

[littlesat]

@Wanwizard, Do we have a build from the python 3 branch? If so I do not see it at the status of the builds on our homepage website.

[WanWizard]

No, not yet. I was waiting for feedback on whether it was buildable or not, and for which boxes (as I don't want to run test builds for 100+ images ).

[littlesat]

Indeed not all images are required… For me the zgemma h9 in the first place.

Edited by littlesat, 31 December 2021 - 20:39.

[el bandido]

I say it is a Great Work so far, and the problems I am having are to be expected.

 

For me, The Edision osmio4kplus python3 image will build without feeds. The image will boot, but the wireless network does not work, and the internal tuners do not work. There are many green screens when I try to move through the receiver menus.
 

[zeros]

For me please Lunix3-4K. As soon as it's there, I'll give you feedback. Thanks in advance 

[Pr2]

I can test in the AB PULSe 4K.

[husein47]

fur mich fur Giga Blue trio 4k

[MCelliotG]

I can test on Mutant HD51. BTW, my skin is already Python3 ready, so it should work with no issues.