371 replies to this topic

[Huevos]

@wanwizard, I am sure it was never the PLi intention that the python 3 conversion would be a copy and paste job from a closed source enigma2 repo of another team.

[Beeker]

What should be done with the last 3 commits of directory.py file in python3 branch now?

 

https://github.com/O.../Directories.py

Edited by Beeker, 21 May 2022 - 18:07.

[Beeker]

Personally I prefer to freeze develop and go for py3 to avoid the merge conflict workload. but in between py3 is currently somehow on hold (again)

+1

 

I agree.

Freeze Python 2 after the 8.2 release and continue with Python 3 only.

We have OE-core, enigma2 and a lot of plugins py3 ready for development.

[Huevos]

What should be done with the last 3 commits of directory.py file in python3 branch now?

 

https://github.com/O.../Directories.py

I'll sort it out if you like.

[Beeker]

 

What should be done with the last 3 commits of directory.py file in python3 branch now?

 

https://github.com/O.../Directories.py

I'll sort it out if you like.

 

Please do so.

I'll wait for answer or PR before I update python3 branch with develop (git rebase).

[WanWizard]

When it indeed does improves without breaking other stuff I agree…. But when it breaks other stuff and just add new work in cascade I do not agree.

 

Refactoring should never break anything, unless the backward compatibility break was on purpose (this is sometimes needed and/or unavoidable).

[WanWizard]

@wanwizard, I am sure it was never the PLi intention that the python 3 conversion would be a copy and paste job from a closed source enigma2 repo of another team.

 

Agreed. I can only speculate.

[WanWizard]

Freeze Python 2 after the 8.2 release and continue with Python 3 only.

We have OE-core, enigma2 and a lot of plugins py3 ready for development.

 

As long as everyone agrees to that, and switches, That will only work if a "nightly build" of Hardknott / Python3 is stable enough for daily use.

 

I currently run develop on all my boxes, but I would stop that if it would become too unstable to record or watch TV, and that in turn would mean less is being tested.

 

In other words: agree on the way forward, and all stick to it.

[Huevos]

https://github.com/O...igma2/pull/3453

[WanWizard]

Merged

[littlesat]

When 8.2 is released we indeed need to consider to make py3 develop and continue…. But indeed only when py3 is functional regarding the basics…

[Beeker]

https://github.com/O...igma2/pull/3453

Thanks.

[Beeker]

When 8.2 is released we indeed need to consider to make py3 develop and continue…. But indeed only when py3 is functional regarding the basics…

 

TV/Radio: OK

Start/Stop recording: No problem.

Timers: OK.

 

Autotimer plugin: TODO

Edited by Beeker, 22 May 2022 - 11:52.

[Huevos]

You really need AutoTimer and XML-Import working as minimum.

 

And people need to be realistic. There are going to be bugs/crashes to start with and the quickest way for these to be found and solved is as many people using the python 3 image as possible. Everyone uses their receivers differently so it is impossible for just a few developers to find all the bugs.

Edited by Huevos, 22 May 2022 - 12:27.

[Huevos]

What is going on with this? I thought this work was going to get merged into "develop" once 8.2 was released.

[WanWizard]

It has to be bug-free enough for testers to actually run a develop image on the box, we don't have enough people testing as it is, and if it is not stable enough for normal daily use, it will be tested even less.

 

I have no clue what the status of the current Py3 codebase is, it needs to be usable enough to start working on (or at least thinking about) OpenPLi 9.

 

It also needs commitment from the developers to actually pick up issues as soon as possible, or plugins needed but not converted yet.

 

If not it is pointless to merge now if that means we can't release a new image for the next 12 months (or more).

 

[Huevos]

Ok, I had some stuff I wanted to send, but if it needs converting back to Py2 it will have to wait.

[littlesat]

Once we need to start so it is good to know what the status is…. That plugins do not work is not a mandatory thing when the basics are workable and we have the most important plugins. Once it is used more thinks will be fixed.

[WanWizard]

Depends on which plugins, autotimer and epgimport for example are already named.

 

Remains the question who is going to do the merge, as that is going to be quite a job, and requires someone with good code knowledge to correctly fix all the merge conflicts that no doubt will occur.

 

I am not that person.

[Beeker]

Depends on which plugins, autotimer and epgimport for example are already named.

 

Remains the question who is going to do the merge, as that is going to be quite a job, and requires someone with good code knowledge to correctly fix all the merge conflicts that no doubt will occur.

 

I am not that person.

 

You can merge python3 branch into develop without merge-conflicts.

hains@hains-System-Product-Name:~/enigma2$ git status
On branch develop
Your branch is up to date with 'origin/develop'.

nothing to commit, working tree clean
hains@hains-System-Product-Name:~/enigma2$ git pull https://github.com/OpenPLi/enigma2.git python3 --rebase
From https://github.com/OpenPLi/enigma2
 * branch                python3    -> FETCH_HEAD
Successfully rebased and updated refs/heads/develop.
hains@hains-System-Product-Name:~/enigma2$ 

Earlieer problems mentioned with directory.py file with commits from Iansav, wasn't the result of merge-conflicts.

 

Epgimport is already tested in the past and stable enough.

autotimer plugin is stable enough for testing.

Crashes might occur when testing under all circumstances, but I don't expect it will be work for weeks to fix.

 

Further very stable

 

-Hetweer.

-Forecast

-Oscamstatus

-Net/Shoutcast

-Systemtools

 

And more.

Edited by Beeker, 11 June 2022 - 21:25.