Jump to content


Photo

Repeating PiP zap timer does not use PiP


  • Please log in to reply
23 replies to this topic

#1 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 1 June 2022 - 21:52

I tried a repeating PiP zap timer today. I noticed two issues:

  1. In Single EPG, the line on which the timer is set is blank
  2. The zap happens, but without PiP

I tracked down 1:

So a bunch of PiP pixmaps is missing (5x repeating PiP zap, 5x repeating PiP zap & record, 5x repeating PiP record).

 

I duplicated the last five pixmaps in Components.EpgList.py three times, and the lines became visible in Single EPG. And new repeating PiP zap timers worked properly (so 2 also solved).

 

What would be the best way to handle this?

  • Create the missing pixmaps (I could do them for skin_default and PLi-Full(Night)HD, but obviously not for all skins)
  • Catch IndexError so at least the timer works properly
  • Do both of the above
  • Do nothing because nobody uses it anyway :)

Edited by scriptmelvin, 1 June 2022 - 21:54.

Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #2 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 2 June 2022 - 05:23

PiP is used if available.

There is a free tuner or not.

Show this code.


Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #3 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 2 June 2022 - 10:11

PiP is used if available.


No, it is not, because RecordTimer.py:isInTimer throws an IndexError
 

There is a free tuner or not.


Yes, there is a free tuner. If I open a PiP manually to the same service it works.
 

Show this code.


What do you mean?


Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #4 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 2 June 2022 - 10:20

https://github.com/O...dTimer.py#L1267


Edited by Dimitrij, 2 June 2022 - 10:23.

Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #5 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 2 June 2022 - 10:49

Yes, type_offset = 30 now.

 

Then, this line, type_offset = 45 now.

 

Then, this line, type_offset = 49 now, and the pixmap list is only 35 long.


Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #6 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 2 June 2022 - 11:05

https://github.com/O...dTimer.py#L1267

-if x.pipzap:
+if x.pipzap and not x.repeated:				
    type_offset = 30

 

 


Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #7 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 2 June 2022 - 11:36

That works :)

 

But it shows the repeated-zap icon: Attached File  repzapclock.png   441bytes   1 downloads

 

Not the (non-existant) repeated-PiP-zap icon.

 

Good enough for me though. Thanks!


Edited by scriptmelvin, 2 June 2022 - 11:37.

Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #8 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 2 June 2022 - 17:30

[RecordTimer] isInTimer - fix not visible icons pipzap repeat

[PartnerboxEPGList] isInTimer - fix not visible icons pipzap repeat


Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #9 WanWizard

  • PLi® Core member
  • 62,670 posts

+1,476
Excellent

Posted 2 June 2022 - 17:42

Merged.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), SAB AlphaTriple HD (S2+T2), (Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will have periods of inactivity, during which I won't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: Repeating PiP zap timer does not use PiP #10 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 16 June 2022 - 15:16

PiP zap only works in the same session in which the timer was created. When enigma2 is restarted, it zaps without PiP again. The cause is that self.InfoBarInstance = None in this line.

 

That seems to be caused by the fact that when the timer list is read from timers.xml at enigma2 startup, InfoBar is not yet instantiated, so self.InfoBarInstance is set to None here.


Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #11 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 18 June 2022 - 00:07

No takers?


Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #12 WanWizard

  • PLi® Core member
  • 62,670 posts

+1,476
Excellent

Posted 18 June 2022 - 00:48

Appearently not ;). It is far above my pay grade, so I have to pass...


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), SAB AlphaTriple HD (S2+T2), (Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will have periods of inactivity, during which I won't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: Repeating PiP zap timer does not use PiP #13 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 18 June 2022 - 07:17

PiP zap only works in the same session in which the timer was created. When enigma2 is restarted, it zaps without PiP again. The cause is that self.InfoBarInstance = None in this line.

 

That seems to be caused by the fact that when the timer list is read from timers.xml at enigma2 startup, InfoBar is not yet instantiated, so self.InfoBarInstance is set to None here.

How to check it (example)?


Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #14 littlesat

  • PLi® Core member
  • 53,756 posts

+639
Excellent

Posted 18 June 2022 - 07:25

Sounds like this was never implemented in the right way…. I also personally do not see a real added value in a pip zap timer..

Edited by littlesat, 18 June 2022 - 07:31.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Repeating PiP zap timer does not use PiP #15 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 18 June 2022 - 07:41

test


Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #16 ims

  • PLi® Core member
  • 12,894 posts

+197
Excellent

Posted 18 June 2022 - 07:53

 I also personally do not see a real added value in a pip zap timer..

I am using it time from time ...


Kdo nic nedělá, nic nezkazí!

Re: Repeating PiP zap timer does not use PiP #17 Dimitrij

  • PLi® Core member
  • 8,711 posts

+287
Excellent

Posted 18 June 2022 - 08:32

[RecordTimer] always check InfoBarInstance


Duo 4K/Lunix3-4K/Solo 4K


Re: Repeating PiP zap timer does not use PiP #18 scriptmelvin

  • Senior Member
  • 163 posts

+5
Neutral

Posted 18 June 2022 - 11:45

Sounds like this was never implemented in the right way…. I also personally do not see a real added value in a pip zap timer..

 
IMHO a feature should either work properly, or be removed. Added value is to be determined by users. I find it quite useful.
 

%5BRecordTimer%5D always check InfoBarInstance


Thank you, that is more or less how I implemented it :). The import is not needed though, already present here.


Vu+ Uno 4K SE CD Triple LNB Quad Triax TDS64 OpenPLi 8.2-release 2022-06-05


Re: Repeating PiP zap timer does not use PiP #19 Pr2

  • PLi® Contributor
  • 5,500 posts

+238
Excellent

Posted 19 June 2022 - 13:56

Sounds like this was never implemented in the right way…. I also personally do not see a real added value in a pip zap timer..

 

One of the idea behind PiP zap was that TV show never starts at the expected time, so by having a PiP zap you can keep an eye on your future TV show and really zap to it when it effectively start.


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)

AB-Com: PULSe 4K 1*DVB-S2X (+ DVB-C/T/T2)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 


Re: Repeating PiP zap timer does not use PiP #20 Erik Slagter

  • PLi® Core member
  • 46,796 posts

+539
Excellent

Posted 22 June 2022 - 16:29

Yeah, I understand  :)


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users