Jump to content


Photo

FritzCall Plugin - guest WLAN status not correct


  • Please log in to reply
60 replies to this topic

Re: FritzCall Plugin - guest WLAN status not correct #21 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 5 November 2022 - 21:36

It was not German language related after all, but unicode related. Please test again: FritzCallFBF.py


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #22 Stan

  • Senior Member
  • 320 posts

0
Neutral

Posted 6 November 2022 - 10:46

@scriptmelvin

 

I had a look at your latest changes. This is one way to do it, I guess... and it works...

But wouldn't it be better, in regards to future updates, to pick the fix from the original FritzCallFBF.py ?


Edited by Stan, 6 November 2022 - 10:47.


Re: FritzCall Plugin - guest WLAN status not correct #23 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 6 November 2022 - 18:38

You are probably right (and my fix was python3 only). I took the opendreambox version now, it seems to have more features and is less crash-prone, and it works on python2 and python3. I then applied two fixes:

  • Fix WLAN guest status always off when fritzbox is set to English
  • Fix WLAN guest status can be activated but not deactivated with yellow button

Would you care to test again? FritzCallFBF.py


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #24 Stan

  • Senior Member
  • 320 posts

0
Neutral

Posted 6 November 2022 - 19:47

As this is a major update (which btw. should also include the latest plugin.py), it requires quite a lot of testing. According to the relese notes, this update consists mostly of adaptations for yet unreleased firmware versions (Fritz!Lab). There's always a risc that it breaks something for the older Fritz!OS versions.

 

Could you instead at first apply your patches for guest WLAN to the current PLi version?


Edited by Stan, 6 November 2022 - 19:55.


Re: FritzCall Plugin - guest WLAN status not correct #25 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 6 November 2022 - 21:04

Fair enough. How about FritzCallFBF.py?


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #26 Stan

  • Senior Member
  • 320 posts

0
Neutral

Posted 7 November 2022 - 09:38

Works for me :)



Re: FritzCall Plugin - guest WLAN status not correct #27 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 7 November 2022 - 20:45

master: Fix guest WLAN always displayed as disabled part 2 #841

 

python3: Fix guest WLAN always displayed as disabled part 2 #842


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #28 WanWizard

  • PLi® Core member
  • 68,683 posts

+1,740
Excellent

Posted 8 November 2022 - 13:05

Merged. Don't forget to also bump the plugins in 8.3-release.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: FritzCall Plugin - guest WLAN status not correct #29 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 8 November 2022 - 15:29

Don't forget to also bump the plugins in 8.3-release.


I will :) After these two (python*-six was missing from deps):
 
Add python-six to depends #843
 
Add python3-six to depends #844


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #30 WanWizard

  • PLi® Core member
  • 68,683 posts

+1,740
Excellent

Posted 8 November 2022 - 15:51

Merged.

 

Not a big fan of six myself, but it seems to be the magic fixer for others... ;)


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: FritzCall Plugin - guest WLAN status not correct #31 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 8 November 2022 - 15:59

Merged.

 

Not a big fan of six myself, but it seems to be the magic fixer for others... ;)

I agree. With a bit of python knowledge and some common sense you don't need it.

 

And the release-8.3 pinning: [fritzcall] update pinning #1140


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #32 WanWizard

  • PLi® Core member
  • 68,683 posts

+1,740
Excellent

Posted 8 November 2022 - 16:00

Merged.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: FritzCall Plugin - guest WLAN status not correct #33 Stan

  • Senior Member
  • 320 posts

0
Neutral

Posted 8 November 2022 - 17:53

Speaking of six, my ET9200 now shows a strange behaviour. With the latest FritzCall patch, it takes the box about 10 seconds to switch on from standby!

 

If I disable the FritzCall plugin and restart the box, everything is back to normal.

 

Strangely, I did not experience this problem with the first version of the fix (which did not use six).


Edited by Stan, 8 November 2022 - 17:55.


Re: FritzCall Plugin - guest WLAN status not correct #34 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 8 November 2022 - 19:19

From "shallow" standby, I assume? That is just plain weird...

 

Just for fun, I removed six. Could you test? FritzCallFBF.py


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #35 Stan

  • Senior Member
  • 320 posts

0
Neutral

Posted 8 November 2022 - 20:47

It is weird indeed. It does not happen at first, only after some time. I will try to find out what it triggers and subsequently test your new version.



Re: FritzCall Plugin - guest WLAN status not correct #36 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 14 May 2023 - 19:44

After reading this topic I tested the DrMichael version (supposedly the original and maintained version) of FritzCall on OpenPLi. It seems to work fine on both 8.3 and NB (and with the latest Fritz!OS).

 

Maybe the OpenPLi version should be removed from the repo, and built directly from the DrMichael repo?


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #37 scriptmelvin †

  • PLi® Contributor
  • 720 posts

+46
Good

Posted 22 May 2023 - 19:54

After reading this topic I tested the DrMichael version (supposedly the original and maintained version) of FritzCall on OpenPLi. It seems to work fine on both 8.3 and NB (and with the latest Fritz!OS).
 
Maybe the OpenPLi version should be removed from the repo, and built directly from the DrMichael repo?


No reactions/opinions from OpenPLi devs on this?


Sorry to inform you this member, my brother, passed away.

Re: FritzCall Plugin - guest WLAN status not correct #38 WanWizard

  • PLi® Core member
  • 68,683 posts

+1,740
Excellent

Posted 22 May 2023 - 19:58

Not a dev, but I have no objections, as long as it is stable and maintained.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: FritzCall Plugin - guest WLAN status not correct #39 mimisiku

  • Senior Member
  • 5,466 posts

+114
Excellent

Posted 22 May 2023 - 20:00

It is very actively maintained by DrMichael in IHAD….


Met één been in het graf..... Helaas

Re: FritzCall Plugin - guest WLAN status not correct #40 WanWizard

  • PLi® Core member
  • 68,683 posts

+1,740
Excellent

Posted 22 May 2023 - 20:05

Ok. As long as it is (and stays) compatible...


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.



0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users