2041 replies to this topic

[littlesat]

Fallback tuner was a new design (and also already years ago) while partnerbox is an old plugin with no real integration at all.

Years ago the idea was to avoid settings when they did not have a real added value and the idea was a client box always needs the remote timer as default and the design was for full client boxes without tuner. This was not true and helpfull afterwards after all these years.

Edited by littlesat, 9 April 2024 - 21:55.

[WanWizard]

You've made me a very happy bunny now.

[WanWizard]

Just a question: just updated, and noticed that the default value for the setting is "yes", which is normally not what we do, introducing a setting that changes the behaviour without a user choosing to do so?

 

Fine for me, but maybe unexpected for others?

[littlesat]

For you the default was indeed no as you enabled a tuner. But for most, as fallback was initially designed for client boxes without enabled tuner, yes is the default. We can of course depend the default if you have a tuner enabled yes/no as addition so users get not surprised by this change… but from the other side add a depandancy might also be obvious. So I doubted about this detail and did consider not to add it.I suggest it has low risk to keep it as it is now (but we do need to mention it in release notes). Better do not have the dependancy for the default as later when you decide to enable/disable a tuner on a client box it also flips… and actually when you enable a fallback tuner you most times want to have this as default as otherwise you usually do not enable it.

Edited by littlesat, 10 April 2024 - 18:13.

[WanWizard]

I understand your reasoning, I'm just saying that after the update, the box behaves differently from before the update.  If that is justified, it's fine by me.

[littlesat]

I understand it…. But I weighted it… when I avoid it the new side effect is that when you enable/disable a tuner on the client box the behavior for the fallback timer default also changes… and I thought that was worser… and I couldn’t think about any logic to resolve this.

Edited by littlesat, 10 April 2024 - 23:26.

[DimitarCC]

Yep I fully understand... and actually I like it as this example makes skinning less depended at the end on the code... And your code is soo clean most times

 

Now I can't wait for a merge request...

 

OK here it is https://github.com/O...igma2/pull/3951

 

Skin updated too.

Edited by DimitarCC, 11 April 2024 - 06:12.

[littlesat]

[Pr2]

@littlesat,  you should think of people that do support for EPG question (I think to doglover), it is already complicated for people that try to add EPG to IPTV and failed due to mis-understanding. Now if the EPG came from a box with conflicting self defined service reference I guess it will be a nightmare to know where the EPG is coming from.  EPG Import, over the air (EIT, etc), self defined and now fallback tuner.

So I would have a conservative approach keep it off, and people that want to use it should enable it and so they know what they do.

 

Imagine all the mess that can happens if EPG Import is running on client box and on the server box, and client box will merge the EPG from the server box.  We have a real risk of double conflicting EPG for the same service reference.

[WanWizard]

This is in response to? I wasn't aware that this was a discussion, or even something that was desired (why)?

[Pr2]

It is a about the fallback tuner and EPG download, isn't it what you are discussing right now in this skin thread?

[WanWizard]

It is a about the fallback tuner and EPG download, isn't it what you are discussing right now in this skin thread?

 

I get that, but I haven't seen any discussion about merging sources?

 

( which also means I have no idea which posts this is all about, and which to split off )

[littlesat]

Please read back as the skin is updated and the enigma2 code not yet... so you've to wait for the next build to get it fixed.

[littlesat]

In the makefile the new addon for MainMenu was missing.... I repaired that but now when we press menu we get 

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
    res = self.actions[action]()
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1061, in mainMenu
    self.session.openWithCallback(self.mainMenuClosed, MainMenu, menu)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 295, in openWithCallback
    dlg = self.open(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 308, in open
    self.execBegin()
  File "/usr/lib/enigma2/python/StartEnigma.py", line 233, in execBegin
    c.show()
  File "/usr/lib/enigma2/python/Screens/Screen.py", line 130, in show
    x()
  File "/usr/lib/enigma2/python/Components/Addons/Pager.py", line 46, in onContainerShown
    self.initPager()
  File "/usr/lib/enigma2/python/Components/Addons/Pager.py", line 199, in initPager
    l_orientation = self.getSourceOrientation()
  File "/usr/lib/enigma2/python/Components/Addons/Pager.py", line 155, in getSourceOrientation
    orig_source = self.source.master.master
AttributeError: 'NoneType' object has no attribute 'master'
[ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.HelpableActionMap object at 0xae9def70>>,('InfobarMenuActions', 'mainMenu')) failed)

[littlesat]

When I chanded e.g. that function to the below code I get a menu, but I cannot select anything.

def getSourceOrientation(self):
 if isinstance(self.source, List):  # Components.Sources.List
  orig_source = self.source.connectedGuiElement or self.source.master.master
 else:
  orig_source = self.source
 if hasattr(orig_source, "instance") and hasattr(orig_source.instance, "getOrientation"):
  return orig_source.instance.getOrientation()
 return eListbox.orVertical

Edited by littlesat, 12 April 2024 - 08:51.

[DimitarCC]

That is weird.....Are some of you using LCD4Linux plugin?

[littlesat]

Nope.... no LCD4Linux plugin.... And as I'm not deep diving into this it is also hard for me to troubleshoot.

 

I only get that I can select... but press OK or a number you go not go to the slected menu....

Edited by littlesat, 12 April 2024 - 10:23.

[DimitarCC]

OK i have found the issue....

But indeed it is interesting why it works on my side....

Anyway i will prepare a fixing PR

 

P.S. here it is https://github.com/O...igma2/pull/3953

 

With that it works and menus seems to be able to be selected.

Edited by DimitarCC, 12 April 2024 - 11:41.

[littlesat]

I can confirm it is resolved...

 

E.g. on the attached screen there is still kind of lack of space.... I did not check if it is due to the max value and/or 'border margins' or so...

 

 menu.jpg   63.76KB   2 downloads

 

[littlesat]

maybe we just need to give the maxwidth a bit more room for this in the MainMenu addon....... maxWidth is now 700 default in the code), maybe change it to 800

Edited by littlesat, 12 April 2024 - 14:02.