2057 replies to this topic

[DimitarCC]

I'm personally still of the opinion that skin related files and skin related code should be part of the skin and not of the base image, but appearently I am alone in that.

 

Now it is not in the core files, but in a dependency package.

[DimitarCC]

for the recipe use that example from OE-A

 

https://github.com/o...ma2-boxlogos.bb

 

Maybe have to be adapted for PLi

[Tech]

As a dependency it is also okay, the package is only included when you install the skin, but I share Wanwizard's opinion that it belongs to the skin unless there is some common ground and the logos can also be used for other plugins..

[Tech]

for the recipe use that example from OE-A

 

https://github.com/o...ma2-boxlogos.bb

 

Maybe have to be adapted for PLi

In that recipe the images are placed in the enigma2 folder while it does not really have anything to do with enigma2, it is really skin related..

[littlesat]

I'm personally still of the opinion that skin related files and skin related code should be part of the skin and not of the base image, but appearently I am alone in that.

Maybe you miss understood. But having renderers and converters for each separate skin is not done. What of they have the same file name....? Then skins could start a 'war'. Install one skin and the other will not work is what is promoted here.

Actually when a skin needs extra features it needs to be supported.

 

I always have the meaning that skins should only use xml code and just as exception have some (python) code inside the xml that can post or pre process something (like we do for the notification box).

 

Boxlogo.py here has common ground perspective... any skin can use it... then not every skin that can use needs to add the code with the same name or a slightly different name.

[littlesat]

In that recipe the images are placed in the enigma2 folder while it does not really have anything to do with enigma2, it is really skin related..

 

I do not see it as skin related. Other skins may also use it (in future). Maybe that is also why I hate those specific skin's renderers and converters... Beside they can have a war with eachother. I remember in the past skins did add the skin name with underscore and then the name of renderer or converter, but then skins came with same name so they had a war on boxes again... I hope this 'red flag' regarding skin specific renderers and converters is clear for now.

 

But the location of the files are indeed not optimal. I suggest a better to let it landed on the box in /usr/share/enigma2/boxlogos or so.... that is the location where enigma2 usually stored these kind of things.

Edited by littlesat, 21 December 2023 - 13:11.

[DimitarCC]

Currently logos are stored in /usr/share/enigma2....

Generally its not an issue to be in subfolder too. that can be extended later.

[littlesat]

We do have the black.mvi and radio.mvi in that 'root' folder... but no pictures (png, jpg, svg) in that root... that is why I prefer a subfolder there. The same as done with rc_models, which point me to this was a good weighted location.

 

Take you time....

Edited by littlesat, 21 December 2023 - 14:18.

[cobus]

Yesterday the decoder (Multibox) have a green screen with this skin. the VU Uno 4K SE don't.

[DimitarCC]

its WIP and currently there are a lot of changes going under the hood.

[littlesat]

Yesterday the decoder (Multibox) have a green screen with this skin. the VU Uno 4K SE don't.

 

This is known... sorry for that... the work-a-round is remove the skin 'row' in /etc/enigma2/settings with help from putty and vi or so... and temporary use the old standard skin and wait... DimitarCC could also put the replacement here for the renderer that gives the GSOD.

Edited by littlesat, 21 December 2023 - 14:58.

[DimitarCC]

Well since the renderer now dont exists anymore you can download it from here https://forums.openp...dpost&p=1591828

 

Or just delete it till the update and under the hood changes are done.

[DimitarCC]

So meanwhile i have changed the renderer to search the logos in /usr/share/enigma2/logos. I have named the subfolder simply "logos" since there are not only "box" logs but brand and distro logo. So i think "logos" is better name for it.

[littlesat]

I agree this is a good weighted folder name... At least there is an idea, disclaimer and argument behind it.

Edited by littlesat, 21 December 2023 - 15:24.

[WanWizard]

Maybe you miss understood. But having renderers and converters for each separate skin is not done. What of they have the same file name....? Then skins could start a 'war'. Install one skin and the other will not work is what is promoted here.

 

If non-active skins have active code, then the skin system design is all wrong. I see this kind of argument a lot, something isn't possible because "that is not how it works", without asking yourself if the design should be changed.

[littlesat]

If non-active skins have active code, then the skin system design is all wrong. 

 

Here you have the point the design is so wrong....  but we all know it.

 

But as it is designed now you have renderers and converters etc. in the enigma2 python code. Skins should not put their own stuff there in the same directly as this creates a kind of war in those folders. It can even overwrite standard code. Here I can only draw red flags...

 

But there is nothing in the design to put them decently elsewhere..

 

So I think when a skin need a feature then we have two choices... make a redesign so skins can add imbedded renderers and converters... or we add a helpful converter that also other skins can share...

Edited by littlesat, 21 December 2023 - 17:44.

[WanWizard]

So we're back to "we don't fix anything that is wrong, we just pile more shit on top"...

[littlesat]

I only try to avoid more shit on the shit... At least I think this is a good beginning...

 

The whole skin stuff in enigma2 is a nightmare... We improved it a lot over more than a decennia... but the real fix is a complete re-design... and you're aware if it... I thought we all agreed that poking around in enigma2 standard code should be avoided... and dumping renderers and converters by skins in the enigma directories with even a risk overwriting standard code was something we should avoid.... and that is exactly why I try to avoid this here.

Edited by littlesat, 21 December 2023 - 18:57.

[Huevos]

So how are you going to manage to install 2 packages with the same filenames? OPKG is not going to allow that. Or are you talking about people not using OPKG? If so let them sort their own mess out.

[Huevos]

 

Maybe you miss understood. But having renderers and converters for each separate skin is not done. What of they have the same file name....? Then skins could start a 'war'. Install one skin and the other will not work is what is promoted here.

 

If non-active skins have active code, then the skin system design is all wrong. I see this kind of argument a lot, something isn't possible because "that is not how it works", without asking yourself if the design should be changed.

 

Skins don't have code except in the xml file. We are talking about py files that are packaged with the skin because they are missing in the image. Surely you can't be suggesting hiding python code based on what skin is running.

Edited by Huevos, 21 December 2023 - 19:34.