81 replies to this topic

[littlesat]

There is also nothing in our code like usable characters. It here simply give as type that the input should be a NUMBER... So where does it go wrong?

                def changeDuration(self, entry):
                                if entry is not None and entry >= 0:
                                                self.selectedEntry = entry
                                                self.session.openWithCallback(self.inputCallback, InputBox, title=_("How many minutes do you want to record?"), text="5", maxSize=False, type=Input.NUMBER)
 
                def addRecordingTime(self, entry):
                                if entry is not None and entry >= 0:
                                                self.selectedEntry = entry
                                                self.session.openWithCallback(self.inputAddRecordingTime, InputBox, title=_("How many minutes do you want add to the recording?"), text="5", maxSize=False, type=Input.NUMBER)

Edited by littlesat, 23 August 2023 - 13:00.

[littlesat]

So I suggest we should revert this: https://github.com/O...edd07a67ba42f38 it does not have any added value as I cannot verify how to get it not being a number in the first place.....

[Stan]

I just tried to verify the issue with the 5 space 5... but I tried with instant recording but I was not able to get it. How did you arrange to get 5 space 5... I can't.

Enter 555 then press once [<<]

[littlesat]

What do you mean with [<<]?

[Stan]

[<<] = Button "Previous"

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/StartEnigma.py", line 223, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 2748, in inputCallback
ValueError: invalid literal for int() with base 10: '5 5'
[ePyObject] (CallObject(<bound method Session.processDelay of <__main__.Session object at 0xb1903310>>,()) failed)

 

Edited by Stan, 23 August 2023 - 14:01.

[mrvica]

Stan was quicker

Edited by mrvica, 23 August 2023 - 13:57.

[tension]

I just tried to verify the issue with the 5 space 5... but I tried with instant recording but I was not able to get it. How did you arrange to get 5 space 5... I can't.

It comes from old bugged call in infobarGenerics

self.session.openWithCallback(self.inputCallback, InputBox, title=_("How many minutes do you want to record?"), text="5  ", maxSize=True, type=Input.NUMBER)

now fixed by @ims

[tension]

Perhaps it could be escluded the digit of "tab" in inputBox when input is not text

	def keyTab(self):
		if self["input"].type == Input.TEXT:
			self["input"].tab()

but t i do not know other remote controls chance than mine old vuduo2's one. That is: I have not a blank space (" ") button on the remote control...

 

[ims]

So I suggest we should revert this: https://github.com/O...edd07a67ba42f38 it does not have any added value as I cannot verify how to get it not being a number in the first place.....

this code is not more there... but my fix is in develop only, not in 9rc, imho...

[Stan]

Are RC9 and develop now drifting apart? What is the difference?

Edited by Stan, 23 August 2023 - 15:18.

[ims]

 

[<<] = Button "Previous"

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/StartEnigma.py", line 223, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 2748, in inputCallback
ValueError: invalid literal for int() with base 10: '5 5'
[ePyObject] (CallObject(<bound method Session.processDelay of <__main__.Session object at 0xb1903310>>,()) failed)

it was fixed 3 days ago, it is impossible type anything than numbers yet there.

 

RC9 is fixed to date release and develop goes ahead ( only WW can shift a pin of enigma in RC).

Edited by ims, 23 August 2023 - 15:35.

[littlesat]

I see it...

 

Nice...

 

https://github.com/O...288e3e377c90ecb

 

Actually the initial default value was set wrong.... creasy...

[WanWizard]

Are RC9 and develop now drifting apart? What is the difference?

 

No, but syncing is a manual operation, and only happens when changes in develop are proven to be stable.

 

And the rc build doesn't run continuously, but is started manually to (we run develop builds in a CI environment, 24/7).

[ims]

I see it...

 

Nice...

 

https://github.com/O...288e3e377c90ecb

 

Actually the initial default value was set wrong.... creasy...

What ? It is fuly fixed now. Is possible put numbers only and remove numbers ... no spaces more.

[Stan]

Does this mean, that bugs reported for RC9 get fixed in develop first? It's difficult to keep track in terms of testing.

Edited by Stan, 23 August 2023 - 15:58.

[ims]

Does this mean, that bugs reported for RC9 get fixed in develop first?

yes ... work on develop (nightly builds) continues ...

[WanWizard]

Indeed.

 

Besides that, rebasing the rc branch with the develop updates is easier than backport fixes in the rc branch that could collide with ongoing development.

[littlesat]

But I also looked for the reason why the "5  " was in there for the first place,,,

 

The "issue" was introduced here: https://github.com/O...0343341603eaba5

 

"InfoBarGenerics - restrict minutes for changeDuration and addRecordingTime to 3 digits.

This avoids that users set incredible amount of minutes (e.g. 99999999) which then creates a BS in TimerList
ValueError: timestamp out of range for platform time_t"

 

So the issue that was tried to resolve with this is back in.... maybe we should make maxSize not only True/False, but also allow that it is a number (e.g. 3) and arrange the number could not be more than 3 digits...

 

And I see that complete Inbox stuff... that is not a nice code... maxSize is a bool here and the size is defined by the initial string... I would expect this should be a simple number... and the maxsize in the code is therefore determined by the lenght of the string... I hope this can be one or less easily changed... or we capture it when the number became too high that removed/block the latest digit....

Edited by littlesat, 24 August 2023 - 14:21.

[ims]

about limit ... may be limited to 1440 minuts, as it exist for "infinity".

[Stan]

If Input is > 1440, then display a message about the maximum allowed and clear inputbox.