117 replies to this topic

[WanWizard]

Maybe you should get out more, there is more out there than you and your own requirements.

[DimitarCC]

So i have a new implementation of that... Currently in OpenViX only but you can get the base idea from this pull https://github.com/O...igma2/pull/1023.

The whole implementation is in c++ now and storage file is simple text file in this format

1:0:19:403:3FA:1:1:0:0:0|1091|1096|-1|-1|-1|-1|-1|-1|71762177
1:0:19:402:3FA:1:1:0:0:0|1981|1982|-1|-1|-1|-1|-1|-1|-1
1:0:1:3FD:618:1:1:0:0:0|1001|1002|-1|-1|-1|-1|-1|-1|-1
1:0:1:3FD:20:1:1:0:0:0|5682|5698|-1|-1|-1|-1|-1|-1|13500930
1:0:1:3FD:18:1:1:0:0:0|256|257|-1|-1|-1|-1|-1|-1|-1
1:0:19:426:3FA:1:1:0:0:0|4916|4932|-1|-1|-1|-1|-1|-1|-1
1:0:19:408:3FA:1:1:0:0:0|4665|4681|-1|-1|-1|-1|-1|-1|-1
1:0:1F:417:3FA:1:1:0:0:0|1059|-1|-1|-1|3059|-1|-1|-1|-1
1:0:19:3FD:33:1:1:0:0:0|816|832|-1|-1|-1|-1|-1|-1|-1
1:0:19:3FE:3FA:1:1:0:0:0|1361|1362|-1|-1|-1|-1|-1|-1|89456897
1:0:1:3FD:19:1:1:0:0:0|5681|5697|-1|-1|-1|-1|-1|-1|6947330
1:0:1F:427:3FA:1:1:0:0:0|1217|2217|-1|-1|-1|-1|-1|-1|-1
1:0:19:558:3FA:1:1:0:0:0|81|-1|-1|-1|-1|-1|86|-1|-1
1:0:1:3FD:16:1:1:0:0:0|256|257|-1|-1|-1|-1|-1|-1|-1
1:0:19:3FD:46:1:1:0:0:0|1079|1095|-1|-1|-1|-1|-1|-1|-1
1:0:19:3FD:48:1:1:0:0:0|1078|1094|-1|-1|-1|-1|-1|-1|-1
1:0:19:410:3FA:1:1:0:0:0|141|146|-1|-1|-1|-1|-1|-1|9503234

The only issue that remains here is the requirement for unique sref so services to be distinguished (that is required for EPG too though). Ofcource that can be extended with setting should we compare the full sref including the url or only the sref...

But apart of that the solution behaves exactly as subtitle and audio track selection for dvb services. So it respects all the settings for auto language selection and so on.

Edited by DimitarCC, 8 May 2024 - 07:09.

[littlesat]

I think this is not a good idea and there is also no need for this. The last selected audio and subtitles are already stored (via lamedb). So it is absurt to add an extra file for this.
What problem do you try to resolve here?
When the issue is that something ‘overwrites’ the lamedb file or so than this ‘trigger’ should be used as all the stuff is simply available in the ‘old’ lamedb file. You should be able to somehow ‘merge’ it.

Edited by littlesat, 8 May 2024 - 07:59.

[littlesat]

Oh sorry this was for iptv…. Then there is indeed nothing in the lamedb. When you add service ref etc then I think it could also be stored in the lamedb…

Edited by littlesat, 8 May 2024 - 08:03.

[DimitarCC]

I think this is not a good idea and there is also no need for this. The last selected audio and subtitles are already stored (via lamedb). So it is absurt to add an extra file for this.
What problem do you try to resolve here?

 

It is stored via lame db but ONLY for normal DVB services and never  for streams (IPTV).

That solution fix that gap.

Currently if you watch IPTV service and select a subtitles and dont have auto language selection enabled when zap away and go back to that service the selected track is forgotten.

With that solution it is remembered.

[DimitarCC]

Oh sorry this was for iptv….

 

Yup!

[littlesat]

I hope to see a merge request.

[Stan]

@DimitarCC

Some questions about this new file:

 

Does it work also for channels via streamrelay?

In which folder is the file stored on the box, will it be included in system backups?

How often is written to this file (flash memory)?

Edited by Stan, 8 May 2024 - 08:22.

[DimitarCC]

I hope to see a merge request.

 

Will try to prepare one

[DimitarCC]

@DimitarCC

Some questions about this new file:

 

Does it work also for channels via streamrelay?

In which folder is the file stored on the box, will it be included in system backups?

How often is written to this file (flash memory)?

 

Currently it works for all services that have :// in service reference string. So it should work for stream relay one too.

The config is stored in /etc/enigma2/config_av so it should be auto backed up since all in /etc/enigma2 is normally backed up.

To that file is written only if you change the audio or subtitle track for particular service (stream). 

[DimitarCC]

 

I hope to see a merge request.

 

Will try to prepare one

 

 

Here it is https://github.com/O...igma2/pull/3970 But wait build check to complete since the OE-A version of audio selection is different than PLi.

 

P.S. i saw you have merged it... i hope there will be no compile issues

Edited by DimitarCC, 8 May 2024 - 09:01.

[littlesat]

As far for now no compile issues....

[littlesat]

To that file is written only if you change the audio or subtitle track for particular service (stream). 

 

-> So I can understand it only adds a line when it is changed... so when there is only one option, you cannot change it, so nothing is added?

[WanWizard]

Joy. Instead of properly fixing E2's storage issues, we're creating yet another unmanagable text file...

[DimitarCC]

To that file is written only if you change the audio or subtitle track for particular service (stream). 

 

-> So I can understand it only adds a line when it is changed... so when there is only one option, you cannot change it, so nothing is added?

 

Yes. At least that is the idea.

[DimitarCC]

Joy. Instead of properly fixing E2's storage issues, we're creating yet another unmanagable text file...

 

Properly fixing the enigma storage (lamedb) will result to incompatibility to every service editor tools that exists. That's why its better to not touch it imho.

Stream services are detached from lamedb and not stored in there. So if they are added there that will break the tools since they will not know how to handle them....

[Stan]

Can you describe the format of the lines, what does each value represent?

[littlesat]

I agree that this is another lame solution. But we already live with lamedb for 20+ years... and it seems the community nether bothered to re-design this..... except for adding 'new' lame stuff around it... Actually our latest try-out also initiated years ago regarding lamedb release 5, the one with already a better structure in the lame db file was never adapted and by neither any setting editor (the file is still created by OpenPLi and can be readed).

 

So I would say at this life phase of enigma2 I'm afraid we should give-up.

Edited by littlesat, 8 May 2024 - 11:08.

[WanWizard]

Properly fixing the enigma storage (lamedb) will result to incompatibility to every service editor tools that exists. That's why its better to not touch it imho.

 

That is the age-old excuse, and not really the case.

 

How do all external editors work: they ftp files in, and then call enigma using the webif to force a reload.

 

If instead of memory, E2 would have a proper database for storage, this process could remain the same, but the enigma call could be rewritten from "reload" to "import external files".

 

All that is needed for editors to work like normal is an additional enigma call, to export the database data to lamedb / bouquetfiles, so they have the current version to work with.

 

Not that complex (at least a lot less complex than implementing the database).

 

And that is off course only if no API to this database is created, and if the author of the editors are not willing to implement that API (history has shown that they have followed developments).

[littlesat]

I had a dream(box)....

 

I would also like to have the settings in a nice database instead of lamedb....Then also for the fallback client tuners we only need to arrange access to this database instead of copy and pasting and reload files. In addition reorganize the EPG nicely instead of storing it completely in RAM and with shutdown store it in epg.dat and at startup of enigma read the enigma.dat file and for callback client tuners create that file and copy it locally etc.... So put everything in sqlite or something else.... in a structured way.... and then also have settings editors who can read this. And maybe also store the enigma2 config settings in an sqllite file or so etc..... But still most teams are stuck with making even more code and adapting the crapped code instead of doing a real restructuring 'together'.... I also gave-up here.... And now you maybe understand why I do not like e.g. the stuff in changing the config with the callback etc... in the other thread as I think it is much better to target the structure and put it on a kind of standard....

 

When the settings were based on a data base we could simply consider to add a table for the stream audio/subtitle preferred stuff... instead of creating a custom fantasy text file...

Edited by littlesat, 8 May 2024 - 11:18.