Well adding it to standart skin will be not so hard i think... And i can give some help with that. But it will be good if the missing button hooks are added as well. Its not a must but will be good.
Skin: all colour buttons in one widget
Started by Huevos, 30 Oct 2023 10:59
55 replies to this topic
Re: Skin: all colour buttons in one widget #41
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 7 November 2023 - 18:28
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #42
-
- PLi® Core member
- 57,257 posts
+702
Excellent
Posted 7 November 2023 - 18:31
Sorry I currently have no time for that... That's the problem... Even the stream relay change I made offered afterwards too much time... (it took me up to a year to create it).
Talking about 'the missing button hooks' is something not nice... actually we're not missing them and I also think they are wrong to do them via 'text'.... I prefer when they are implemented to have a kind of 'dummy' widget assigned to them and just look if they are preset or not (not present is always invisable) and then also look for the status being visible or invisible or something like that... I also think that your suggestion may make it also possible to create 'flexible' one liner icons for the infobar as feature.... Something I wanted already 10 years ago when I started to create the standard skin, but never actually made.
Edited by littlesat, 7 November 2023 - 18:37.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: Skin: all colour buttons in one widget #43
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 7 November 2023 - 18:44
Ok.. The button hooks are open for discussion but the color buttons addon will work just fine without adding any hooks. So maybe the proposed PR can be merged in enigma and then default skin can be adapted, added new addon widget for infobar, etc. And at some point later can be decided how to proceed with the hooks.
About the hooks the problem is other distros already have it implemented in this way and compatability will be lost if it is implemented different in PLi.
About the hooks the problem is other distros already have it implemented in this way and compatability will be lost if it is implemented different in PLi.
Edited by DimitarCC, 7 November 2023 - 18:46.
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #44
-
- PLi® Core member
- 57,257 posts
+702
Excellent
Posted 7 November 2023 - 18:49
It's merged as it simply looks good!
Doing the 'hooks' for the other buttons with 'text empty' or 'something filled in' is not what it should be... that rises a 'red-flag' for me. That is why I prefer to have it different... when the key is not there, do not show it... when the key is there instead of text empty/something having a bool (visible/invisible or something else) is as I think a more logical approach. For the color buttons having a text or no text is fine as they usually really have a text. I understand that others who already implemented it need to adjust it for compatibility, and that is why it needs discussion, but I still think how this was implemented is wrong... (see my red-flag comment)... But there are many thinks in enigma2 that points me to red flags... 
Edited by littlesat, 7 November 2023 - 18:52.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: Skin: all colour buttons in one widget #45
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 8 November 2023 - 10:16
So since now the code is merged. where is the repo of the default skin? I want to look at it when i get some time and to add the color buttons things.
Regarding the button hooks.... Currently the ButtonSequence addon works with Boolean and StaticText sources. So in PLI instead of text can be defined as Boolean source just like VKeyIcon that already exists in PLi.
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #46
-
- PLi® Core member
- 70,599 posts
+1,821
Excellent
Posted 8 November 2023 - 12:20
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: Skin: all colour buttons in one widget #47
-
- PLi® Contributor
- 4,706 posts
+167
Excellent
Posted 8 November 2023 - 12:22
It's merged as it simply looks good!
Doing the 'hooks' for the other buttons with 'text empty' or 'something filled in' is not what it should be... that rises a 'red-flag' for me. That is why I prefer to have it different... when the key is not there, do not show it... when the key is there instead of text empty/something having a bool (visible/invisible or something else) is as I think a more logical approach. For the color buttons having a text or no text is fine as they usually really have a text. I understand that others who already implemented it need to adjust it for compatibility, and that is why it needs discussion, but I still think how this was implemented is wrong... (see my red-flag comment)... But there are many thinks in enigma2 that points me to red flags...
It seems you don't understand. You could use Boolean() for the button hooks but that would mean you force the skinner to use a graphic. That is why we use StaticText. But if you don't want that Dimitar's code should work fine with Boolean() too.
Re: Skin: all colour buttons in one widget #48
-
- PLi® Core member
- 57,257 posts
+702
Excellent
Posted 8 November 2023 - 17:28
It seems you don't understand. You could use Boolean() for the button hooks but that would mean you force the skinner to use a graphic. That is why we use StaticText. But if you don't want that Dimitar's code should work fine with Boolean() too.
Actually for me it was indeed always a picture. But when you indeed have skins that are using text here it can be a text. I never thought about this kind of idea.... If so the hooks are fine... And maybe indeed I was this time hooked to the pictures.
Edited by littlesat, 8 November 2023 - 17:28.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: Skin: all colour buttons in one widget #49
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 12 November 2023 - 19:06
So i have made a pull for that Button hooks.
https://github.com/O...igma2/pull/3832
It doesnt build now but not because my additions. Something else in development branch doesnt build
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #50
-
- PLi® Core member
- 57,257 posts
+702
Excellent
Posted 12 November 2023 - 19:53
Should I wait for merging it?
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: Skin: all colour buttons in one widget #51
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 12 November 2023 - 20:33
You can merge it. The problem with building is not in my changes. I think it is in before merge. So i think you can merge my PR safely.
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #52
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 13 November 2023 - 08:17
Now it builds fine. 
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #53
-
- PLi® Core member
- 57,257 posts
+702
Excellent
Posted 13 November 2023 - 09:53
It looks less complicated as I thought.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: Skin: all colour buttons in one widget #54
-
- PLi® Contributor
- 1,578 posts
+71
Good
Posted 13 November 2023 - 09:56
Well yes...That is all the required things. To have the widgets there.
Ofcource that is the main hooks now. For system plugins maybe also have to be added such a hooks
P.S. @littlesat: Some offtopic.... Is there a chance my skin to be added to PLi feed?
Edited by DimitarCC, 13 November 2023 - 09:58.
Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)
Re: Skin: all colour buttons in one widget #55
-
- Forum Moderator
PLi® Core member - 14,932 posts
+487
Excellent
Posted 13 November 2023 - 12:15
P.S. @littlesat: Some offtopic.... Is there a chance my skin to be added to PLi feed?
It's already there
Aan de rand van de afgrond is een stap voorwaarts niet altijd vooruitgang....
On the edge of the abyss, a step forward is not always progress....
Hardware: 2x Daily used Vu+ Ultimo 4K - Vu+ Duo 4K SE and a lot more.... - VisioSat BiBigsat - Jultec Unicable Multiswitch 4 positions: 19.2/23.5/28.2 East - Diseqc motorized flatdish antenna
Software : HomeBuild OpenPLi Develop and Scarthgap builds, local cards driven by OsCam
Press the 
button on the buttom right of this message
Have you tried our wiki yet? Many answers can be found in our OpenPLi wiki
Re: Skin: all colour buttons in one widget #56
-
- PLi® Core member
- 57,257 posts
+702
Excellent
Posted 13 November 2023 - 17:09
Thanks Tech!
Good development this... also good discussions especially about the hookups (to give it names instead of what I thought in the first place Booleans for showing png or not).
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
5 user(s) are reading this topic
0 members, 5 guests, 0 anonymous users
