312 replies to this topic

[DimitarCC]

Yes OK. That too.

[littlesat]

https://github.com/O...2a741da5e17cR99

 

This was also real added value... I hope it can be back in.... And also 20 channels in the list and for the two line I hope 15 is possible, but currently this one does not look nice as there is now much space between the services but not between the lines.... So finetuning still needed I'm afraid....

[littlesat]

and maybe  "+0 min" show as "0 min" without symbol "+".

 

-> I suggest this is something the skin should define....

[DimitarCC]

https://github.com/O...2a741da5e17cR99

 

This was also real added value... I hope it can be back in.... And also 20 channels in the list and for the two line I hope 15 is possible, but currently this one does not look nice as there is now much space between the services but not between the lines.... So finetuning still needed I'm afraid....

 

All of this is very subjective....Some people like it tight, some people dont.

So if somebody wants a 20 items per page for a single line mode why dont set it in the ServiceList config (Number of channels shown in channel selection list)? That option is still working.

The custom Number of channels shown in channel selection list also work in two lines mode. So you can adjust that there too.

 

Also the font size can be adjusted relatively (Not added to UI yet). So it is in user's full control.

 

Regarding the mode with Next event.... I have never used it before so what is the purpose? Instead on Now event to show next?

[DimitarCC]

and maybe  "+0 min" show as "0 min" without symbol "+".

 

-> I suggest this is something the skin should define....

 

There is not possible to define localized texts in skin. So that have to be in python. The format however can be defined in skin but not sure is that needed. since you can display minutes only....If you display hh:mm it will be too long i guess.

[littlesat]

I meant the format indeed….

[piplan1966]

Hi
I have an Octagon SX88 4k S2 receiver,
Suppose one channel is playing when I go to the next channel the picture from the first channel stays still until the second channel is played,
Not so in Vu Plus,
What is the difference?

[littlesat]

The osd is currently indeed updated as soon the next channel starts to play.
So eg with iptv when the stream does not start yet you still see the old channel on the osd.

[Dimitrij]

DimitarCC

Regarding the list of channel services.

You've rewritten a lot of code in listboxservice/ServiceList.

But now this needs to be improved.

For example, one of them and this is important:

"Number of channels shown in channel selection list"(config.usage.servicelist_number_of_services_)  set 10.

But the font does not increase in the required proportions; before your changes it looked completely different.

 

And many more things are now broken.

I don’t want to start a big discussion; as always, it will end in a huge number of unnecessary messages that will take a lifetime.

 

 

This is a very delicate topic, a lot of code needs to be rewritten.

Therefore, I don’t want to offend anyone, but what was the point of all these changes?

[DimitarCC]

I would suggest to list what is broken. 

I dont see anything broken right now. (except missing two line with next event mode).

The font scaling was never there too. The view is different but there was never font scaling in PLi. There was in OE-A.

 

The main purpose of this changes are:

1. to have understandable logic inside that listboxservice. Current logic was not understandable and when you touch something everything else got broken

2. Add additional element that was not there before

3. Fix stream relay services grayed out

4. Unify the code so to be exchangeable with OE-A image

[Dimitrij]

1)Try to compare:

old(before your changes) and new image

Skin PLiFullHD

set 10 or 15 --> "Number of channels shown in channel selection list"(config.usage.servicelist_number_of_services_)

Edited by Dimitrij, 14 December 2023 - 10:07.

[DimitarCC]

Why you dont provide screenshots for that if you see the difference? As i dont see any difference. Maybe my settings is not what you do and besides i cant run old version of PLi now.

Also if we want a compatibility with OE-A we can not do it like in the way it was.

 

 

Now days code must have possibility to be shared between distros.

 

And OE-A have explicit options for that font sizes that can be adopted in PLi too. (Currently they are not in the config but code is there on PLi)

Edited by DimitarCC, 14 December 2023 - 10:34.

[Dimitrij]

 

Also if we want a compatibility with OE-A we can not do it like in the way it was.

Now everything is clear what your idea is.

[Huevos]

@Dimitrij you are not going to offend anyone by giving your opinion.

 

Font size should not be pegged, it should be configurable by the user. Just because it was like that before doesn't make it correct.

[Huevos]

And many more things are now broken.

If you won't provide a proper list of things that in your opinion are wrong how can anyone know what you are talking about?

Edited by Huevos, 14 December 2023 - 11:10.

[Dimitrij]

For example, the option is two lines, only a progress bar and only on the left.

This means you need to hide the option to select progress bar/percentage, left/right in this mode.

 

[Huevos]

 

For example, the option is two lines, only a progress bar and only on the left.

This means you need to hide the option to select progress bar/percentage, left/right in this mode.

 

 

That is not broken, it is a feature. It should be fixed in setup.xml so the option disappears from config when someone selects 2 line mode.

 

If you have stupid features like that the c++ code becomes spaghetti for no added value.

Edited by Huevos, 14 December 2023 - 11:42.

[littlesat]

Indeed I remember now we did resize the font when we select more or less channels in the service list. Sounds like the OE-A version had less things inside than we had before. Except for the pre-portion (second line needs less room). We also had the extra look with now/next. Indeed the channel selection list stuff might need some repair. We had two two-line modes....

Edited by littlesat, 14 December 2023 - 11:42.

[DimitarCC]

Well to be correct that is not many things broken... its just one

 

But since here in PLi its always advertised how we should not include the kitchen sink...

Here is kind of same since user want everything to work including maybe to make him a coffee as well...

 

In a development POV that will lead to spaghetti code.

 

In your example the progresbar can not be on the right because there will be no place for minutes remaining. Or more settings have to be added to config.

 

The current two line layout is not what it was. As i said it have more elements that was not present in the former one.

 

So its not a matter of fixing but a matter of further extending.

 

I know users get used to before way...But every progress have its collateral damages...If you want to progress at all.

[Dimitrij]

And do you think this is a normal answer?