312 replies to this topic

[littlesat]

1. Here you see in the first raw the current event... and in the second raw the next event...

2. Maybe swap the fields....

3. Should be added... in the first place as is... but I still think this can be done smarter. At least when you select defined by skin you should not see them. And somehow having back the auto-resize would be nice.....Then an extra config yes/no/auto (default no... and not visible when defined by skin) and with yes add the three option would be nice.... (I hope you get it).

 

Strange I recommended an extra config isn't it?

 

I understand but please note that for me is also not easy to work with separate pull requests for every single little change. That is so much time consuming. Time that i not always have.

 

That is the big disadvantage from forks. Better work together in one thing. 

Edited by littlesat, 14 December 2023 - 18:33.

[Dimitrij]

Two line and next event

[littlesat]

@Dimitrij, are you able to show a snapshot from the now/next view.... I'm 100% sure DimartarCC can get it back once he has seen it and I'm also sure he also can make the look better as it was... (EDIT: sorry seems to be done)

 

As soon everything is finetuned I'm willing to get the skin at least cleaned up and finetuned...In between a lot of stuff is synched between VIX and OpenPLi just by this skin...

Edited by littlesat, 14 December 2023 - 18:23.

[littlesat]

B.t.w. the WAF is always extreme important... WAF = Wife Acceptation Factor....

[DimitarCC]

Two line and next event

 

OK. But Now event is displayed on first line...In the new design on the end of first line there is service resolution icon and service type, crypto, record icon. So the space for Now event will be soo short. You almost can see anything.

[littlesat]

It could be re-arranged of course... swap the icons stuff to the second line... Maybe Dimitrij can draft a picture...

Edited by littlesat, 14 December 2023 - 18:29.

[DimitarCC]

1. Here you see in the first raw the current event... and in the second raw the next event...

2. Maybe swap the fields....

3. Should be added... in the first place as is... but I still think this can be done smarter. At least when you select defined by skin you should not see them. And somehow having back the auto-resize would be nice.....Then an extra config yes/no/auto (default no... and not visible when defined by skin) and with yes add the three option would be nice.... (I hope you get it).

 

 

I understand but please note that for me is also not easy to work with separate pull requests for every single little change. That is so much time consuming. Time that i not always have.

 

That is the big disadvantage from forks. Better work together in one thing. 

 

1. I saw the screenshot but there are differences in the new layout and i dont think there is enough space for now event.

2. OK maybe. But maybe an options have to be added  to control when to display remaining time or percent passed. Since now if you have percent instead of progress its odd to have remaining time in minutes too

3. as i said that have to be discussed with other distros since the code is shared now and they have to agree to that change too.

[DimitarCC]

It could be re-arranged of course... swap the icons stuff to the second line... Maybe Dimitrij can draft a picture...

 

it can but then on the second line for next event you will not display duration but the icons...And that is kind of a lot of logic to swap the lines.

[littlesat]

And that is kind of a lot of logic to swap the lines.

 

I understand that this causes if/then/else stuff for all these icons all over the place.... 

 

P.S.

Long long time ago and that is also something DMM did in his closed source sjit... is to do the painter stuff in python...  and not in cpp... I tried to start this as project I think already more than 10 years ago. But when you make bugs in the python painter (at that time) the error was not really good indicated and then I did stop developing it... and finally I never get to it. When you do this correctly and find a way to show the errors good during development the painter may become more flexible... with less 'swigs' to the cpp code... (but a bit slower of course)....

Edited by littlesat, 14 December 2023 - 18:56.

[DimitarCC]

I have already had implementation of that in pure python (by using a ePythonMultiContent like the MovieList). However it is notably slower that c++ version. So i reverted back to c++ version.

Edited by DimitarCC, 14 December 2023 - 19:02.

[littlesat]

Yep and that was also for me a reason to stop it.

[DimitarCC]

So that is what i was able to achieve regarding two line + next event mode.

 

 twolinenext.jpg   162.74KB   2 downloads

 

 

Regarding the progressbar position in two line mode it is just not possible to move it around since it kind of fluid now between normal and next event mode.

 

So that will stay static. 

 

The question here is should the relevant option be removed when we are in two lines mode (that will cause issues and/or settings lost)? Or to keep them visible but just not working in two lines mode?

Edited by DimitarCC, 15 December 2023 - 09:10.

[littlesat]

Looks wonderfull...

 

I would make it backwards compatible somehow when the config is False show normal, True show the two line we had.... and then go for the new values? (I hope I understood this correctly).

When for a specific view it is not helpful or possible to move the bar... we don't... It is just the evidence that many configs will give many issues.... and exactly tells us why we should be careful to add too many custom configurations.... every custom thing you add needs support and adds complications... And everything you add people are getting used to so when it is gone for some reason you experience protests... this is a never ending story... So I hope you understand why I'm always try to withhold extra configs...

 

We had it toggling between 3 modes with the text button... the setting had 3 modes.... And the toggling made sense so you could change between views instantly without going to a menu...

Edited by littlesat, 15 December 2023 - 09:55.

[DimitarCC]

So in general i suggest to not hide the values when we switch two line modes because i use some settings but not all.

 

For example i have for single line:

- none, progressbar left, progressbar right, percentage left, percentage right

 

For two line modes i have this possible options:

- none, progressbar left, percentage left

 

So if i remove the setting conditionally only for two line modes when the user have set progressbar right in single line mode and switch to two lines it will change his setting to progressbar left....

And when switch back to single line the old setting will be lost.

 

 

So i suggest keep the config like it is but in the descriptions add comment that for two lines some options have no effect.

[Dimitrij]

"Show event-progress in channel selection"

"Show service type icons"

"Show crypto icons"

"Show record indicator"

"Show columns"

"Number of channels shown in channel selection list"

 

These settings should automatically hide or change the available values depending on "Show two lines per entry" mode.

At least that's how it used to be.

[DimitarCC]

"Show event-progress in channel selection"

"Show service type icons"

"Show crypto icons"

"Show record indicator"

"Show columns"

"Number of channels shown in channel selection list"

 

These settings should automatically hide or change the available values depending on "Show two lines per entry" mode.

At least that's how it used to be.

Did you read the before post? If we hide or change them it will result to above.

[Dimitrij]

This is all solvable.

[littlesat]

You can not really hide them..... but at the description you can add a note that it might not be configurable in all the modes.

[DimitarCC]

This is all solvable.

 

OK. i will leave it to you then.

[DimitarCC]

You can not really hide them..... but at the description you can add a note that it might not be configurable in all the modes.

 

That was my idea too.