18 replies to this topic

[sjlouis]

Hi,

 

I want to save automaticaly some files as the timers but I've seen if I have reactivated a timer, the hdd timers file is not modified. The modified timer is only kept in the memory unless I restart openpli. If I create a timer, the file is immediately stored on the hdd. What is the problem please?

 

I've searched on the forum if there were an information on this subject and I have found a previous subject I posted a few years ago. I have noticed old timers were not deleted automatically after the number of days indicated in the settings if the dreambox was switched off and switched on several days after the number of days indicated in the settings.

 

Example : I create a timer, I get the record and a few days later I switch off the dreambox. In the settings, I have chosen to delete old timers after 8 days. If I switch on the box 10 days later, openpli does not delete the old timers even if I wait a few days. Perhaps openpli counts only the number of days where the box is switched on.

 

This little problem is still present even if it's not dramatic .

Edited by sjlouis, 5 December 2023 - 16:34.

[WanWizard]

In general nothing in Enigma is saved until you stop or restart Enigma. The same is true for the configuration and EPG data.

 

The design is stil from the time I/O was expensive and should be avoided where possible.

[sjlouis]

WanWizard, I think you were right a few years ago. I had noted this fact but I think this has been changed   .

 

I did tests with settings (I added a script on the long yellow touch) and it was stored immediately. I added a timer in the timers file and it was immediately stored. I deleted it and it was immediately stored .

 

I haven't done a lot of tests but I think it's better to store immediately to avoid losing data if the box crashes or if the user switch off  the box .

[WanWizard]

In some cases for specific reasons a direct save has been added. But this is definitely not generic.

 

I haven't done a lot of tests but I think it's better to store immediately to avoid losing data if the box crashes or if the user switch off  the box .

 

We are not in disagreement on this point.

[littlesat]

As far I can see at all points where you change a timerEntry they are saved.... And that straightaway... So the should be something strange with you config

[sjlouis]

Littlesat, I remember some changes were not stored immediately and WanWizard have the same memory .

 

Can you test with timer activation and deactivation? It does it with 2 box. This modification is not stored on the hdd immediately. The other modifications are stored immediately.

Edited by sjlouis, 5 December 2023 - 18:04.

[littlesat]

I checked the code and it is saved after every change so it would be helpful to understand more, Where are you doing the deactivation and reactivations? On what screen.

Edited by littlesat, 5 December 2023 - 19:58.

[sjlouis]

In the standard screen (I can choose the English language) :

Attached Files

•  screenshot_2023-12-06_14-55-14.jpg   129.33KB   2 downloads

Edited by sjlouis, 6 December 2023 - 15:01.

[littlesat]

In the TimerEdit.py screen mayby when you 'safely' leave that screen we could consider to add...

 

self.session.nav.RecordTimer.saveTimer()

 

I think this is the easiest way to resolve it...

 

https://github.com/O...y#L404C1-L404C1

                def leave(self):
                                self.session.nav.RecordTimer.on_state_change.remove(self.onStateChange)
+                               self.session.nav.RecordTimer.saveTimer()
                                self.close()

Edited by littlesat, 6 December 2023 - 16:14.

[sjlouis]

I do want to believe you .

 

When I modify an hour or the location to save the file, when I press "OK", the modifications are stored on the HDD.

 

When I modify with yellow touch (activate or deactivate), when I press "OK", the modification in stored in the memory but not on the HDD.

 

If I quit with with "Exit", nothing is stored, which is correct.

[littlesat]

Usually when you close enigma2 normally everything should be stored. But when you pull the plug then indeed there is a chance it is not stored. The suggestion I just gave is save it when you leave the timeredit screen. In the timerentry screen this is already done.

[Dimitrij]

	def toggleDisabledState(self):
		cur = self["timerlist"].getCurrent()
		timer_changed = True
		if cur:
			t = cur
			if t.external:
				self.fallbackTimer.toggleTimer(t, self.refill)
			else:
				stateRunning = t.state in (1, 2)
				if t.disabled and t.repeated and stateRunning and not t.justplay:
					return
				if t.disabled:
					print("[TimerEditList] try to ENABLE timer")
					t.enable()
					timersanitycheck = TimerSanityCheck(self.session.nav.RecordTimer.timer_list, cur)
					if not timersanitycheck.check():
						t.disable()
						print("[TimerEditList] sanity check failed")
						simulTimerList = timersanitycheck.getSimulTimerList()
						if simulTimerList is not None:
							self.session.openWithCallback(self.finishedEdit, TimerSanityConflict, simulTimerList)
							timer_changed = False
					else:
						print("[TimerEditList] sanity check passed")
						if timersanitycheck.doubleCheck():
							t.disable()
				else:
					if stateRunning:
						if t.isRunning() and t.repeated:
							list = (
								(_("Stop current event but not coming events"), "stoponlycurrent"),
								(_("Stop current event and disable coming events"), "stopall"),
								(_("Don't stop current event but disable coming events"), "stoponlycoming")
							)
							self.session.openWithCallback(boundFunction(self.runningEventCallback, t), ChoiceBox, title=_("A repeating event is currently recording. What would you like to do?"), list=list)
							timer_changed = False
					else:
						t.disable()
				if timer_changed:
					self.session.nav.RecordTimer.timeChanged(t)
+					self.session.nav.RecordTimer.saveTimer()
			self.refill()

	def runningEventCallback(self, t, result):
		if result is not None and t.isRunning():
			findNextRunningEvent = True
			if result[1] == "stoponlycurrent" or result[1] == "stopall":
				findNextRunningEvent = False
				t.enable()
				t.processRepeated(findRunningEvent=False)
				self.session.nav.RecordTimer.doActivate(t)
			if result[1] == "stoponlycoming" or result[1] == "stopall":
				findNextRunningEvent = True
				t.disable()
			self.session.nav.RecordTimer.timeChanged(t)
+			self.session.nav.RecordTimer.saveTimer()
			t.findRunningEvent = findNextRunningEvent
			self.refill()

 

[littlesat]

Yes exactly something like that. Please create a merge request.

Edited by littlesat, 7 December 2023 - 07:02.

[sjlouis]

Littlesat, I've changed language to English and the first screen timers name is "Timer overview". Is this one you name timeredit ?

 

And the second where me can modify a timer, his name is Timer entry. In this one, the modifications are immediately saved.

 

Effectively, it would be well the modifications in the first screen were saved   .

[littlesat]

I’m waiting for a merge request from dimitrij as his code suggestion most likely will resolve it.

[sjlouis]

OK, thank you Dimitrij and littlesat   .

[Dimitrij]

 

[TimerEdit ] save timer in config if enable/disable it

[littlesat]

Merged..

[sjlouis]

OK, thank you .