59 replies to this topic

[littlesat]

Yes we did indeed refuse Andy’s commits as he did not had an ear for improvements. We’re especially talking about the timeshift stuff. When he could listen and put his ego on the site that time we did not had this discussion. There are too many ego’s. DMM refuses even more stuff and due to that the community created a lot of work-a-rounds like the function stealing plugins…. At that time you was even not involved in this community. Oe-a was initiated that time because pieterg refuses to help Andy with an oe update. And indeed we forked dmm but we were the first that did improve dmm’s stuff and always (tried) to merge back. This is quite different from those who forked from us…. At the end a fork is good for opensource but also bad….. this time it is bad because the project is out of control and wild grow…. Not accepting merge request is try to get control, but when someone accepts comments, you can get a fork. Do not blame us…. Blame the situation.

At the end of course we would consider or like to have a merge request. Maybe that also motivates me to improve that code as well…. As this motivates me also as the way prev_value is done rises a flag (store it in a local, do something, check it in a test -> you should know previous in forehand)…. My issue here is that it is getting too big for me now so I need help here.

Edited by littlesat, 11 May 2024 - 09:48.

[Huevos]

The problem is there are a lot of changes over 12 years. That is when the setup.xml could first be used in plugins.

 

So, probably, the best thing to do is port the changes to PLi and then worry about small improvements later.

Edited by Huevos, 11 May 2024 - 15:55.

[littlesat]

15 years ago is 2009 where is that xml commit than…. And actually this was about the notifiers.
One of them the one that is intended to rebuild configLists when a value is changed I had already an solution without fallback that target the change….
Indeed first sync get it to work and then improve afterwards is a good idea…. And I also can keep the fallback for those plugins but better target the prev_value stuff differently so you can do at the end of those key press functions call another function for that callback with the test and adjust the new prev_value included.

[littlesat]

For example here you do a nice ‘trick’ that avoids the prev and maybe also an extra prev where you actually set the config

 

https://github.com/O...9875b95ba40dea0

 

then the test to check if value (new value) is not equal, you can set it, and do the ‘fallback’…. In a new separate function….

 

this exactly points me with what I meant….  And when the new function is actually the only point that does self.value = a different value…. Then you also target the other notifiers… 

 

I hope you understand what I mean here…

(I can revert my stuff of course… history happened to this stuff….)

Edited by littlesat, 11 May 2024 - 16:36.

[Huevos]

The callback, everyone else is using it. The crash was because it was missing from PLi, not the other way round. Our images are backwards compatible. The problem is PLi not forwards compatible (yet) and that plugin was written to use it. Anyway, not important.

 

Maybe best thing would be have a feature branch and add into "develop" once preliminary testing has been done.

[littlesat]

That everyone else is using it will not say that it is a good smart implementation… but it is what it is for now… just like the boxinfo sff… I also do not understand why a plug-in should hack at that level? A branch is nothing when it is not build. Here wanwizard should help. Thanks in advance for your help. But in fact it are two files that needs to be adjusted… so doing it in a feature branch is fine. Once this is done I can help to get my suggestions in… (where the fallback will stay)

Edited by littlesat, 11 May 2024 - 17:54.

[WanWizard]

Here wanwizard should help.

 

Help with what?

[littlesat]

A build for a feature brench. But I think I also can make a small script with wget

Edited by littlesat, 11 May 2024 - 19:10.

[WanWizard]

An Enigma feature branch? Which one? And for which box?

[littlesat]

That should be aligned with huevos when he helps me… for me ucclan.

[WanWizard]

Ok. Let me know what exactly you want build if you're ready.

[littlesat]

If you can do two boxes is also nice…

[WanWizard]

"The difficult things we do immediately, there is a short waiting list for the impossible..."

[littlesat]

I just copied and pasted the config.py and ConfigList.py from OpenVix into OpenPLi and it seems as far I can see for now all work without any modification.....Looks like the 'underlaying' differences are not that many.... so it looks like an easy task....

 

until now I can only find one crash at the autobackup plugin and when you try to set times in sleeptimer.

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 96, in selectionChanged
    x()
  File "/usr/lib/enigma2/python/Screens/Setup.py", line 65, in selectionChanged
    self["SetupValue"].text = self.parent.getCurrentValue()
  File "/usr/lib/enigma2/python/Plugins/Extensions/AutoBackup/ui.py", line 165, in getCurrentValue
  File "/usr/lib/enigma2/python/Components/config.py", line 789, in getText
    (value, mPos) = self.genText()
  File "/usr/lib/enigma2/python/Components/config.py", line 1184, in genText
    value = self.toDisplayString(self._value)
  File "/usr/lib/enigma2/python/Components/config.py", line 1177, in toDisplayString
    retval = strftime(config.usage.time.short.value.replace("%-I", "%_I").replace("%-H", "%_H"), tuple(newtime))
  File "/usr/lib/enigma2/python/Components/config.py", line 2133, in __getattr__
    raise AttributeError(name)
AttributeError: time
[ePyObject] (CallObject(<bound method ConfigList.selectionChanged of <Components.ConfigList.ConfigList object at 0xae147b20>>,()) failed)

 

Traceback (most recent call last):

  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 96, in selectionChanged

    x()

  File "/usr/lib/enigma2/python/Screens/Setup.py", line 65, in selectionChanged

    self["SetupValue"].text = self.parent.getCurrentValue()

  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 241, in getCurrentValue

    return self["config"].getCurrent() and len(self["config"].getCurrent()) > 1 and str(self["config"].getCurrent()[1].getText()) or ""

  File "/usr/lib/enigma2/python/Components/config.py", line 789, in getText

    (value, mPos) = self.genText()

  File "/usr/lib/enigma2/python/Components/config.py", line 1184, in genText

    value = self.toDisplayString(self._value)

  File "/usr/lib/enigma2/python/Components/config.py", line 1177, in toDisplayString

    retval = strftime(config.usage.time.short.value.replace("%-I", "%_I").replace("%-H", "%_H"), tuple(newtime))

  File "/usr/lib/enigma2/python/Components/config.py", line 2134, in __getattr__

Edited by littlesat, 12 May 2024 - 09:52.

[littlesat]

And I found the following in mount stuff..

Maybe need to check of the animation mode is there before calling

self.help_window.setAnimationMode(0)
if hassattr(self.help_window ,"setAnimationMode"):
self.help_window.setAnimationMode(0)

As we do not have animation mode better we change the code in Screen.py by simply do pass around line 205/206 there....

[Skin] Processing screen 'NumericalTextInputHelpDialog', position=(537, 675), size=(846 x 246) for module 'NumericalTextInputHelpDialog'.
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 92, in selectionChanged
    self.current[1].onSelect(self.session)
  File "/usr/lib/enigma2/python/Components/config.py", line 1442, in onSelect
    self.help_window.setAnimationMode(0)
  File "/usr/lib/enigma2/python/Screens/Screen.py", line 206, in setAnimationMode
    self.instance.setAnimationMode(mode)
AttributeError: 'eWindow' object has no attribute 'setAnimationMode'
[ePyObject] (CallObject(<bound method ConfigList.selectionChanged of <Components.ConfigList.ConfigList object at 0xad3c6af0>>,()) failed)
[gRC] Warning: Main thread is busy, displaying spinner!
Killed

Edited by littlesat, 12 May 2024 - 11:31.

[littlesat]

When I replace ConfigClock by our code... and this time our code is much simpler... I do not understand why it is so complicated in VIX... to first crash with the times is also resolved...

class ConfigClock(ConfigSequence):
                def __init__(self, default):
                                t = localtime(default)
                                ConfigSequence.__init__(self, seperator=":", limits=clock_limits, default=[t.tm_hour, t.tm_min])
 
                def increment(self):
                                # Check if Minutes maxed out
                                if self._value[1] == 59:
                                                # Increment Hour, reset Minutes
                                                if self._value[0] < 23:
                                                                self._value[0] += 1
                                                else:
                                                                self._value[0] = 0
                                                self._value[1] = 0
                                else:
                                                # Increment Minutes
                                                self._value[1] += 1
                                # Trigger change
                                self.changed()
 
                def decrement(self):
                                # Check if Minutes is minimum
                                if self._value[1] == 0:
                                                # Decrement Hour, set Minutes to 59
                                                if self._value[0] > 0:
                                                                self._value[0] -= 1
                                                else:
                                                                self._value[0] = 23
                                                self._value[1] = 59
                                else:
                                                # Decrement Minutes
                                                self._value[1] -= 1
                                # Trigger change
                                self.changed()
 
 
date_limits = [(1, 31), (1, 12), (1970, 2050)]

[littlesat]

I just created the branch... of course there is still much work to do... But I also saw Vix code has more lines....

 

https://github.com/O...f380613e87e0abf

[littlesat]

I need to add ConfigAction….

now I see the differences why is eg the pixmap for on/off stored as yes no instead of True False?… for us I resolved it. May need additional checks.

Edited by littlesat, 12 May 2024 - 11:30.

[Huevos]

I start a new thread for this topic.

 

https://forums.openp...posal-and-more/

[littlesat]

Thanks....