15 replies to this topic

[Sharp987]

After the last image update, the satfinder plugin is not working correctly. The receiver is Uclan Ustym 4K pro.

[Abu Baniaz]

Can you describe the issue you are experiencing? There have been changes to improve/streamline code, so something may need tweaking/adjusting.

 

https://github.com/O...f9d0b8a98cb2765

[littlesat]

Indeed what is not good working.?
Maybe you need green to start the scan. (And this also touches the point I never accepted these changes before because there were some points and non consequent responses in regards that ok toggles switches, give choices in a list, while ok is also doing other stuff…. Iansav never discussed this through instead he just hammered the code in via vix, openVision and now openatv
-
Now the wizard also response differently)

Edited by littlesat, 28 May 2024 - 06:27.

[Sharp987]

SNR, BER, Lock are missing.

By the way, in the main menu and similar menus, the icons no longer appear, none of these widgets work:

 

  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/media.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">media_player</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/filecom.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">filecommand</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/timer.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">timer_menu</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/timer.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">timer_edit</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/info.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">info_screen</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/plugin.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">plugin_selection</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/setup.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">setup_selection</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/shutdown.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">standby_restart_list</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/media.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">dmc_mainmenu</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/google.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">googlemaps</convert>
    <convert type="ConditionalShowHide" />
  </widget>
  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/dvd.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">dvd_player</convert>
    <convert type="ConditionalShowHide" />
  </widget>

 

 

 

Attached Files

•  satfinder.jpg   45.94KB   0 downloads

[littlesat]

This skin seems to have a renderer for this… seems to be custom. Having this is asking for issues when changes are done. Try a standard skin first. It looks also this renderer is also kind of wierd code as it hardcoded does check for the icon.
Sounds for the sat finder not the correct screen is shown.

Edited by littlesat, 28 May 2024 - 07:05.

[DimitarCC]

I can confirm the issue with SatFinder. The signal indicators are missing indeed on every skin. I have just tested on sf8008m.

[littlesat]

And I only see one small change in this plugin, and that little change does not look like it is causing it.

[DimitarCC]

I dont know it might be a setting that is missing...

[Sharp987]

I think the problem is not in the plugin, because I tried with an old plugin and the problem remains.

[DimitarCC]

The problem is because of the latest changes it requires specifying skin name for satfinder explicitly.

 

in python\Plugins\SystemPlugins\Satfinder\plugin.py put that on line 48 and it works.

self.skinName = ["Satfinder"]

Edited by DimitarCC, 28 May 2024 - 14:42.

[Sharp987]

Yes, that's how the plugin works now.

[littlesat]

Sounds we get a fix.... sounds the screen name got 'lost'....

Can you post a merge request....?

 

Sounds the issue with the menu icon renderer seems the stuff is not backwards compatible with this skin renderer.... as there is an easier method... Such changes should be done with care. We need to get compatibility back or 'decide' the skin and/or renderer needs to be adapted.

Edited by littlesat, 28 May 2024 - 15:34.

[Sharp987]

Thanks DimitarCC

For example:

About icons in menus it used to be

 

  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/info.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">info_screen</convert>
    <convert type="ConditionalShowHide" />
  </widget>

 

It is now

 

  <widget source="menu" render="Pixmap" pixmap="GradientFHD/menu/info.png" position="648,861" size="220,138" zPosition="3" transparent="1" alphatest="blend">
    <convert type="MenuEntryCompare">information</convert>
    <convert type="ConditionalShowHide" />
  </widget>

[DimitarCC]

Sounds we get a fix.... sounds the screen name got 'lost'....

Can you post a merge request....?

 

Sounds the issue with the menu icon renderer seems the stuff is not backwards compatible with this skin renderer.... as there is an easier method... Such changes should be done with care. We need to get compatibility back or 'decide' the skin and/or renderer needs to be adapted.

 

The pull is here https://github.com/O...igma2/pull/4000

 

Regarding the icons the problem is the IDs got changed... There is no way to fix the convertor/renderer without to hardcode old IDs and what is the new ID relation.

The only option is to be returned to the old ID names, but the new one are better imho....

[Huevos]

Regarding the icon id's I thought we already fixed that a few weeks ago.

[DimitarCC]

Yes that is fixed already.