16 replies to this topic

[dany]

Hello everybody

I assigned the power button to the power menu using hotkey
It was working well, but a week ago i had a problem that has not been resolved yet, even though i update the image daily.
I was busy adapting some skins for openpli image and i noticed that when i click on the channel list or on the menu and then press the power button, a crash occurs... I thought that the skins that I was adapting were the reason, thats why i reflashed the image without  using the Backup Restore, and the problem still exists.

I don't face this problem with openpli 9.0 ... only with openpli-develop .. you can take a look to the crash log

some thing else >>> Skin Selection disappeared from the hotkey list for a long time. i always add it without any problems
hotkey.functions.append((_("Skin Selection"), "Module/Screens.SkinSelector/SkinSelector", "Setup"))

 

regards

Attached Files

•  enigma2_crash_1718182314.log   1.7KB   2 downloads

[WanWizard]

The relevant bit from the log:

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
  File "/usr/lib/enigma2/python/StartEnigma.py", line 369, in powerup
    self.doAction(config.misc.hotkey.power.value)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 394, in doAction
    menu_screen = self.session.openWithCallback(self.MenuClosed, MainMenu, x)
AttributeError: 'PowerKey' object has no attribute 'MenuClosed'
[ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap object at 0xb2e34988>>,('GlobalActions', 'power_up')) failed)

 

[dany]

 

The relevant bit from the log:

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
  File "/usr/lib/enigma2/python/StartEnigma.py", line 369, in powerup
    self.doAction(config.misc.hotkey.power.value)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 394, in doAction
    menu_screen = self.session.openWithCallback(self.MenuClosed, MainMenu, x)
AttributeError: 'PowerKey' object has no attribute 'MenuClosed'
[ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap object at 0xb2e34988>>,('GlobalActions', 'power_up')) failed)

is it possible to fix it next update ?
 

[littlesat]

As far I know the SkinSelector was never added to Hotkey (via the UI... of course in the past you could manipulate the settings file by yourself)... It is also not clear what you tried to add to the power button... i tried to assigned different stuff to it... but I could not verify that issue. What did you change about the power key?

Edited by littlesat, 12 June 2024 - 15:55.

[dany]

As far I know the SkinSelector was never added to Hotkey.... It is also not clear what you tried to add to the power button...

for sure - for 100% ... skinselection was added to hotkey

 

I assigned the power button to the powermenu .. now when i press on the channel list  and then press on the power button, a crash occurs

[littlesat]

for sure - for 100% ... skinselection was added to hotkey -> I searched in our sources and as far I can see it was never available.

 

I can indeed confirm you get the GSOD when you press power in the channel selector. This is an obvious 'thing' actually as we activated this option in the channel selection... disabled it again but we did not remember why... so it get re-enabled..... needs research...

Edited by littlesat, 12 June 2024 - 16:04.

[littlesat]

Solution for the GSOD will be committed soon...

[dany]

maybe it was called before ( skin setup or skinselektor or something else )  >>> but that's strange .. because i started adding it to the hotkey manually after it disappeared from the list

anyway is it possible to add it to the hotkey list ? it's very useful

Edited by dany, 12 June 2024 - 16:13.

[littlesat]

FYI 

https://github.com/O...da459674e8d3346

https://github.com/O...daa880054be0b78

Edited by littlesat, 12 June 2024 - 16:21.

[dany]

littlesat  ... thank you so much fo adding skin selection to the hotkey list  .. will be added to the pli 9.0 and 8.3 ?

i tried your fix but the problem still exists

 

StartEnigma.py .. before added your lines:

for x in root.findall("menu"):
     if x.get("key") == "shutdown":
      self.session.infobar = self
      menu_screen = self.session.openWithCallback(self.MenuClosed, MainMenu, x)
      menu_screen.setTitle(_("Standby / restart"))
      break

 

 

StartEnigma.py .. after added your lines :

for x in root.findall("menu"):
     if x.get("key") == "shutdown":
      self.session.infobar = self
      menu_screen = self.session.openWithCallback(self.MenuClosed, MainMenu, x)
      menu_screen = self.session.open(MainMenu, x)
      menu_screen.setTitle(_("Standby / restart"))
      break

Edited by dany, 12 June 2024 - 16:48.

[littlesat]

There is a second change that changes this line

 

- menu_screen = self.session.openWithCallback(self.MenuClosed, MainMenu, x)+ 

+ menu_screen = self.session.open(MainMenu, x)

 

It looks you left the line with the WithCallback... you need to remove it....

 

There might be more functions that could be added to hotkey.... it was forked and other images made a lot of adaptions to this code I originally made... Even the source code name was changed.... and at that time nothing merged back.... So it could be in compared with other images we do not have all the functions available.
 

Edited by littlesat, 12 June 2024 - 16:55.

[littlesat]

Thanks for reporting this GSOD... this was a 'bug' in there for a longer time....

[dany]

you are right ... now fixed after removed this line ( menu_screen = self.session.openWithCallback(self.MenuClosed, MainMenu, x)

really a great code ... very usefull and easy to use

 

openpli image will be always the best for me and for most users

anyway .. im busy with adapting these skins : all of them are FHD

- Metrixhd

- ExtremeGoldenFHD

- Nacht

- NexGenGradient-FHD

- Novaler-indianred

- YouViX ( red-blue-green)

 

Soon they will all be ready for use

When its work is finished, i can contact you if you want to use it instead of the old skins in the feed that no one uses

i adappted them from A to Z

regards

[littlesat]

Note that over the last months a lot of skin features were added for the E2OS skin.... Please try to keep out python rendering code out of skins....

[dany]

Perhaps i did not understand exactly what you mean, but all the skins that i adapted have their own converters-renderes , and they all work together without problems, and if you delete any skin from the image, the other skins will not be affected.
Of course  i used some of converters-renderes that they are not exist  in the openpli image 
in general, these things can be discussed after the skins are presented

 

regards

[littlesat]

It works maybe…. But this is how it should not be done…. Aka have two skins adapting different code under the same name or make a unique file name and have duplicates. This was always a mess with skins…

[dany]

I agree with you, but i think you can try it and then judge it
You and many of the developers here have great experience in this field and can discuss everything smoothly