2135 replies to this topic

[Pr2]

Hi,

 

I just perform a test and PoEdit has an option to delete all the obsolete strings.

 

I use wc to compare files.

 

With the obsolete strings:    8939   32914  234941 fr.po

With the clean-up            :   8687   31736  227380 fr.po

 

And please find attached the cleaned up version, please commit.

Add missing strings + typo correction (ACC -> AAC).

 

I also include the latest enigma2.pot file for people that use this method to update there own .po file.

 

Pr2

Attached Files

•  OpenPLi-2015-08-20-fr.po.zip   86.05KB   6 downloads

[mirakels]

@Pr2: your fr.po pushed

 

Removed all obsolete traslations and push upstream

So we should now have a clean language environment... Hope all is well

[blzr]

thanks @mirakels,

everything seems ok now...

and regarding the fuzzy strings - I agree that the 'real' obsolete strings needed to be removed, but, I hope that 'fuzzy matching' feature would be still used on translations re-generation
I find it really handy, because:
a. it really saves some work (eg when just case sensitive changed, or the dot was added on the end, etc)
b. since all (most of?) the new messages after po update were marked fuzzy, it allowed me to distinguish easily between old untranslated strings (which usually I want to remain  such) and the newly added that I need to review/translate

Edited by blzr, 21 August 2015 - 09:54.

[mirakels]

yes fuzzy will stay!

maybe it os good to keep oboslet again for a while and once in a while get rid ot them again...

[Pr2]

Hi,

 

Thanks, it is a good idea to perform, for exemple every 3 months, a clean up of obsolete strings.

 

But now can you also have a look at Taapat report:

 

http://forums.openpl...-47#entry501718

 

I hope that if the process to update the .po file is easy we can get more people that help us translate OpenPLi in different languages.

 

Pr2

Edited by Pr2, 21 August 2015 - 11:02.

[Taapat]

Restore deleted in Latvian translation: https://github.com/O...enigma2/pull/29

[Tech]

Pushed

[mirakels]

And if we are talking about automatic translation, I would like to draw attention that in the enigma is some things that will not be parsed automatically.
In this commit is introduced the words "Question" and "Warning": https://github.com/O...857b182c47af43a
In this commit "Select location": https://github.com/O...d0aee9c75e509bf
For myself I have solved this with adding in the enigma root file translate.py which contains these words: https://bitbucket.or...te.py?at=master
Then they is in my pot file when automatically parsing.
I do not know what is better, do as I, or prevent problems with translation in these screens.

 

Can't the first one be solve by replacing

 

          self.title = self.type < self.TYPE_MESSAGE and ["Question", "Information", "Warning", "Error"][self.type] or "Message"

 

with

 

          self.title = self.type < self.TYPE_MESSAGE and [_("Question"), _("Information"), _("Warning"), _("Error")[self.type] or _("Message")

?

 

The 2nd issue, with the gettext in   "def __init__()" is more difficult.   No real answer to that...

[Taapat]

The 2nd issue, of course we need to discuss...
What is wrong if we add the file to parse only translation, if we can not find a better solution?

We already use addition files for the make, why we can not add them for parse?

[Pr2]

Hi,

 

Using a dedicated file is just a work around that can become really hard to maintain in the future.

Would be better if we can find another way to implement the 2nd issue that match the normal get strings process.

 

Pr2

[Taapat]

I agree that it may be hard to maintain this in the future.
I think that needs revert this commit.
Maybe this translation is necessary in some plugins, in enigma I can not find where windowTitle be set without translated text: https://github.com/O...✓&q=windowTitle
Now gettext is used unnecessarily twice.

Edited by Taapat, 22 August 2015 - 12:28.

[Taapat]

Unfortunately if revert this commit translation is no longer working.
Perhaps the need to understand why is necessary to use gettext directly in self.onShown.append(boundFunction(self.setTitle, _(windowTitle)))?
Maybe it can be corrected, and we can use already translated text in this function without _(windowTitle).
If we leave it as is now, there is no necessary to use gettext in all places where set windowTitle, but it's even worse situation with the translation parsing.

[Taapat]

It seems I have found the reason why the default title translation is not working in in InputBox and LocationBox.
We can not use the gettext in function parameters.
What do you think about such fix: https://github.com/T...2e8834aa4190d29
if it is acceptable, then I will set up a pull request.

[janda]

Updated slovak translation

Attached Files

•  sk.zip   49.31KB   8 downloads

[Pr2]

Hi,

 

French translation: add new strings.

 

Pr2

Attached Files

•  OpenPLi-2015-08-23-fr.po.zip   86.07KB   5 downloads

[Tech]

Hi,

 

French translation: add new strings.

 

Pr2

Pushed the french translations.

 

Unfortunately it is not possible to download the slovak translation from Janda, maybe the file is corrupt.

@Janda, is it possible for you to upload the file again please?

[Pr2]

Hi Tech,

 

Thanks for the update (fr).

 

I just try to download the sk.zip and I have got no problem here.

Anyway I upload it again for you.

 

ori-sk.zip is the original .zip of janda and new-sk.po.zip is the one I zip myself.

 

Pr2

Attached Files

•  ori-sk.zip   49.31KB   1 downloads
•  new-sk.po.zip   49.97KB   1 downloads

[Tech]

Hi Tech,

 

I just try to download the sk.zip and I have got no problem here.

Anyway I upload it again for you.

Pr2

Thanks for downloading the file, but in the meanwhile the system-administrator sollved the issue with this file

 

I also pushed the updated slovak translation.

[Taapat]

No one has given his opinion about corrections that I propose, therefore I create a pull request: https://github.com/O...enigma2/pull/30
You can decide to accept it or reject.

[blzr]

Patch including latest Polish translations update attached.

Also some cleanup - all empty comments removed from the pl.po file.

Attached Files

•  0001-pl.po-translations-update-and-some-cleanup.patch   173.96KB   2 downloads