1748 replies to this topic

[littlesat]

Please revert the revert when we agree we're going for spaces....

[WanWizard]

I would like to see the feedback of the rest...

[littlesat]

Yep indeed... then decide and then commit (and sorry that I was sooooo faaaaaast it will become an revert revert)...

And when we have no further comments we choose for spaces... 

Edited by littlesat, 29 April 2020 - 16:03.

[SpaceRat]

Personally, I prefer Tabs.

Spaces simply don't make ANY sense.

 

Tabs are much easier to handle, because in Python it's a big difference if you have 7 or 8 spaces after a line with 8 or 7 spaces, while counting the silly spaces is a major PITA in nowadays editors due to non-fixed width fonts.

And you do not always have editors at hand that do auto-indenting for you.

 

Tabs are everything: Lean, clean, easy to read.

 

And they are much more comfortable when writing code due to the silly "indentation also replaces { }" policy in Python: I would rather like to delete or add ONE tab rather than having to add/delete 4 spaces (yikes).

 

The devs of E2 decided against spaces for a reason ...

[Dimitrij]

And they are much more comfortable when writing code due to the silly "indentation also replaces { }" policy in Python: I would rather like to delete or add ONE tab rather than having to add/delete 4 spaces (yikes).

 

 

+100
 

[Persian Prince]

The entire world is moving to spaces. I don't like it, but a standard is a standard, it isn't about anyone's personal taste.

 

The space (as in disk space ) argument is void too. A PC can deal with a few extra bytes, the repo is compressed, and on the box is no source.

 

Most if not all editors can be told what the intentation character is, so that is not an issue as well. The only thing that needs ajusting is the mindset.

That's the point, we should follow the standards not prefer something we like.

 

We could have our own extension like .pye2 and patch compilers for it but it's not standard.

 

In OV we're moving towards python 3 and we change things regarding that like https://github.com/O...3a281393cb3c5d4 (python 3 prints) and python 3 exception handling.

 

Following standards is inevitable.

[littlesat]

But it is space or tab.... only mix is not allowed....

[SpaceRat]

 

Following standards is inevitable.

 

 

Tabs are the de facto standard in E2 code.

 

There is almost no active developer left, why NOW waste the time to touch 90% of all code just to change indent?

 

There are myriads of bugs and quirks in E2, why not FINALLY fix at least SOME of them instead?

[Persian Prince]

But it is space or tab.... only mix is not allowed....

https://www.python.o...#tabs-or-spaces

[Persian Prince]

 

 

Following standards is inevitable.

 

 

Tabs are the de facto standard in E2 code.

 

There is almost no active developer left, why NOW waste the time to touch 90% of all code just to change indent?

 

There are myriads of bugs and quirks in E2, why not FINALLY fix at least SOME of them instead?

 

enigma2 won't tell us the python standards but PEP8 does.

 

I'm happy to send PR regarding this for all enigma2 repos and teams, so my time will be wasted.

Edited by Persian Prince, 29 April 2020 - 16:36.

[ims]

and ?

 

Tabs should be used solely to remain consistent with code that is already indented with tabs.

 

  ... then do not change existing code !

[Persian Prince]

and ?
 

Tabs should be used solely to remain consistent with code that is already indented with tabs.

  ... then do not change existing code !

What about:

Python 2 code indented with a mixture of tabs and spaces should be converted to using spaces exclusively.

[WanWizard]

Either convert it all to tabs, or to spaces. Leaving it as-is is not an option according to PEP8.

 

As said, I personally don't care, my editor handles both types and autodetects the standard used in the file, and I work on other projects that have this discussion at least once a year...

 

As for a font, proportional fonts for code should be avoided at all costs. I can highly recommend https://www.jetbrains.com/lp/mono/, it's the best one I've used in years.

[SpaceRat]

As most of the code now is cleanly formatted using tabs, a conversion to tabs for the remaining lines is less effort.

 

And so far, nobody has presented any reason in favor of spaces, except "it's a standard".

If jumping off a bridge becomes a standard, will you jump?

[betacentauri]

Mixing (one file spaces, other tabs) I don't really prefer. Maybe only if we want to move slowly to spaces. (Mixing in one file is bad and shouldn't be done).

 

I really prefer tabs. I don't understand why spaces are the standard. Doesn't make sense for me. For me as long as tabs are allowed we should use them.

[littlesat]

Now most is tabs and the rule was what was used more before... my gut feeling says tabs.
This is a typical topic that should be discussed along devs/teams before pushed/merge requested...

Edited by littlesat, 29 April 2020 - 17:36.

[athoik]

I would like to see the feedback of the rest...

Keep tabs for now.

[WanWizard]

You mean change spaces to tabs? Because that is the question: either all spaces, or all tabs.

[SpaceRat]

All tabs

[WanWizard]

Fine by me.