Jump to content


Photo

merge requests for PLi's git


  • Please log in to reply
1456 replies to this topic

Re: merge requests for PLi's git #1441 WanWizard

  • Forum Moderator
    PLi® Core member
  • 54,906 posts

+1,093
Excellent

Posted 30 April 2020 - 17:20

Yes I understand the "alignment" issue, but is insignificant compared to the other arguments (I think you agree)

 

As I said, it's a rather weak argument. Besides that, 99% has their tabstop at 4, which completely negates the argument imho.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Many answers to your question can be found in our new and improved wiki.

note: I do not provide support via PM !

 


Re: merge requests for PLi's git #1442 littlesat

  • PLi® Core member
  • 52,153 posts

+591
Excellent

Posted 30 April 2020 - 19:56

As far I know in python 3 the mix of tabs and spaces is not allowed anymore... so the obvious issue is already solved in python years ago... but somehow we are stuck on python 2.7 (while betacentauri did already made a python 3 branch which almost works more than a year ago).... there is so many things on ‘hold’.... (change to python 3 will break 3rd party plugins and more plugins)

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1443 Abu Baniaz

  • PLi® Contributor
  • 1,685 posts

+39
Good

Posted 30 April 2020 - 19:57

Looks like we have a decision for Enigma2.

Tabs only.
Where we have a mix of spaces and tabs, convert space to tabs.

Agreed?

Sent from my Moto G (5S) using Forum Fiend v1.3.3.

Re: merge requests for PLi's git #1444 littlesat

  • PLi® Core member
  • 52,153 posts

+591
Excellent

Posted 30 April 2020 - 19:59

I think we go indeed to that direction.... but before pp pushes spaces to vix/openatv it is also smart to involve him.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1445 Dimitrij

  • PLi® Core member
  • 7,182 posts

+235
Excellent

Posted 30 April 2020 - 20:01

Why is this a dispute?
Let's close this topic about tabs.

class CIHelper:

	CI_ASSIGNMENT_LIST = None

CI_ASSIGNMENT_LIST(space)=(space)None

Nonsens...
 


Edited by Dimitrij, 30 April 2020 - 20:04.

Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: merge requests for PLi's git #1446 littlesat

  • PLi® Core member
  • 52,153 posts

+591
Excellent

Posted 30 April 2020 - 20:09

That is pep.. this is to make it more readable... eg in cpp you should do the same.
This is also done in overal in e2.... so we should not change that.

Edited by littlesat, 30 April 2020 - 20:10.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1447 WanWizard

  • Forum Moderator
    PLi® Core member
  • 54,906 posts

+1,093
Excellent

Posted 30 April 2020 - 21:56

Agreed.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Many answers to your question can be found in our new and improved wiki.

note: I do not provide support via PM !

 


Re: merge requests for PLi's git #1448 Erik Slagter

  • PLi® Core member
  • 46,165 posts

+513
Excellent

Posted 1 May 2020 - 10:43

Looks like we have a decision for Enigma2.

Tabs only.
Where we have a mix of spaces and tabs, convert space to tabs.

Agreed?

We have been doing this for ages already.


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: merge requests for PLi's git #1449 Erik Slagter

  • PLi® Core member
  • 46,165 posts

+513
Excellent

Posted 1 May 2020 - 10:45

Why is this a dispute?
Let's close this topic about tabs.

class CIHelper:

	CI_ASSIGNMENT_LIST = None

CI_ASSIGNMENT_LIST(space)=(space)None

Nonsens...

 

It's considered good practice in every language to insert spaces before and after symbols. Indeed for readability. In some languages it can even mean the difference between correct and incorrect interpretation by the interpreter or compiler in some situations.


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: merge requests for PLi's git #1450 Persian Prince

  • Senior Member
  • 1,777 posts

+238
Excellent

Posted 30 July 2020 - 10:45

https://github.com/O...e-core/pull/846

 

(BackupSuite: Use master branch for PLi)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1451 WanWizard

  • Forum Moderator
    PLi® Core member
  • 54,906 posts

+1,093
Excellent

Posted 30 July 2020 - 11:02

Thanks. We need to sort out this branding discussion asap so you don't have to do things like this.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Many answers to your question can be found in our new and improved wiki.

note: I do not provide support via PM !

 


Re: merge requests for PLi's git #1452 Persian Prince

  • Senior Member
  • 1,777 posts

+238
Excellent

Posted 30 July 2020 - 11:09

Thanks. We need to sort out this branding discussion asap so you don't have to do things like this.

Yes I had to create another branch to keep the plugin compatible with PLi :(

 

The new generation of Backup Suite doesn't have any lookuptable.txt or findkerneldevice as it's smarter.

 

If any of PLi team wanted to manage the master branch let me know to give you the write access.

 

You could check https://github.com/O...branding-module which is more compatible with PLi and how we're using it almost everywhere to reduce the checks.

 

Recipe: https://github.com/O...ion-branding.bb

 

P.S. you need so many variables but I could give you the needed PRs for all BSPs and your OE if you're up for it.


Edited by Persian Prince, 30 July 2020 - 11:11.

If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1453 A.A.

  • Senior Member
  • 110 posts

+1
Neutral

Posted 30 July 2020 - 11:31

Hi guys,

 

coming from 'true' OpenEmbedded I am now used to follow the discussed and agreed practices: https://www.openembe...wiki/Styleguide

So please at least for the metadata do follow this guide.

 

Ah, another ugly thing I see in *all* the OE-derivates is the lack of comments in the commits.

Here the guide:  https://www.openembe...sage_Guidelines

 

I have also done some kernel work in the past and there indeed the bar is set very high!

In kernel however you use C and not a faulty languages like python with its ridicolous indenting risks:)

 

My 2 cents

A.A.



Re: merge requests for PLi's git #1454 Persian Prince

  • Senior Member
  • 1,777 posts

+238
Excellent

Posted 3 August 2020 - 08:45

https://github.com/O...igma2/pull/2691

 

(Rework summary screen titles by IanSav)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1455 Persian Prince

  • Senior Member
  • 1,777 posts

+238
Excellent

Posted 17 August 2020 - 21:40

https://github.com/O...io-grab/pull/18

 

(aio-grab: Support Zgemma h0 and h8)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1456 Rob van der Does

  • Senior Member
  • 7,732 posts

+184
Excellent

Posted 29 August 2020 - 10:36

https://github.com/l...-PLiHD/pull/870



Re: merge requests for PLi's git #1457 littlesat

  • PLi® Core member
  • 52,153 posts

+591
Excellent

Posted 29 August 2020 - 12:46

Merged


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W





0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users