Jump to content


Photo

merge requests for PLi's git


  • Please log in to reply
1748 replies to this topic

Re: merge requests for PLi's git #1401 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 April 2020 - 15:18

Please revert the revert when we agree we're going for spaces....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1402 WanWizard

  • PLi® Core member
  • 68,306 posts

+1,719
Excellent

Posted 29 April 2020 - 15:21

I would like to see the feedback of the rest...


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: merge requests for PLi's git #1403 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 April 2020 - 16:02

Yep indeed... then decide and then commit (and sorry that I was sooooo faaaaaast it will become an revert revert)...

And when we have no further comments we choose for spaces... 


Edited by littlesat, 29 April 2020 - 16:03.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1404 SpaceRat

  • Senior Member
  • 1,030 posts

+65
Good

Posted 29 April 2020 - 16:06

Personally, I prefer Tabs.

Spaces simply don't make ANY sense.

 

Tabs are much easier to handle, because in Python it's a big difference if you have 7 or 8 spaces after a line with 8 or 7 spaces, while counting the silly spaces is a major PITA in nowadays editors due to non-fixed width fonts.

And you do not always have editors at hand that do auto-indenting for you.

 

Tabs are everything: Lean, clean, easy to read.

 

And they are much more comfortable when writing code due to the silly "indentation also replaces { }" policy in Python: I would rather like to delete or add ONE tab rather than having to add/delete 4 spaces (yikes).

 

The devs of E2 decided against spaces for a reason ...


1st box: Vu+ Ultimo 4k 4xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
2nd box: Gigablue Quad 4k 2xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
testing boxes: Vu+ Duo² + AX Quadbox HD2400 + 2x Vu+ Solo² + Octagon SF4008
Sats & Pay-TV: Astra 19.2°E + Hotbird 13°E with Redlight / SCT HD / SES Astra HD- / Sky V14 / 4th empire propaganda TV
Card-Server: Raspberry Pi + IPv6-capable oscam
Router: Linksys WRT1900ACS w/ LEDE + Fritz!Box 7390

Re: merge requests for PLi's git #1405 Dimitrij

  • PLi® Core member
  • 9,964 posts

+334
Excellent

Posted 29 April 2020 - 16:10


And they are much more comfortable when writing code due to the silly "indentation also replaces { }" policy in Python: I would rather like to delete or add ONE tab rather than having to add/delete 4 spaces (yikes).

 

 

+100
 


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: merge requests for PLi's git #1406 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 29 April 2020 - 16:17

The entire world is moving to spaces. I don't like it, but a standard is a standard, it isn't about anyone's personal taste.

 

The space (as in disk space :)) argument is void too. A PC can deal with a few extra bytes, the repo is compressed, and on the box is no source.

 

Most if not all editors can be told what the intentation character is, so that is not an issue as well. The only thing that needs ajusting is the mindset. ;)

That's the point, we should follow the standards not prefer something we like.

 

We could have our own extension like .pye2 and patch compilers for it but it's not standard.

 

In OV we're moving towards python 3 and we change things regarding that like https://github.com/O...3a281393cb3c5d4 (python 3 prints) and python 3 exception handling.

 

Following standards is inevitable.


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1407 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 April 2020 - 16:23

But it is space or tab.... only mix is not allowed....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1408 SpaceRat

  • Senior Member
  • 1,030 posts

+65
Good

Posted 29 April 2020 - 16:26

 

Following standards is inevitable.

 

 

Tabs are the de facto standard in E2 code.

 

There is almost no active developer left, why NOW waste the time to touch 90% of all code just to change indent?

 

There are myriads of bugs and quirks in E2, why not FINALLY fix at least SOME of them instead?


1st box: Vu+ Ultimo 4k 4xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
2nd box: Gigablue Quad 4k 2xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
testing boxes: Vu+ Duo² + AX Quadbox HD2400 + 2x Vu+ Solo² + Octagon SF4008
Sats & Pay-TV: Astra 19.2°E + Hotbird 13°E with Redlight / SCT HD / SES Astra HD- / Sky V14 / 4th empire propaganda TV
Card-Server: Raspberry Pi + IPv6-capable oscam
Router: Linksys WRT1900ACS w/ LEDE + Fritz!Box 7390

Re: merge requests for PLi's git #1409 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 29 April 2020 - 16:34

But it is space or tab.... only mix is not allowed....

https://www.python.o...#tabs-or-spaces :)


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1410 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 29 April 2020 - 16:35

 

 

Following standards is inevitable.

 

 

Tabs are the de facto standard in E2 code.

 

There is almost no active developer left, why NOW waste the time to touch 90% of all code just to change indent?

 

There are myriads of bugs and quirks in E2, why not FINALLY fix at least SOME of them instead?

 

enigma2 won't tell us the python standards but PEP8 does.

 

I'm happy to send PR regarding this for all enigma2 repos and teams, so my time will be wasted.


Edited by Persian Prince, 29 April 2020 - 16:36.

Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1411 ims

  • PLi® Core member
  • 13,605 posts

+210
Excellent

Posted 29 April 2020 - 16:38

and ?

 

Tabs should be used solely to remain consistent with code that is already indented with tabs.

 

  ... then do not change existing code !


Kdo nic nedělá, nic nezkazí!

Re: merge requests for PLi's git #1412 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 29 April 2020 - 16:41

and ?
 

Tabs should be used solely to remain consistent with code that is already indented with tabs.

  ... then do not change existing code !

What about:

Python 2 code indented with a mixture of tabs and spaces should be converted to using spaces exclusively.


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1413 WanWizard

  • PLi® Core member
  • 68,306 posts

+1,719
Excellent

Posted 29 April 2020 - 16:55

Either convert it all to tabs, or to spaces. Leaving it as-is is not an option according to PEP8.

 

As said, I personally don't care, my editor handles both types and autodetects the standard used in the file, and I work on other projects that have this discussion at least once a year... ;)

 

As for a font, proportional fonts for code should be avoided at all costs. I can highly recommend https://www.jetbrains.com/lp/mono/, it's the best one I've used in years.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: merge requests for PLi's git #1414 SpaceRat

  • Senior Member
  • 1,030 posts

+65
Good

Posted 29 April 2020 - 17:01

As most of the code now is cleanly formatted using tabs, a conversion to tabs for the remaining lines is less effort.

 

And so far, nobody has presented any reason in favor of spaces, except "it's a standard".

If jumping off a bridge becomes a standard, will you jump?


1st box: Vu+ Ultimo 4k 4xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
2nd box: Gigablue Quad 4k 2xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
testing boxes: Vu+ Duo² + AX Quadbox HD2400 + 2x Vu+ Solo² + Octagon SF4008
Sats & Pay-TV: Astra 19.2°E + Hotbird 13°E with Redlight / SCT HD / SES Astra HD- / Sky V14 / 4th empire propaganda TV
Card-Server: Raspberry Pi + IPv6-capable oscam
Router: Linksys WRT1900ACS w/ LEDE + Fritz!Box 7390

Re: merge requests for PLi's git #1415 betacentauri

  • PLi® Core member
  • 7,185 posts

+323
Excellent

Posted 29 April 2020 - 17:28

Mixing (one file spaces, other tabs) I don't really prefer. Maybe only if we want to move slowly to spaces. (Mixing in one file is bad and shouldn't be done).

 

I really prefer tabs. I don't understand why spaces are the standard. Doesn't make sense for me. For me as long as tabs are allowed we should use them.


Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: merge requests for PLi's git #1416 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 April 2020 - 17:33

Now most is tabs and the rule was what was used more before... my gut feeling says tabs.
This is a typical topic that should be discussed along devs/teams before pushed/merge requested...

Edited by littlesat, 29 April 2020 - 17:36.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1417 athoik

  • PLi® Core member
  • 8,458 posts

+327
Excellent

Posted 29 April 2020 - 18:23

I would like to see the feedback of the rest...

Keep tabs for now.


Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: merge requests for PLi's git #1418 WanWizard

  • PLi® Core member
  • 68,306 posts

+1,719
Excellent

Posted 29 April 2020 - 18:59

You mean change spaces to tabs? Because that is the question: either all spaces, or all tabs.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: merge requests for PLi's git #1419 SpaceRat

  • Senior Member
  • 1,030 posts

+65
Good

Posted 29 April 2020 - 19:05

All tabs :)


1st box: Vu+ Ultimo 4k 4xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
2nd box: Gigablue Quad 4k 2xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
testing boxes: Vu+ Duo² + AX Quadbox HD2400 + 2x Vu+ Solo² + Octagon SF4008
Sats & Pay-TV: Astra 19.2°E + Hotbird 13°E with Redlight / SCT HD / SES Astra HD- / Sky V14 / 4th empire propaganda TV
Card-Server: Raspberry Pi + IPv6-capable oscam
Router: Linksys WRT1900ACS w/ LEDE + Fritz!Box 7390

Re: merge requests for PLi's git #1420 WanWizard

  • PLi® Core member
  • 68,306 posts

+1,719
Excellent

Posted 29 April 2020 - 19:08

Fine by me. ;)


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.



1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users