1748 replies to this topic

[christophecvr]

Here already the patch for dm8000 only. Just did build from scratch with this patch applied reflashed box and all ok, wma (up to version 8) does play fine via standard player (pvr button)

 

 

Attached Files

•  gst-ffmpeg-dm8000-only.patch   858bytes   7 downloads

[christophecvr]

Also extra tests a couple off sounds in row (wma) all ok. Play rate 100 % ok.

[athoik]

Eg,

dreambox-dvb-modules: update dm500hd drivers to 20121207

- enabled wma and wmv support
- fixed a small vtuner bug

[christophecvr]

Indeed . But that's not done for dm8000.  But does it work with standard pli4 player (pvr button) ? Be shure gst-ffmpeg is not installed

[christophecvr]

The ac3+ stream selections where not cached . With this enigma2 patch it does cache the ac3+ stream selcetion as well.

 

 

Attached Files

•  ac3plusCacheEnigma2git.patch   7.76KB   12 downloads

Edited by christophecvr, 26 February 2014 - 17:32.

[Rob van der Does]

The ac3+ stream selections where not cached . With this enigma2 patch it does cache the ac3+ stream selcetion as well.

So that's the solution for http://openpli.org/f...ndpost&p=408348 ?

[christophecvr]

The ac3+ stream selections where not cached . With this enigma2 patch it does cache the ac3+ stream selcetion as well.

So that's the solution for http://openpli.org/f...ndpost&p=408348 ?

 

Yes , but it is only for the caching of the audiostream ac3+ when you selected it by a channel . It does not add ac3+ support itself. This means that for the dreambox dm800se and dm8000 you still will have to apply the Dd+ patch on :

http://openpli.org/f...30392-dd/page-8

 

For the boxes in pli4 where ac3+ is supported like the vuduo2 and ... it works

Edited by christophecvr, 26 February 2014 - 17:51.

[christophecvr]

extra note: if you configured in the automatic language selction the option ac3, it off course always will default to ac3. This has to be set to no otherwise it will ignore the cache.

[Rob van der Does]

OK, so it fixes E2 forgetting AC3+ was previously chosen.

[christophecvr]

OK, so it fixes E2 forgetting AC3+ was previously chosen.

Indeed

[betacentauri]

The ac3+ stream selections where not cached . With this enigma2 patch it does cache the ac3+ stream selcetion as well.

 	enum cacheID
 	{
-		cVPID, cMPEGAPID, cTPID, cPCRPID, cAC3PID,
+		cVPID, cMPEGAPID, cTPID, cPCRPID, cAC3PID,cDDPPID,
 		cVTYPE, cACHANNEL, cAC3DELAY, cPCMDELAY,
 		cSUBTITLE, cAACHEAPID=12, cacheMax
 	};

It's an enum. By adding cDDPPID in the middle of the enum all following values are changed. This will make problems with current tools and also current lamedb values are read in a wrong way. E.g. vtype had value 5. After adding your patch E2 will read lamedb entry with value 5 and uses it as AC3+ pid.

So please rework the patch and add the new cDDPPID before cacheMax.

Edited by betacentauri, 26 February 2014 - 19:24.

[dhwz]

yes should be cDDPPID=13 then I think 

[christophecvr]

The ac3+ stream selections where not cached . With this enigma2 patch it does cache the ac3+ stream selcetion as well.

 	enum cacheID
 	{
-		cVPID, cMPEGAPID, cTPID, cPCRPID, cAC3PID,
+		cVPID, cMPEGAPID, cTPID, cPCRPID, cAC3PID,cDDPPID,
 		cVTYPE, cACHANNEL, cAC3DELAY, cPCMDELAY,
 		cSUBTITLE, cAACHEAPID=12, cacheMax
 	};

It's an enum. By adding cDDPPID in the middle of the enum all following values are changed. This will make problems with current tools and also current lamedb values are read in a wrong way. E.g. vtype had value 5. After adding your patch E2 will read lamedb entry with value 5 and uses it as AC3+ pid.

So please rework the patch and add the new cDDPPID before cacheMax.

 

 

Oh yes it worked perfect by me, since I did not had an already database. (it was a clean box)

But indeed it can mess up the already previousely (only cached values.) But since its an enumeration, The best is to put it before cachemax. (enumeration as far as I know starts with 0. Which means that 11 is still free.

Then it should be

 

	enum cacheID
 	{
-		cVPID, cMPEGAPID, cTPID, cPCRPID, cAC3PID,
+		cVPID, cMPEGAPID, cTPID, cPCRPID, cAC3PID,
 		cVTYPE, cACHANNEL, cAC3DELAY, cPCMDELAY,
 		cSUBTITLE, cDDPPID, cAACHEAPID=12, cacheMax
 	};

then cVPID = 0 cMPEGAPID=1 .... cDDPPID = 11 (which was unused).

Edited by christophecvr, 27 February 2014 - 10:02.

[littlesat]

Should we expect a final patch?.... New thinks in enum should be added behind....

Edited by littlesat, 27 February 2014 - 10:36.

[christophecvr]

Should we expect a final patch?.... New thinks in enum should be added behind....

I'm bussy with it (just back from work worked whole night)

 

but 11 is free (if I put it behind it might result in even more unexpected behaviour due to cAACHEAPID=12 . )

 

Just recompiling enigma2 with new patch and then test on my box. If ok I'll place it here

[christophecvr]

Here the final patch

 

cPPDPID now on 11 (that value was not used anyway so it will not screw up any running box settings with had already cached audio pid selections) Even the = 12 could be removed from cAACHEAPID the it's all logic again this i did not do.

 

Also changed cached_apid_ac3plus(ad from previous patch) to cached_apid_ddp  (that seamed more logic to me)

 

Tested on vuduo2 servus channel on 19.2 E

 

Selection pid ok. After zapping channel reselected with the ac3+ pid .. ok. After reboot that channel was also selceted with the ac3+ pid  ... ok.

 

 

 

 

 

 

Attached Files

•  ac3plusCacheEnigma2-2.patch   7.69KB   2 downloads

[pieterg]

I think 12 was used to avoid conflicts with other images / setting editor tools.
So 11 might not be a good idea, not sure.

[pieterg]

actually, it's 10 now. Enum numbering starts at 0.

[christophecvr]

actually, it's 10 now. Enum numbering starts at 0.

Bloddy hell You're wright its 10 now.

 

Then Yes I did not think on other images . Think then change it from

 

cSUBTITLE, cDDPPID, cAACHEAPID=12, cacheMax

to

 

cSUBTITLE, cAACHEAPID=12, cDDPPID=13, cacheMax

Is the safest solution.

[pieterg]

You can omit the 13, enum numbering continues after the 12.
But I think we have to wait for betacentauri's comments, he knows the exact reasoning behind the 12, and he can tell you whether 13 is a good idea (or perhaps we should skip even more values to avoid conflicts)