1748 replies to this topic

[peteru]

 

 

https://github.com/OpenE2

https://github.com/OpenMipsel

https://github.com/OpenEnigma2

https://github.com/OpenVuPlus

https://github.com/OpenSH4

https://github.com/OpenPrismCube

https://github.com/O...smCubeCommunity

https://github.com/OpenPLi-GitHub

https://github.com/OpenBlackHole

https://github.com/OpenPLi-GitHub

https://github.com/OpenAZBox

 

for easy read/download/fork ...

 

 

More :

 

https://github.com/OpenHyperCube

https://github.com/OpenTechnomate

https://github.com/OpenDMM

 

 

If you are mirroring all the forks, you may want to add this one: https://bitbucket.or...nwiz/easy-ui-4/

[Persian Prince]

 

 

 

https://github.com/OpenE2

https://github.com/OpenMipsel

https://github.com/OpenEnigma2

https://github.com/OpenVuPlus

https://github.com/OpenSH4

https://github.com/OpenPrismCube

https://github.com/O...smCubeCommunity

https://github.com/OpenPLi-GitHub

https://github.com/OpenBlackHole

https://github.com/OpenPLi-GitHub

https://github.com/OpenAZBox

 

for easy read/download/fork ...

 

 

More :

 

https://github.com/OpenHyperCube

https://github.com/OpenTechnomate

https://github.com/OpenDMM

 

 

If you are mirroring all the forks, you may want to add this one: https://bitbucket.or...nwiz/easy-ui-4/

 

 

Hmm I did add it for test : https://github.com/O...ipsel/easy-ui-4 but what's special about it ?

[peteru]

It's pretty much the only e2 fork that works properly within the Australian DVB-T free to air environment. Numerous fixes and additions too.

[mx3L]

Hi,

 

I can see that in List source getCurrent routine returns False instead of None in case master element is None, since:

>>> None is not None and ()
False

Proposed patch:

From 4a204b4dab83271ec50c2fa76837b57d50f77841 Mon Sep 17 00:00:00 2001
From: mx3L <mx3ldev@gmail.com>
Date: Wed, 8 Jul 2015 13:12:58 +0200
Subject: [PATCH] Return None instead of False on getCurrent in case master is
 not set in List Source

---
 lib/python/Components/Sources/List.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/python/Components/Sources/List.py b/lib/python/Components/Sources/List.py
index 3959746..492b5f5 100644
--- a/lib/python/Components/Sources/List.py
+++ b/lib/python/Components/Sources/List.py
@@ -50,7 +50,9 @@ to generate HTML."""
 
 	@cached
 	def getCurrent(self):
-		return self.master is not None and self.master.current
+		if self.master is None:
+			return None
+		return self.master.current
 
 	current = property(getCurrent)
 
-- 
1.9.1

Attached Files

•  0001-Return-None-instead-of-False-on-getCurrent-in-case.patch   806bytes   0 downloads

Edited by mx3L, 8 July 2015 - 18:45.

[Persian Prince]

I'm sending some merge requests here : https://github.com/O...i/enigma2/pulls

 

Just for contribution

[littlesat]

return self.master is not None and self.master.current

 

->

 

return self.master is not None and self.master.current or None

 

or even....

 

return self.master and self.master.current or None

Edited by littlesat, 28 July 2015 - 18:34.

[SpaceRat]

OpenPLi:
Please add package
python-ipaddress
to your feeds if you haven't already.

Will be required with one of the next OWIF updates.

It's inside openembedded, so activating it like here:
https://github.com/o...58a3d052ede2a48
is sufficient.

[betacentauri]

Wouldn't be a depend in the bitbake file a better solution?

[SpaceRat]

Will that add it to the feed as well?
Or will that just lead to some depend that can not be fulfilled?

[betacentauri]

I would say yes. Or better it should work like this.
You only need to add it to feed bitbake if no other package need it.

But I'm no bitbake expert...

[WanWizard]

It's not in the feed, there's already a request out for it (amongst others) because I want to start rewriting the crap network code in Enigma. But I think it will (or has been) looked only for master-next.

[Persian Prince]

If you have access to "E2OpenPlugins" it's safe to merge these requests :

 

https://github.com/E...rossEPG/pull/40

https://github.com/E...eoItalia/pull/1

https://github.com/E...poItalia/pull/1

https://github.com/E...Password/pull/1

https://github.com/E...ggiSport/pull/1

https://github.com/E...urScreen/pull/3

https://github.com/E...nAirPlay/pull/6

https://github.com/E...nmpAgent/pull/2

https://github.com/E...eoViewer/pull/3

https://github.com/E...logClock/pull/1

https://github.com/E...SetPicon/pull/2

https://github.com/E...cheFlush/pull/2

https://github.com/E...ShutDown/pull/7

https://github.com/E...nterface/pull/2

https://github.com/E...HetWeer/pull/16

 

Also for "PLi" :

 

https://github.com/O...ns-magic/pull/2

https://github.com/O...iplugins/pull/9

 

And for "littlesat" :

 

https://github.com/l...-PLiHD/pull/475

 

They're all about "Optimizing png files will reduce the image size." so no worries

 

I did upload enigma2 documentation here : https://pe4k.com/per...empire/enigma2/ (With optimized png files and our logo, No other changes)

 

If you think it's good to have this inside the https://github.com/O...ree/master/doxy folder I can send a merge request or maybe we can have a different repo for it like e2-documentation or something.

[Taapat]

@Persian Prince when you optimize these files or you also check whether they are correct sRGB profile?

After your optimization in enigma, using libpng 1.6.24 I saw a warning about incorrect sRGB profile in png files in countries: https://github.com/O...61a94f16a2757a9

I see that from this files you optimize hk.png.

[Persian Prince]

I didn't know about this but is this important ? I think we can ignore it.

 

Also I think pngquant reduces the image quality instead we can remove the meta data from png files with exiftool.

Edited by Persian Prince, 23 November 2016 - 13:24.

[Persian Prince]

Done: https://github.com/O...nigma2/pull/537

Info: Optipng is doing a great job for optimizing png files but it seems libpng >=1.6.x cares about iCCP chunk so we could easily remove all meta data from all png files for future warnings.
Also we would have smaller png files after this.

[Taapat]

I'm sorry. You probably did not understand me.

 

I have not checked the other files, but in countries I have error message only on these two files which I alredy fixed.

 

I just wanted to draw your attention to this fact.

When you make the optimization, in addition please correct also this error, and then no one will not need to change these images later.

Edited by Taapat, 23 November 2016 - 14:05.

[Persian Prince]

Yeah I know and I did send a new merge request not just for those 2 files but for all png files to have less size for all of them and no warnings for libpng

 

Good luck

[mirakels]

OpenPLi:
Please add package
python-ipaddress
to your feeds if you haven't already.

Will be required with one of the next OWIF updates.

It's inside openembedded, so activating it like here:
https://github.com/o...58a3d052ede2a48
is sufficient.

openpli-5 already has the package in the image and as ipk

[littlesat]

Consider to 'merge' this part to 4 for the time being...?

[arn354]

Consider to 'merge' this part to 4 for the time being...?

 

if you not do do it - OWIF will cease to work as it is allready commited OWIF upstream https://github.com/E...09eb46ef5974b12