Can only speak for myself: yes, insanely so, I have 19 days left to move datacenter. 
merge requests for PLi's git
Started by Persian Prince, 16 Apr 2013 12:12
1748 replies to this topic
Re: merge requests for PLi's git #1201
-
- PLi® Core member
- 70,220 posts
+1,798
Excellent
Posted 4 July 2018 - 20:57
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: merge requests for PLi's git #1202
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 7 July 2018 - 08:09
I can wish you luck only then 
https://github.com/O...e-core/pull/499
https://github.com/O...e-core/pull/501
https://github.com/O...e-core/pull/502
https://github.com/O...igma2/pull/1630
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1203
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 7 July 2018 - 08:40
@littlesat https://github.com/O...igma2/pull/1631 updated
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1204
-
- PLi® Core member
- 57,062 posts
+698
Excellent
Posted 7 July 2018 - 12:36
Done... when we find somewhere else a system info set we always should try to get it to the one file...
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1205
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1206
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1207
-
- PLi® Contributor
- 1,635 posts
+61
Good
Posted 7 July 2018 - 22:12
Update Systeminfo.py it seems to provoke an error on building!?
DM920UHD DVB-S2X TRIPLE tuner + Triple M.S tuner DVB-S2X, DVB-T2/T, QboxHD, QboxHD Mini, Icecrypt T2300HD,
Qviart Lunix3 4K, Raspberry Pi 4 Model B 4GB & 8GB
Vertex 4K60 4:4:4 600MHz
Re: merge requests for PLi's git #1208
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 8 July 2018 - 05:06
Update Systeminfo.py it seems to provoke an error on building!?
What's the error? My build is fine ...
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1209
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1210
-
- PLi® Core member
- 57,062 posts
+698
Excellent
Posted 8 July 2018 - 06:09
Merge, but also read my comments...
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1211
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 8 July 2018 - 06:23
That would be great, will you do it?Maybe we need to consider to
Add a Function FileHas or so... that checks if the file has a string inside (and also returns False or None when it does not exist...)
Also there is another check here: https://github.com/O...ch.py#L215~L218
But I wasn't sure how you want to use it.
Edited by Persian Prince, 8 July 2018 - 06:26.
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1212
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1213
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1214
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 8 July 2018 - 08:13
That would be great, will you do it?Maybe we need to consider to
Add a Function FileHas or so... that checks if the file has a string inside (and also returns False or None when it does not exist...)
Also there is another check here: https://github.com/O...ch.py#L215~L218
But I wasn't sure how you want to use it.
We can use "FileHas" for these lines for example:
https://github.com/O...stemInfo.py#L71
https://github.com/O...stemInfo.py#L73
https://github.com/O...stemInfo.py#L78
https://github.com/O...temInfo.py#L103
https://github.com/O...temInfo.py#L104
https://github.com/O...temInfo.py#L105
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1215
-
- PLi® Core member
- 57,062 posts
+698
Excellent
Posted 8 July 2018 - 08:16
Indeed..
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1216
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 8 July 2018 - 08:22
https://github.com/O...igma2/pull/1639 po update
https://github.com/O...igma2/pull/1640
So "FileHas" should be define here: https://github.com/O...es.py#L172~L182 right?
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1217
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1218
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1219
-
- PLi® Core member
- 46,969 posts
+541
Excellent
Posted 8 July 2018 - 10:02
PP and Littlesat: Watch out for unintended white space change. PR#5 introduced all sorts of spaces or tabs at the end of lines that weren't intended to be changed.
Hint: use the white space signalling function of git, it will mark lines with only whitespace or whitespace beyond the end of a line as red so you can correct it before you commit it.
Edited by Erik Slagter, 8 July 2018 - 10:07.
* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.
Re: merge requests for PLi's git #1220
-
- PLi® Core member
- 46,969 posts
+541
Excellent
Posted 8 July 2018 - 10:04
Also, as mentioned before, a description of "Update PluginComponent.py" is unacceptable. This time I will leave but next time -> revert. Descriptions containing "update", "tweak", "optimise" or "streamline" (if not specified any further) should raise the red flag.
A guideline for a good commit description is:
- what did the code do?
- what whas undesirable about that?
- how does this commit change that into desirable behaviour
Edited by Erik Slagter, 8 July 2018 - 10:06.
* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.
10 user(s) are reading this topic
0 members, 10 guests, 0 anonymous users
