Jump to content


Photo

merge requests for PLi's git


  • Please log in to reply
1370 replies to this topic

Re: merge requests for PLi's git #41 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 18 April 2013 - 20:49

src and dev packages have different meanings and python is designed for compiling when running, but if you start ignoring such enigma2 design principles and feel comfortable...

 

As I'm pretty sure that our friends are NOT shipping most of their Plugins without py just to save space and avoid compilation this move is simply suspicious - especially together with such arguments. If DMM would do such a move they would be grilled once more :)

 

But I'm just pointing out the personal opinion of a dumb person which doesn't understand the enigma2 community and Open Source.

 

And actually you are not splitting you are multiplying keeping different CPU architectures in mind.

 

why should we compile py files on the box when we can do it with a compiler machine ? i don't agree with you at all

if you wanna change something simply install the -src package , there is no need to install these kind of files for normal users

feed will provide the sources not the box itself

other devs could publish their plugins with -src beside them and i think it's not PLi's duty to consider such things

 

DMM removed the enigma2 sources and you wanna compare this with splitting ? really ?

 

i think removing and splitting has different meanings in my dictionary

 

btw i'm not a PLi member and i can just sit and drink when i have extra time but i wanna contribute as a friend

 

they can revert the commits if they want


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #42 gutemine

  • Senior Member
  • 873 posts

+68
Good

Posted 18 April 2013 - 20:53

I simply don't like if somebody decideds for me what I need.

 

And there might be others seeing it the same way.

 

But it is not my decision what PLi does.

 

But from now on I hereby FORBID to ship any of MY Plugins with compiled python!

 

But this is OT here, I'm sorry.


Edited by gutemine, 18 April 2013 - 20:55.


Re: merge requests for PLi's git #43 pieterg

  • PLi® Core member
  • 32,766 posts

+245
Excellent

Posted 18 April 2013 - 21:35

But from now on I hereby FORBID to ship any of MY Plugins with compiled python!

Ah, introduce more limitations, that's the spirit

Re: merge requests for PLi's git #44 Rob van der Does

  • Senior Member
  • 7,731 posts

+184
Excellent

Posted 18 April 2013 - 21:42

Euuuhhh..... if a plugin without .pyo-files has been installed, OPKG won't remove the files that E2 has compiled. Hence the plugin will have to be removed by hand.

Surely that can't be the idea?



Re: merge requests for PLi's git #45 ims

  • PLi® Core member
  • 11,196 posts

+168
Excellent

Posted 18 April 2013 - 21:42

Would not be better repair dmm's e2 images to next night build ? ;)


Kdo nic nedělá, nic nezkazí!

Re: merge requests for PLi's git #46 gutemine

  • Senior Member
  • 873 posts

+68
Good

Posted 18 April 2013 - 21:58

It is not only that who removes what problem, it is also much more fun for the plugin devlopers to analyze crashdumps and supprt their plugins.

 

Hence I'm simply forbiding shipping my stuff this way without the python sources - like it or not.

 

YOU are not supporting them, are you ?

 

And you are simply violating the license rules of a lot of plugins that clearly state their credits and the license has to be shipped as it is togetherwith the plugin - and this is very hard to read in a pyo - and an extra package with the sources is then already a violation.

 

If you are not even understanding the implications of what you are doing then you should not do it - I'm sorry for such hard words.


Edited by gutemine, 18 April 2013 - 22:01.


Re: merge requests for PLi's git #47 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 18 April 2013 - 22:04

so ubuntu is violating everything ;)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #48 gorski

  • Senior Member
  • 1,700 posts

+46
Good

Posted 18 April 2013 - 22:27

Luckily, not all developers are sold souls...


<span style='font-family: comic sans ms,cursive'>"Enlightenment is man's emergence from his self-incurred immaturity. Immaturity is the inability to use one's own understanding without the guidance of another. This immaturity is self-incurred if its cause is not lack of understanding, but lack of resolution and courage to use it without the guidance of another. The motto of enlightenment is therefore: Sapere aude! Have courage to use your own understanding!</span><br /> <br /><span style='font-family: comic sans ms,cursive'>Laziness and cowardice are the reasons why such a large proportion of men, even when nature has long emancipated them from alien guidance..." I. Kant, "Political writings" (1784)</span><br /> <br /><span style='font-family: comic sans ms,cursive'><a class='bbc_url' href='<a class='bbc_url' href='http://eserver.org/p...lightenment.txt'>http://eserver.org/p...ent.txt</a>'><a class='bbc_url' href='http://www.english.upenn.edu/~mgamer/Etexts/kant.html</a>'>http://www.english.upenn.edu/~mgamer/Etexts/kant.html</a></a> - the jolly text on Enlightenment, at the basis of Modernity...</span>

Re: merge requests for PLi's git #49 theparasol

  • Senior Member
  • 4,141 posts

+196
Excellent

Posted 18 April 2013 - 22:36

Its always nice to see difference  in approaches and discussion about the "best" approach.

I dont have an opinion since I dont know all the ins and outs about certain choices but I'm always openminded to learn from you guys!

My python skills are based on reading/learning from sourcecode and searching for right commands to change (minor) things so I would be glad that the source is always shipped.

I dont care about "startup" time of enigma2 as long as it isnt taking 15 minutes.



Re: merge requests for PLi's git #50 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 18 April 2013 - 22:38

@pieterg

 

DMM has

# Inject the /boot partition into /etc/fstab. At image creation time,
# this is done by IMAGE_CMD_jffs2.nfi (image_types_nfi.bbclass).
pkg_postinst_base-files() {
if [ -z "$D" ]; then
	ROOT='\<root=/dev/mtdblock3\>\|\<root=ubi0:rootfs\>'
	if grep -q $ROOT /proc/cmdline && ! grep -q '\s\+/boot\s\+' /etc/fstab; then
	       printf '/dev/mtdblock2\t/boot\t\tjffs2\tro\t\t\t\t0 0\n' >> /etc/fstab
	fi
	if grep -q '/dev/ubi0_1' /proc/mounts && ! grep -q '\s\+/data\s\+' /etc/fstab; then
	        printf '/dev/ubi0_1\t/data\t\tubifs\trw\t\t\t\t0 0\n' >> /etc/fstab
	fi
fi
}

in base-files_3.0.14.bbappend , do we need it ?


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #51 pieterg

  • PLi® Core member
  • 32,766 posts

+245
Excellent

Posted 18 April 2013 - 22:39

no, not really. As we don't keep the boot partition mounted.
We should make a workaround in the kernel-image / bootlogo postinst hooks though.

Re: merge requests for PLi's git #52 pieterg

  • PLi® Core member
  • 32,766 posts

+245
Excellent

Posted 18 April 2013 - 22:48

We should make a workaround in the kernel-image / bootlogo postinst hooks though.

actually, no need, as the boot partition is still jffs2 (the secondstage loader does not support UBI)

Re: merge requests for PLi's git #53 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 18 April 2013 - 23:24

ok

 

also tonight i'll send some merge requests for Open PLi 2.1 like dm800 driver update and some tweaks for less image size


Edited by Persian Prince, 18 April 2013 - 23:24.

If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #54 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 19 April 2013 - 03:43

new merge requests for both OEs sent

 

apply what you want :)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #55 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 19 April 2013 - 04:09

i think your build stoped on dm7020hd

 

maybe it's good to move all dreambox models after vuplus in the build script

 

also we have dm7020hdv2 and we can have something like http://git.opendream...392dd;hb=master

 

for it , it needs

require conf/machine/include/dreambox-nand-1024mb-2k.inc

and for Makefile : http://git.opendream...33eb11a41abbcc4


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #56 Persian Prince

  • Senior Member
  • 1,705 posts

+234
Excellent

Posted 19 April 2013 - 04:31

i sent another pull request here : https://github.com/E...enplugins/pulls

 

it will reduce all packages specially Open WebIF also you should update e2openplugins submodule after merging (for both OEs)

 

up to you ;)


Edited by Persian Prince, 19 April 2013 - 04:32.

If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #57 malakudi

  • PLi® Core member
  • 1,447 posts

+66
Good

Posted 19 April 2013 - 09:07

normal users only need compiled packages with pyo files not with py files (sources)

 

it will help to reduce the image size and prevent compiling on the box

 

"Normal" users are now confused by seeing two packages in plugin management, one normal and one with -src in the name. And if they install -src, when they remove it the plugin is still installed because the pyo files are not deleted. src package should have both py and pyo or a proper uninstall script. How much space you think you are saving by removing high compressable text files? 1%?

 

I think what you did is wrong and I suggest reverting it.


Edited by malakudi, 19 April 2013 - 09:11.


Re: merge requests for PLi's git #58 littlesat

  • PLi® Core member
  • 49,729 posts

+543
Excellent

Posted 19 April 2013 - 09:13

Normal" users are now confused by seeing two packages in plugin management, one normal and one with -src in the name

As far I know this is fixed....

Even for enigma2 we have a -src ipk.... so why not for plugins?


Edited by littlesat, 19 April 2013 - 09:14.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #59 Erik Slagter

  • PLi® Core member
  • 45,387 posts

+499
Excellent

Posted 19 April 2013 - 09:13

<sorry not relevant>


Edited by Erik Slagter, 19 April 2013 - 09:14.

* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: merge requests for PLi's git #60 pieterg

  • PLi® Core member
  • 32,766 posts

+245
Excellent

Posted 19 April 2013 - 09:25

I don't think it's a big issue, we've been doing this for enigma2 as well, for years.
OK, mostly to make things fit on the dm7025, which could use every single bit of size reduction.
But some other dreambox models have very limited flash as well, which, especially now with UBI, will become an issue for several users.

Of course, for a few python files, you do not save very much.
But if I look at enigma2-src for instance, if I install it my rootfs changes from
Filesystem           1K-blocks      Used Available Use% Mounted on
ubi0:rootfs             223520     74444    149076  33% /
to
ubi0:rootfs             223520     71020    152500  32% /
Which is ~3.4 MB's, even after compression.

Agreed, for plugins with just a few py's it's probably not worth the hassle to try and split every single package.
But also, I don't consider this such a big issue that we should revert it.

(The issue of seeing -src packages in the plugin list should have been addressed in todays build by the way)




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users