86 replies to this topic

[littlesat]

Then use a suitable or fixed picon set.

[littlesat]

It seems no images were build... Milo did commit a fix yesterday that wasn't included yet in the latest feeds due to no builds...

Edited by littlesat, 4 August 2013 - 19:17.

[Dimitrij]

It seems no images were build... Milo did commit a fix yesterday that wasn't included yet in the latest feeds due to no builds...

clear

[littlesat]

When these patches do not solve the issue i consider to go for a plan b...(add keep aspect ratio feature to blitscale). But when this is not required i prefer to avoid my plan b.

[Dimitrij]

Problems with picons not resolved.

[littlesat]

I can make the borders black, so you do not see them... -or-

You can convert the picons to the correct format... -or-

Plan B could be implemented (I still do not know if this works).

 

In the graphical multi EPG you should have the same issue for ever... so this is not something brand new!!!

Edited by littlesat, 6 August 2013 - 08:01.

[Dimitrij]

plan С
reverting changes

[MiLo]

Yeah, let's got back to wasting megabytes of memory and ignoring the hardware rendering acceleration. Excellent idea.

Plan D: Just live with it for a while longer. Eventually it'll be solved.

[Dimitrij]

I can make the borders black, so you do not see them... -or-

Although, it is an option...

 

GraphMultiEpg.py

			if picon != "":
-				self.picload.setPara((piconWidth, piconHeight, 1, 1, 1, 1, "#FFFFFFFF"))
+                               self.picload.setPara((piconWidth, piconHeight, 1, 1, 1, 1, '#000f0f0f'))

[littlesat]

In fact this is a work-a-round.... as not all skins do use the same background color... And in addition it removes the green selected channel borders what you should see in the GMEPG

 

Therefore I'm considering plan B.... this meens adding a keep aspect ratio option in blitScale and blit the picon via blitScale (that is how I planned it in the first place in the ServiceList, but I did not implement the keep aspect ratio feature yet.... so the picon was spreaded).

The best short term solution is to convert your picons to not colormapped picons.

Edited by littlesat, 6 August 2013 - 09:19.

[MiLo]

If the list items at "y" pixels high, the width to be rendered is then (y * picon.width / picon.height). So if you just use LoadPixmap to load the picon image, and then render it using that formula, you don't even need any changes in the C++ code.

Besides, LoadPixmap is more efficient than picload, because it will load a pixmap only once. That will speed up the list rendering considerably.

[littlesat]

Approx. That formula i want to add to painter.blitscale by adding a keep aspect ratio flag...
I will try if i can implement it this evening.

Edited by littlesat, 6 August 2013 - 12:29.

[MiLo]

What I meant was, you can do it all in python code. You don't need any changes to the C++ parts at all.

[littlesat]

For the GME that works... for the servicelist not... But when making this in python which I already tried you get rounding issues... But you also suggested the loadPixmap method....

Edited by littlesat, 6 August 2013 - 13:56.

[littlesat]

I suggest it is even better to convert the picons that are displayed incorrectly. As you can see in the post from 2boom they are even smaller. Possibly someone can give a batch proces for them...

[2boom]

miniGui for pngquant

Attached Files

•  Pic.zip   4.94KB   14 downloads

[littlesat]

plan С
reverting changes

That is even not any option as the issue was already there forever... (in the GMEPG).
 

[Taapat]

I have just found a small bug. I do not know how long it is, and I think this is due to changes for picon in channel list.

As can be seen in the picture, background of text over the icon, when it's is on the markup, has background of markup, instead background of icon. If not markup, then the background is correct.

I have SH4 receiver and perhaps because it does not work as they should, but maybe you can check, if you do not have the same defect.

Attached Files

•  screenshot.jpg   73.7KB   55 downloads

[Taapat]

In the skin, this place is written as follows:

 

<widget source="list" render="Listbox" position="10,15" size="340,300" \
  scrollbarMode="showOnDemand">
  <convert type="TemplatedMultiContent">
    {
      "template": [MultiContentEntryPixmapAlphaTest(pos=(5, 5), \
        size=(51, 40), png=1), 
      MultiContentEntryText(pos=(65, 10), size=(275, 40), font=0, \
        flags=RT_HALIGN_LEFT, text=0), 
      MultiContentEntryText(pos=(5, 25), size=(51, 16), font=1, \
        flags=RT_HALIGN_CENTER, text=2),],
      "fonts": [gFont("Regular", 26), gFont("Regular", 12)],
      "itemHeight": 50
    }
  </convert>
</widget>
 

 

 

[littlesat]

Is not related to the picon in channellist...