5 replies to this topic

[Pr2]

Hi,

 

In the GUI I think there is a bug:

 

When checking in the source code I saw this:

 

http://sourceforge.n...ontend.cpp#l127

 

void eDVBFrontendParametersCable::set(const CableDeliverySystemDescriptor &descriptor)
{
frequency = descriptor.getFrequency() / 10;
symbol_rate = descriptor.getSymbolRate() * 100;
switch (descriptor.getFecInner())
{
default:
case 0: fec_inner = FEC_Auto; break;
case 1: fec_inner = FEC_1_2; break;
case 2: fec_inner = FEC_2_3; break;
case 3: fec_inner = FEC_3_4; break;
case 4: fec_inner = FEC_5_6; break;
case 5: fec_inner = FEC_7_8; break;
case 6: fec_inner = FEC_8_9; break;
case 7: fec_inner = FEC_3_5; break;
case 8: fec_inner = FEC_4_5; break;
case 9: fec_inner = FEC_9_10; break;
}

[Pr2]

 

When I try a manual scan from the GUI the possible FEC are:

 

In the GUI  : auto, 1/2, 2/3, 3/4, 5/6, 6/7, 7/8, 8/9, None

In the code : auto, 1/2, 2/3, 3/4, 5/6, 7/8, 8/9, 3/5, 4/5, 9/10

 

So 6/7 is wrong and 3/5, 4/5, 9/10 are missing.

 

Can you check and adapt the GUI to reflect the real possible FEC for DVB-C?

 

Pr2

P.S.: I have regular problem on this site with the code /code all the text below the /code is simply dropped!

[Pr2]

Hi,

 

Can someone confirm that this is indeed a mismatch between the real DVB-C and the GUI?

 

Pr2

[Pr2]

Sorry for the up but I think that there is a "bug" here.

[Pr2]

Hi,

In this file:  /openpli/enigma2/lib/python/Screens/ScanSetup.py

Can you please change the following lines:

Starting line 619
 

self.scan_cab.fec = ConfigSelection(default = defaultCab["fec"], choices = [
(eDVBFrontendParametersCable.FEC_Auto, _("Auto")),
(eDVBFrontendParametersCable.FEC_1_2, "1/2"),
(eDVBFrontendParametersCable.FEC_2_3, "2/3"),
(eDVBFrontendParametersCable.FEC_3_4, "3/4"),
(eDVBFrontendParametersCable.FEC_5_6, "5/6"),
(eDVBFrontendParametersCable.FEC_6_7, "6/7"),
(eDVBFrontendParametersCable.FEC_7_8, "7/8"),
(eDVBFrontendParametersCable.FEC_8_9, "8/9"),
(eDVBFrontendParametersCable.FEC_None, _("None"))])

Last line 628
By those ones:

self.scan_cab.fec = ConfigSelection(default = defaultCab["fec"], choices = [
(eDVBFrontendParametersCable.FEC_Auto, _("Auto")),
(eDVBFrontendParametersCable.FEC_1_2, "1/2"),
(eDVBFrontendParametersCable.FEC_2_3, "2/3"),
(eDVBFrontendParametersCable.FEC_3_4, "3/4"),
(eDVBFrontendParametersCable.FEC_5_6, "5/6"),
(eDVBFrontendParametersCable.FEC_7_8, "7/8"),
(eDVBFrontendParametersCable.FEC_8_9, "8/9"),
(eDVBFrontendParametersCable.FEC_3_5, "3/5"),
(eDVBFrontendParametersCable.FEC_4_5, "4/5"),
(eDVBFrontendParametersCable.FEC_9_10, "9/10"),
(eDVBFrontendParametersCable.FEC_None, _("None"))])

And this file:  /openpli/enigma2/lib/dvb/frontendparms.cpp
Must be changed:
line start: 357
 

int eDVBCableTransponderData::getFecInner() const
{
if (originalValues) return transponderParameters.fec_inner;
switch (getProperty(DTV_INNER_FEC))
{
case FEC_NONE: return eDVBFrontendParametersCable::FEC_None;
case FEC_1_2: return eDVBFrontendParametersCable::FEC_1_2;
case FEC_2_3: return eDVBFrontendParametersCable::FEC_2_3;
case FEC_3_4: return eDVBFrontendParametersCable::FEC_3_4;
case FEC_5_6: return eDVBFrontendParametersCable::FEC_5_6;
case FEC_6_7: return eDVBFrontendParametersCable::FEC_6_7;
case FEC_7_8: return eDVBFrontendParametersCable::FEC_7_8;
case FEC_8_9: return eDVBFrontendParametersCable::FEC_7_8;
default:
case FEC_AUTO: return eDVBFrontendParametersCable::FEC_Auto;
}
}

 

 
Line end: 374
 

int eDVBCableTransponderData::getFecInner() const
{
if (originalValues) return transponderParameters.fec_inner;
switch (getProperty(DTV_INNER_FEC))
{
case FEC_NONE: return eDVBFrontendParametersCable::FEC_None;
case FEC_1_2: return eDVBFrontendParametersCable::FEC_1_2;
case FEC_2_3: return eDVBFrontendParametersCable::FEC_2_3;
case FEC_3_4: return eDVBFrontendParametersCable::FEC_3_4;
case FEC_5_6: return eDVBFrontendParametersCable::FEC_5_6;
case FEC_7_8: return eDVBFrontendParametersCable::FEC_7_8;
case FEC_8_9: return eDVBFrontendParametersCable::FEC_8_9;
case FEC_3_5: return eDVBFrontendParametersCable::FEC_3_5;
case FEC_4_5: return eDVBFrontendParametersCable::FEC_4_5;
case FEC_9_10: return eDVBFrontendParametersCable::FEC_9_10;
default:
case FEC_AUTO: return eDVBFrontendParametersCable::FEC_Auto;
}
}

 

 

With such change we will match the frontend definition.

Please test it before commit, because I no longer have a build env to test it myself.

Thanks,

Pr2

[Pr2]

hi,

 

Sorry I don't have the time yet to setup the build environment, so no I didn't test yet the change.

 

Pierre