21 replies to this topic

[athoik]

Hello,

I notice that MessageBox title is not translated.

After adding the following on the MessageBox.py it works.

...
                                }, -1)

                self.onLayoutFinish.append(self.layoutFinished)

        def layoutFinished(self):
                self.setTitle(_(self.title))

        def initTimeout(self, timeout):
...

Also adding the following to skin works.

...
    <applet type="onLayoutFinish">
self.setTitle(_(self.title))
    </applet>
...

If the first way is acceptable i can create a patch.

Thanks

[mirakels]

A patch for Messagebox.py seems reasonable.

[littlesat]

I beleive it is better to put in the py as in the skin ....

Edited by littlesat, 18 October 2013 - 10:05.

[athoik]

Ok!

Here is the patch.

Attached Files

•  0001-MessageBox-Translate-Title.patch.txt   690bytes   7 downloads

[littlesat]

It was already granted... I was too quick xqq...

[mirakels]

It was already granted... I was too quick xqq...

yes, but you did not grant him credit for the suggested patch!

 

The book of open source and cooperation probably states: "If someone offers to craft a patch for an idea, and the idea is accepted, one does not steal the idea and quickly implements the idea, but allows that this someone posts the patch"!

[littlesat]

That is also one thing that I missed

@athoik thousand xqqqqqqqqq

[athoik]

There is no problem! It's only two lines of code

[Pedro_Newbie]

not bad 500 xqqqqqqqqq per line (whatever xqqqqqqqqq may be)

Edited by Pedro_Newbie, 18 October 2013 - 14:31.

[littlesat]

Excuse... = Xqq...

 

Just like Bar-B-Q

Edited by littlesat, 18 October 2013 - 14:47.

[littlesat]

And stupid me... http://sourceforge.n...7919961f0c09f1/

[athoik]

Hello,

I notice also that EventViewContextMenu title is not translatable.

 0001-Make-EventViewContextMenu-title-translatable.patch.txt   775bytes   3 downloads

But we need to use valid translation also on PLi-HD (valid is Event view menu not Eventview menu)

-<screen name="EventViewContextMenu" position="fill" title="Eventview menu" flags="wfNoBorder">
+<screen name="EventViewContextMenu" position="fill" title="Event view menu" flags="wfNoBorder">

Do you want me to create patch also for PLi-HD skin on Github?

Edited by athoik, 19 October 2013 - 09:56.

[littlesat]

That would indeed be nice...

[athoik]

That would indeed be nice...

Here is the PLi-HD change: https://github.com/l...-PLiHD/pull/171

[athoik]

We also need to commit 0001-Make-EventViewContextMenu-title-translatable.patch.txt on Enigma.

Thanks.

[littlesat]

I can only do one thing at the time ....

[athoik]

I can only do one thing at the time ....

Thanks

[athoik]

Hello,

IpkgInstaller suffers from the same issue.

class IpkgInstaller(Screen):
        skin = """
                <screen name="IpkgInstaller" position="center,center" size="550,450" title="Install extensions" >
...

I cannot use the same code as before, probably because we are using also IpkgInstaller in PLi-HD skin. This causes title to be nothing!

...
  <screen name="IpkgInstaller" position="fill" flags="wfNoBorder">
...

Also if you define title on skin (eg title=" 2.Install extension (for skin.xml)") both titles rendered on screen!

 screenshot.jpg   14.68KB   28 downloads

Why both titles are rendered? Normaly one should win, the one in skin.xml?

Any idea how to solve it?

Thanks

[littlesat]

Can we see nice patches again?

[athoik]

"Reception Settings" screen is not translated also.



Valid translation exists (http://sourceforge.n.../po/el.po#l4252).

This must be done in the same way (using title) or is better to use gettext_("Reception Settings") ?