56 replies to this topic

[athoik]

Hello,


eServiceMP3::getInfoString didn't return info for sServiceref.

Without sServiceref Picons for GStreamer services cannot rendered cause sServiceref was empty.

I wrote two patches, please commit what you think is better

First patch uses only if.

--- a/lib/service/servicemp3.cpp
+++ b/lib/service/servicemp3.cpp
@@ -1083,6 +1083,14 @@ int eServiceMP3::getInfo(int w)
 
 std::string eServiceMP3::getInfoString(int w)
 {
+	if ( m_sourceinfo.is_streaming && w == sServiceref )
+	{
+		eServiceReference ref(m_ref);
+		ref.type = eServiceFactoryMP3::id;
+		ref.path.clear();
+		return ref.toString();
+	}
+
 	if ( !m_stream_tags && w < sUser && w > 26 )
 		return "";
 	const gchar *tag = 0;

 0001-ServiceMP3-Handle-sServiceref-on-getInfoString1.patch.txt   933bytes   3 downloads


Second patch uses tries to be more "generic". Also returns "Internet" for sProvider.

--- a/lib/service/servicemp3.cpp
+++ b/lib/service/servicemp3.cpp
@@ -1083,6 +1083,25 @@ int eServiceMP3::getInfo(int w)
 
 std::string eServiceMP3::getInfoString(int w)
 {
+	if ( m_sourceinfo.is_streaming )
+	{
+		switch (w)
+		{
+		case sProvider:
+			return "Internet";
+		case sServiceref:
+		{
+			eServiceReference ref(m_ref);
+			ref.type = eServiceFactoryMP3::id;
+			ref.path.clear();
+			return ref.toString();
+		}
+		default:
+			break;
+		}
+		return iServiceInformation::getInfoString(w);
+	}
+
 	if ( !m_stream_tags && w < sUser && w > 26 )
 		return "";
 	const gchar *tag = 0;

 0001-ServiceMP3-Handle-sServiceref-on-getInfoString2.patch.txt   1.06KB   5 downloads

Thanks!

[littlesat]

So two patches for the same????

[athoik]

Commit what you think is better.

Second patch also returns data sProvider (not sure where it is used and if it is required for GStreamer).

Edited by athoik, 12 December 2013 - 18:53.

[doubledip]

Does it work with rtmp streams?

[athoik]

Protocol doen't matter. All services that make use of ServiceMP3 it is possible to get EPG (using Xmltvimport).

[doubledip]

Is this example correkt, because it didnt work for me.

<channel id="channel.id">1:0:1:1000:1000:0:0:0:0:0:rtmp%3a//example.com playpath=... swfUrl=http%3a//... pageUrl=http%3a//... live=1</channel> <!--channel-->

 

#SERVICE 4097:0:1:1000:1000:0:0:0:0:0:rtmp%3a//example.com playpath=... swfUrl=http%3a//... pageUrl=http%3a//... live=1:channel

 

 

Thank You

[athoik]

Just use: http://example.com in xmltvimport like this:

 

 

<channel id="channel.id">1:0:1:1000:1000:0:0:0:0:0:http%3a//example.com</channel> <!--channel-->

 

In channel list use the actual url.

Edited by athoik, 21 December 2013 - 19:19.

[doubledip]

So everything behind http is not important?

 

I tired it with ocko tv rtmp stream, but couldnt get an epg. I changed the channel id to a random channel and got epg from the random channel for the ocko stream. It seems the epg from ocko was the problem.

 

Thanks again

 

Great work!

[athoik]

Xmltvimport needs the http%3a// (whatever) just to start a fake recording and then to import EPG.

But almost every piece of code had small issues (even the fake recording).

Now all issues gone (most probably), what is missing is some real examples in Xmltvimport as a quide, cause many users have the same questions as you.

[doglover]

Here is a working example.

 

http://openpli.org/f...t-xmltv-import/

 

Pls. correct if there are misinterpretations (but the example works on a et-9500 with OpenPli 4.0)

 

Willy

[theparasol]

Yesterday and today I did some rework on Shoutcast after a message that mp3 tags didnt get parsed any longer.

 

Right now on mp3 streams from the net I face this behaviour:

 

[SHOUTcast] cover visible 0 self.hide
playing 4097:0:0:0:0:0:0:0:0:0:http%3a//178.19.116.250%3a7062
[servicelist] search for service in userbouquets
main thread is non-idle! display spinner!
[servicelist] service not found in any userbouquets
eServiceMP3::construct!
getResolvedKey config.mediaplayer.extraHeaders failed !! (Typo??)

the servicelist entries are new for me, it takes additional 10~15 seconds before attempt is done to start fetching the mp3 stream from the net.

Lost time if you ask me.... Same thing happens with uitzending gemist.

Somehow the code of updating the epg needs additional conditions to narrow it down only to iptv streams that have epg.

Like its now its applied on all kind of streams even onces that obvious have no epg data.

 

Is it an idea to move the specific video & epgupdate code to a later point and adding additional condition?

 

if ( m_sourceinfo.is_video = TRUE )
    {
        CONNECT(m_subtitle_sync_timer->timeout, eServiceMP3::pushSubtitles);
        CONNECT(m_pump.recv_msg, eServiceMP3::gstPoll);
        CONNECT(m_nownext_timer->timeout, eServiceMP3::updateEpgCacheNowNext);
    }
    eDebug("eServiceMP3::playbin uri=%s", uri);
#if GST_VERSION_MAJOR < 1
    m_gst_playbin = gst_element_factory_make("playbin2", "playbin");

 

I hope this way at least the mp3 streams aren't affected any longer.

Perhaps someone knows another fine trick to apply it just on video streams that have epg, right now uitzendinggemist streams are affected too.

[theparasol]

update: if ( m_sourceinfo.is_video = TRUE ) has to be if ( m_sourceinfo.is_video == TRUE )       

[pieterg]

I don't think 'is_video' is a good condition to check for.
Also, you always need the pump signal.
And the subtitle sync signal does not hurt, because it does not do anything when there are no subtitles.

It's just the epg poll timer you're after I think?
Perhaps use the serviceref? I believe the epgcache only works if sid/tsid/onid are valid?
In all other cases, the epgcache should return 'no event' rather quickly, should not take 10-15s.

[theparasol]

I haven't stopwatched it, but the spinners appear and box is burning several seconds of time on things it shouldn't do at that point.

If the user presses ok on a certain radio stream from the web it should starting to get streamdata to play not wasting time to see if there is an EPG update.

I'm not sure if sid/tsid/onid are invalid, But on other hand it isnt set either if you ask me, if its considered valid its merely a lucky positive hit.

mp3 stream is started like this:

 

sref = eServiceReference("4097:0:0:0:0:0:0:0:0:0:%s" % url.replace(':', '%3a'))

self.session.nav.playService(sref)

[theparasol]

I see strange things in this log, its always like this on mp3 streams...

 

Infobar wants to apply cuts?! (on live mp3 stream....)

EPG search even if mp3 stream should be played?

 

I dont care for logs, but before stream is playing several seconds of silence are wasted accompanied with spinners

 

playing 4097:0:1:0:0:0:0:0:0:0:http%3a//88.198.3.15%3a11950

[servicelist] search for service in userbouquets

main thread is non-idle! display spinner!

[servicelist] service not found in any userbouquets

eServiceMP3::construct!

getResolvedKey config.mediaplayer.extraHeaders failed !! (Typo??)

eServiceMP3::playbin uri=http://88.198.3.15:11950

eServiceMP3::starting pipeline

resolved to PLAY

gst_element_query_position failed in getPlayPosition

resolved to PLAY

gst_element_query_position failed in getPlayPosition

resolved to PLAY

gst_element_query_position failed in getPlayPosition

new service started! trying to download cuts!

download failed, no cuesheet interface

RemovePopup, id = ZapError

[SHOUTcast] EVENT ==> 0

main thread is non-idle! display spinner!

eServiceMP3::state transition NULL -> READY

 

And the now normal buffering log flooding?

 

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 2 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 0 percent done

[SHOUTcast] EVENT ==> 18

Buffering 1 percent done

[SHOUTcast] EVENT ==> 18

Buffering 2 percent done

[SHOUTcast] EVENT ==> 18

 

 

Attached Files

•  logje.zip   2.36KB   2 downloads

[technic]

Hi!

I am really glad to see these changes. But I have a question. In case I want to implement own service with custom serviceID, but with epg from EPGCache the following line obstructs me.
http://sourceforge.n...cache.cpp#l2471

Why only special serviceIDs are allowed to query from EPGCache?

[osicam]

Hello I am a bit lost with all the discussions here lol

Can someone just tell me  if there is a solution to display epg on channel list (current and next) with service 5002 (exteplayer3) ?

 

Thanks for your help