58 replies to this topic

[DimitarCC]

What about subtitles? It can be none selected and that will cause every 2-3 seconds refresh of the list till you select one...

That event is not for that or at least is not for that place in eServiceMP3...Constant requests for refreshing the audio and subtitle list is not good anyway.

So either audio/subtitle list update should be on different specific event or that one. All other solutions are hack imho.

Changing the audio/subs list update event however will cause a lot of incompatibilities with third party plugins. So i decided to break less by changing the events for tags ....

But FPS (what is the problematic now) can be get from the eAVSwitcher and should not rely on evUpdatedInfo....

[Beeker]

Last commits servicemp3 from October 24, break title information Shoutcast (and probably more).

 

Result is always an empty string.

sTitle = self.currPlay.info().getInfoString(iServiceInformation.sTagTitle)

.

Edited by Beeker, 28 October 2024 - 15:17.

[Beeker]

The __event function

 

https://github.com/O.../plugin.py#L946

 

Is called by navigation.py  dispatchEvent().

 

https://github.com/O...vigation.py#L86

 

Added to list of m_event

https://github.com/O...vigation.py#L34

 

When is working correctly, __event() Shoutcast will be called 5 times with EV value 5. Then the titile is grabbed.

 

Now with latest servicemp3 changes, __event() will be called once, with emtpy string as result.

[Dimitrij]

"Framerate": (self.FRAMERATE, (iPlayableService.evVideoFramerateChanged, iPlayableService.evUpdatedInfo)),

Use evVideoFramerateChanged
always N/A

[DimitarCC]

Last commits servicemp3 from October 24, break title information Shoutcast (and probably more).

 

Result is always an empty string.

sTitle = self.currPlay.info().getInfoString(iServiceInformation.sTagTitle)

.

 

Probably that is using evUpdatedInfo to get its data. Now that is changed to evUser+15. Try to use that and see is it working.

evUpdatedInfo is out of question to be used since it breaks any subtitle/ audio selection in eServiceMP3...

[DimitarCC]

"Framerate": (self.FRAMERATE, (iPlayableService.evVideoFramerateChanged, iPlayableService.evUpdatedInfo)),

Use evVideoFramerateChanged
always N/A

 

 

Yes in PLi is N/A die to that there is no procedure to get the framerate from eAVSwitch.getInstance().getFrameRate(0)...As i mentioned there is no problem in OE-A distros...

 

just add

"Framerate": (self.FRAMERATE, (iPlayableService.evVideoFramerateChanged, iPlayableService.evUpdatedInfo, iPlayableService.evUser+15)),

That should return it as before.

Edited by DimitarCC, 28 October 2024 - 18:40.

[Beeker]

 

Last commits servicemp3 from October 24, break title information Shoutcast (and probably more).

 

Result is always an empty string.

sTitle = self.currPlay.info().getInfoString(iServiceInformation.sTagTitle)

.

 

Probably that is using evUpdatedInfo to get its data. Now that is changed to evUser+15. Try to use that and see is it working.

evUpdatedInfo is out of question to be used since it breaks any subtitle/ audio selection in eServiceMP3...

 

 

The only way to fix title of song, I found so far, is to use evUpdatedInfo as argument again.

m_event((iPlayableService*)this, evUpdatedInfo);

https://github.com/O...cemp3.cpp#L2041

Edited by Beeker, 29 October 2024 - 08:11.

[DimitarCC]

 

 

Last commits servicemp3 from October 24, break title information Shoutcast (and probably more).

 

Result is always an empty string.

sTitle = self.currPlay.info().getInfoString(iServiceInformation.sTagTitle)

.

 

Probably that is using evUpdatedInfo to get its data. Now that is changed to evUser+15. Try to use that and see is it working.

evUpdatedInfo is out of question to be used since it breaks any subtitle/ audio selection in eServiceMP3...

 

 

The only way to fix title of song, I found so far, is to use evUpdatedInfo as argument again.

m_event((iPlayableService*)this, evUpdatedInfo);

https://github.com/O...cemp3.cpp#L2041

 

 

What i dont get is why that shoutcast plugin uses the event from navigation and not utilize the events like in every other screen....

 

m_event((iPlayableService*)this, evUpdatedInfo); only rise evUpdatedInfo event. in other case it rise evUser+15 (which seems is not handled in the plugin)....

 

I am not familiar nor ever used that shoutcast plugin so i dont know but it looks to me as design issue....

 

P.S. What you can try is:

 

in here 

 

https://github.com/O.../plugin.py#L955

elif ev == 5:
   if not self.currPlay:
........

replace with


elif ev == 5 or ev == 271:
   if not self.currPlay:

That will handle the new event evUser+15.....

Edited by DimitarCC, 29 October 2024 - 09:14.

[Beeker]

Yes that works.

Thanks.

 

I'll create PR for Shoutcast.

[WanWizard]

Merged.

[Beeker]

Thanks.

[Dimitrij]

"Framerate": (self.FRAMERATE, (iPlayableService.evVideoFramerateChanged, iPlayableService.evUpdatedInfo, iPlayableService.evUser+15)),

Done, show N/A

fps visible only iptv service press key pause.

[DimitarCC]

"Framerate": (self.FRAMERATE, (iPlayableService.evVideoFramerateChanged, iPlayableService.evUpdatedInfo, iPlayableService.evUser+15)),

Done, show N/A

fps visible only iptv service press key pause.

 

So i am not sure where you get N/A.....

 

On my side i get the FPS in service information and in second infobar.... Dont know where is the problem....

 

 

 fps.png   242.77KB   1 downloads

 

Or are you mean for media files play?

Edited by DimitarCC, 29 October 2024 - 19:44.

[Dimitrij]

Stream service,infobar.

    <widget backgroundColor="#00152f44" font="Regular;24" foregroundColor="#00dedede" halign="right" position="1070,34" render="Label" size="70,33" source="session.CurrentService" transparent="1" zPosition="1">
      <convert type="ServiceInfo">Framerate</convert>
    </widget>

 

[Dimitrij]

DimitarCC

 

Maybe problem this?

 

 

https://github.com/O...74ac2d7a8cR2152

 

Simple add

			if (hasChanges)
			{
				eTrace("[eServiceMP3] audio or subtitle stream difference -- re enumerating");
				m_audioStreams.clear();
				m_subtitleStreams.clear();
				std::copy(audioStreams_temp.begin(), audioStreams_temp.end(), back_inserter(m_audioStreams));
				std::copy(subtitleStreams_temp.begin(), subtitleStreams_temp.end(), back_inserter(m_subtitleStreams));
				eTrace("[eServiceMP3] evUpdatedInfo called for audiosubs");
				m_event((iPlayableService*)this, evUpdatedInfo);
			}
+			else
+				m_event((iPlayableService*)this, evUser+15);

 

[DimitarCC]

Hmm that should have nothing to do with refreshrate in my opinion.... I cant understand how that can stop showing suddently...

[Dimitrij]

skin PLi-FullNightHD

lower right corner N/A

press play/pause key --->fps show

Attached Files

•  skin_templates.zip   3.54KB   1 downloads

[Dimitrij]

Hmm that should have nothing to do with refreshrate in my opinion.... I cant understand how that can stop showing suddently...

And?

[DimitarCC]

Well i would use the attached ServiceInfo.py.....

And that parameters should not be got from service information but from drivers.

Often service information doesn't report them right.

Attached Files

•  ServiceInfo.py   12.33KB   2 downloads

[Dimitrij]

 

Well i would use the attached ServiceInfo.py.....

And that parameters should not be got from service information but from drivers.

Often service information doesn't report them right.

 

I agree that this option may work, but it will not be accepted in OpenPLi, since it is a workaround.

 

Just add this code

			if (hasChanges)
			{
				eTrace("[eServiceMP3] audio or subtitle stream difference -- re enumerating");
				m_audioStreams.clear();
				m_subtitleStreams.clear();
				std::copy(audioStreams_temp.begin(), audioStreams_temp.end(), back_inserter(m_audioStreams));
				std::copy(subtitleStreams_temp.begin(), subtitleStreams_temp.end(), back_inserter(m_subtitleStreams));
				eTrace("[eServiceMP3] evUpdatedInfo called for audiosubs");
				m_event((iPlayableService*)this, evUpdatedInfo);
			}
+			else
+				m_event((iPlayableService*)this, evUser+15);