29 replies to this topic

[ian1095]

is it possible for you to revert the last changes to the infobar please,because they are causing havoc with plugins such as mediaportal and media info.

 

these plugins no longer function and ive had to reflash to a backup before the removal of the simple mediaplayer from the infobar.pyo

 

ive tried adding the infobar.py from before the changes to the latest update,but this prevents the box from booting.

 

why have you removed this ? stating in the commits that its obsolete and no longer used when obviously it is !

 

so for the moment i cannot update the image until this is fixed,and neither can anyone else who uses these two very popular plugins.

 

Ian.

Edited by ian1095, 25 January 2014 - 11:16.

[ian1095]

sorry

 

SimpleEventView not simple mediaplayer.

 

i cant edit my first post to correct this.

 

Ian.

Edited by ian1095, 25 January 2014 - 11:22.

[ian1095]

ok ive fixed this myself for now.

 

ive had to decompile the infobar.pyo and InfoBarGenerics.pyo into py files from before the latest changes,and send these py files over to screens,so these latest changes cannot be added to my image during an online update.

 

as soon as you give conformation of reverting these changes i can then remove these py files.

 

if anyone wants them so they can then do the same as what ive done to fix this issue for now,just ask and i will upload them here.

 

Ian.

Edited by ian1095, 25 January 2014 - 11:38.

[littlesat]

I did search for where simpleeventview was possibly used and i could not find something. That was why i removed this class as it is not required anymore within the movieplayer. I was already prepared and put the removal in one patch.... I will revert this later today.

[ian1095]

thank you.

 

Ian.

[ian1095]

there are still issues associated with these changes but this time in the InfoBar.pyo rather than the InfoBarGenerics.pyo which you have reverted.

 

this is the error being given by certain plugins.

 

Extensions/mediainfo/ (type object 'movieplayer' has no attribute 'openEventView')

 

so im having to edit the InfoBar.py and add the openEventView attribute to the class Movieplayer on line 122 of this py and also im having to make it import

 

from Screens.InfoBarGenerics import InfoBarSimpleEventView

 

this fixes my issues,but it does mean that i have use an InfoBar.py file to stop these changes from being deleted upon every image update,so i will never recieve any future updates to the Infobar

 

ive noticed on several forums people complaining about this issue and asking for a fix.

 

so can you also revert these changes to the InfoBar.pyo file too please ?

 

Ian.
 

Edited by ian1095, 27 January 2014 - 10:05.

[littlesat]

Or ask the auther of the plugin to adapt.... Which plugin does cause this issue?

Edited by littlesat, 27 January 2014 - 10:10.

[ian1095]

personally ive only found it to effect the mediainfo plugin,so to my knowledge thats all im aware of,but there could be others that i just dont use.

 

Ian.

[masterview]

On my Vu+Duo Mediaportal and Enhanced Movie Center is affected.

[littlesat]

Crazy... As i do not want to add this element anymore as it is not required at all anymore...
I suggesr the plugins could better use the improvemens...
What line needs exactly to be added?

Edited by littlesat, 27 January 2014 - 11:57.

[metoo]

I thought EMC functionality is standard inside Openpli?

So why use EMC ? its aheavy plugin especially on vuduo/solo which have a lack of memory?

Edited by metoo, 27 January 2014 - 13:01.

[ian1095]

ok ive just tested your latest revert to the infobar.py and it fixes all the above issues related to the plugins mentioned earlier,so thank you for that revert.

 

however

 

the behaviour of the epg/info button has now changed too and it no longer calls the mediainfo plugin when a stream is being played.

 

ive fixed this by changing the flags from "b" to "m" in the keymap.xml file,although i do understand i will now not be able to use your latest epg changes when using movieplayer.,but this fix will have to do until i can find time to edit the mediainfo plugin itself or wait for the author to do this,but at the moment,as things stand this plugin is now no longer fully compatible with the openpli 4.0 image.

 

my question is,how do i prevent these edits to the keymap.xml from being overwritten upon every online update ?

 

Ian.

[littlesat]

That suggestion is not done... The mediainfo plugin needs to be adapted instead...

[ian1095]

yes i agree.

 

this is just a temp fix for me until i can find time to edit my version of the mediainfo plugin.

 

Ian.

Edited by ian1095, 27 January 2014 - 15:01.

[littlesat]

I can rename a function in movieplayer... So that plugin streals the right stuff... But i think it might be better to adapt the plugin...

[littlesat]

In row 34 of the plugin the new function should be used....

[ian1095]

yes thank you

 

im still trying to establish what the new function is called though on your github.

 

Ian.

Edited by ian1095, 27 January 2014 - 15:52.

[littlesat]

In row 510 of the plugin you have the MoviePlayer function stealer.... Change this to the current situation of InfoBar.py.

[ian1095]

i think the problem here is that you are looking at a different version of the plugin as im unable to match up the lines youve mentioned so im unable to follow your instructions.

 

this is the 1.2 version im using.

 

Ian.

Attached Files

•  mediainfo.rar   140.61KB   1 downloads

[littlesat]

I took the version as avsilable from our third party feeds...

Edited by littlesat, 27 January 2014 - 18:39.