61 replies to this topic

[littlesat]

Dima, what is the actual difference from you suggested patch...?

[Dimitrij]

Dima, what is the actual difference from you suggested patch...?

Value "Disabled" will be removed for  config.usage.frontend_priority

This value is there by mistake.

Edited by Dima73, 3 March 2014 - 10:43.

[littlesat]

i do not see that in this patch suggestion... Disabled and Auto should be still in rec_nims.... I suggest it is better to remove auto and add disabled... It makes no difference you only add an extra variable....

 

 

 nims = [("-1", _("auto"))]
for x in nimmanager.nim_slots:
nims.append((str(x.slot), x.getSlotName()))
config.usage.frontend_priority = ConfigSelection(default = "-1", choices = nims)
+ rec_nims = nims
- nims.append(("-2", _("Disabled")))
+ rec_nims.append(("-2", _("Disabled")))
- config.usage.recording_frontend_priority = ConfigSelection(default = "-2", choices = nims)
+ config.usage.recording_frontend_priority = ConfigSelection(default = "-2", choices = rec_nims)
config.misc.disable_background_scan = ConfigYesNo(default = False)

Edited by littlesat, 3 March 2014 - 15:13.

[Huevos]

Dima, what is the actual difference from you suggested patch...?

Value "Disabled" will be removed for  config.usage.frontend_priority

This value is there by mistake.

With the patch, disabled and auto are still there in bot the customise and recordings screens.

Edited by Huevos, 3 March 2014 - 17:19.

[Dimitrij]

littlesat

Sorry to mislead without checking patch.

Strange effect .
Right to be so:

	nims = [("-1", _("auto"))]
+	rec_nims = [("-2", _("Disabled")), ("-1", _("auto"))]
	for x in nimmanager.nim_slots:
		nims.append((str(x.slot), x.getSlotName()))
-		rec_nims.append((str(x.slot), x.getSlotName()))
	config.usage.frontend_priority = ConfigSelection(default = "-1", choices = nims)
-	rec_nims = nims
-	rec_nims.insert(0,("-2", _("Disabled")))
	config.usage.recording_frontend_priority = ConfigSelection(default = "-2", choices = rec_nims)
	config.misc.disable_background_scan = ConfigYesNo(default = False)

[littlesat]

I even do not understand why you need two variables.... As far I see no real changes....

[Huevos]

Dima, with the current patch...

 

In customise I have: Auto, tuner A, tuner B, tuner C, tuner D, & tuner E, and

in Recording I just have: Disabled & Auto.

 

I'm sure that is not what you intended.

[Dimitrij]

Dima, with the current patch...

 

In customise I have: Auto, tuner A, tuner B, tuner C, tuner D, & tuner E, and

in Recording I just have: Disabled & Auto.

 

I'm sure that is not what you intended.

Sorry, wrong.
as follows:

	nims = [("-1", _("auto"))]
+	rec_nims = [("-2", _("Disabled")), ("-1", _("auto"))]
	for x in nimmanager.nim_slots:
		nims.append((str(x.slot), x.getSlotName()))
+		rec_nims.append((str(x.slot), x.getSlotName()))
	config.usage.frontend_priority = ConfigSelection(default = "-1", choices = nims)
-	rec_nims = nims
-	rec_nims.insert(0,("-2", _("Disabled")))
	config.usage.recording_frontend_priority = ConfigSelection(default = "-2", choices = rec_nims)
	config.misc.disable_background_scan = ConfigYesNo(default = False)

[Dimitrij]

littlesat

thank you

[littlesat]

But I did it different, without using an extra variable..This is indeed a clasic "stinky" from python...

[Huevos]

Latest version works as expected for me.

 

@Littlesat, if you only use one variable you don't have the choice to disable this setting.

[macnuts]

My previous post was ignored  but it is important for me to understand how this new "preferred tuner for recordings" work. I recognize the importance of this new functionality for some tuner configurations but I need the "old" behaviour, before the patch. Does "auto" for "preferred tuner for recordings" mean it? If so I would recommend that feature have non breaking default:

- set default to -1 ("auto") not -2 ("disabled")  (let me know if "auto" means something else PLEASE)

 

And another cosmetic change: "Disabled" string should start with lower case ("disabled") to have it consistent with "auto" (might be easier for translators).

 

Regards.

Edited by macnuts, 4 March 2014 - 15:00.

[littlesat]

The default -2 should be the same as the previous behavior.

[macnuts]

Thank you littlesat.

 

I did not understand post #37 correctly then:

"disabled" same as "Preferred tuner" option

I have A-E tuners where C-E are DVB-T, the same configuration, I have T/S/C tuner order and C as preferred. When I set up recording on DVB-T channel, tuner E is selected (I want it this way for some purpose).

I thought that "disabled" will force C be selected for recordings (judging from quote above).

[Huevos]

- set default to -1 ("auto") not -2 ("disabled")  (let me know if "auto" means something else PLEASE).

Disabled should be default. This means tuner selection is based on the global setting in customise. Auto ignores the settings in customise.

Edited by Huevos, 4 March 2014 - 15:34.

[macnuts]

- set default to -1 ("auto") not -2 ("disabled")  (let me know if "auto" means something else PLEASE).

Disabled should be default. This means the preference is based on the settings in customise. Auto ignores the settings in customise.

 What is "customise" in this context? Sorry for digging it, but I would not like find some day that recording failed due to my bad configuration...

Edited by macnuts, 4 March 2014 - 15:32.

[littlesat]

Possibly we should consider to move this config to custimize

[Huevos]

This means the preference is based on the settings in customise. Auto ignores the settings in customise.

 What is "customise" in this context?

Menu -> Setup -> System -> Customise -> Preferred tuner.

[Huevos]

Possibly we should consider to move this config to custimize

For me it makes more sense in Recording settings, because that is what it affects.

[macnuts]

Thank you all for clarifying.

 

Just for a record, I did some tests and with "disabled" tuner C is selected, with "auto" tuner D is selected, so "disabled" is not how it worked before the patch. In other configurations it might be more close to it than "auto" though. (See post #54 above on this page for my tuners configuration and pre-patch behaviour).

 

Good luck with your image development! Regards.

Edited by macnuts, 4 March 2014 - 15:48.