69 replies to this topic

[blzr]

1. timezone files are correct and complete in OpenPLi image (even despite you don't have separate file for each city as in your desktop distribution)
2. timezone.xml needs some adjustments, but, of course, zone must correspond the actual file in /usr/share/zoneinfo/ and can't refer to a nonexistent file, like Riga, Samara, Helsinki, etc

So I would suggest to revert all recent changes in timezone.xml for now,
and when I have some time this week (hopefully), I offer to revise timezone.xml and provide adjusted one for commit

[Taapat]

Exactly while in /usr/share/zoneinfo not added the required files from tzdata, any changes in timezone.xml should not be made.
While this has not been done you must revert all changes.

[Erik Slagter]

1. timezone files are correct and complete in OpenPLi image (even despite you don't have separate file for each city as in your desktop distribution)
2. timezone.xml needs some adjustments, but, of course, zone must correspond the actual file in /usr/share/zoneinfo/ and can't refer to a nonexistent file, like Riga, Samara, Helsinki, etc

So I would suggest to revert all recent changes in timezone.xml for now,
and when I have some time this week (hopefully), I offer to revise timezone.xml and provide adjusted one for commit

I will revert everything, except for two obvious typing mistakes.

[Erik Slagter]

Exactly while in /usr/share/zoneinfo not added the required files from tzdata, any changes in timezone.xml should not be made.
While this has not been done you must revert all changes.

As mentioned before, the tzdata package (version: 2015a, so it's brand new) is maintained by OpenEmbedded, not by us. As such it's used by hundreds of projects which apparently don't have a problem with it.

 

The only thing I can offer is to add the whole lot of cities explicitly and make them point to existing entries, like Istanbul. The end user won't notice. I will apply a patch for that if it's presented.

[blzr]

ok, test version that includes zone adjustments requested in this thread (Algiers, Samara, Yerevan) + some more outdated entries spotted:
 

diff --git a/data/timezone.xml b/data/timezone.xml
index db2bb0f..c08a138 100644
--- a/data/timezone.xml
+++ b/data/timezone.xml
@@ -16,7 +16,7 @@
 	<zone name="(GMT-05:00) Bogota, Lima, Quito" zone="America/Bogota" />
 	<zone name="(GMT-05:00) Eastern Time (Us and Canada)" zone="EST5EDT" />
 	<zone name="(GMT-05:00) Indiana (East)" zone="EST" />
-	<zone name="(GMT-04:00) Atlantic Time (Canada)" zone="Canada/Newfoundland" />
+	<zone name="(GMT-04:00) Atlantic Time (Canada)" zone="America/Halifax" />
 	<zone name="(GMT-04:00) Caracas, La Paz" zone="America/Caracas" />
 	<zone name="(GMT-04:00) Santiago" zone="America/Santiago" />
 	<zone name="(GMT-04:00) Brazil, West" zone="Brazil/West" />
@@ -36,7 +36,8 @@
 	<zone name="(GMT+01:00) Brussels, Copenhagen, Madrid, Paris" zone="CET" />
 	<zone name="(GMT+01:00) Sarajevo, Skopje, Warsaw, Zagreb" zone="CET" />
 	<zone name="(GMT+01:00) West Central Africa" zone="Africa/Kinshasa" />
-	<zone name="(GMT+02:00) Athens, Istanbul, Minsk" zone="Europe/Istanbul" />
+	<zone name="(GMT+01:00) Algiers, Tunis" zone="Africa/Kinshasa" />
+	<zone name="(GMT+02:00) Athens, Istanbul" zone="Europe/Istanbul" />
 	<zone name="(GMT+02:00) Bucharest" zone="Europe/Istanbul" />
 	<zone name="(GMT+02:00) Harare, Pretoria" zone="Africa/Harare" />
 	<zone name="(GMT+02:00) Helsinki, Kyiv, Sofia" zone="Europe/Istanbul" />
@@ -44,24 +45,28 @@
 	<zone name="(GMT+02:00) Jerusalem" zone="Asia/Jerusalem" />
 	<zone name="(GMT+03:00) Baghdad" zone="Asia/Baghdad" />
 	<zone name="(GMT+03:00) Kuwait, Riyadh" zone="Asia/Riyadh" />
+	<zone name="(GMT+03:00) Minsk" zone="Europe/Moscow" />
 	<zone name="(GMT+03:00) Moscow, St. Petersburg, Volgograd" zone="Europe/Moscow" />
 	<zone name="(GMT+03:00) Nairobi" zone="Africa/Nairobi" />
 	<zone name="(GMT+03:30) Tehran" zone="Asia/Tehran" />
 	<zone name="(GMT+04:00) Abu Dhabi, Muscat" zone="Asia/Muscat" />
-	<zone name="(GMT+04:00) Baku, Tbilisi, Yerevan" zone="Asia/Baku" />
+	<zone name="(GMT+04:00) Tbilisi, Yerevan" zone="Asia/Muscat" />
+	<zone name="(GMT+04:00) Samara" zone="Asia/Muscat" />
+	<zone name="(GMT+04:00) Baku" zone="Asia/Baku" />
 	<zone name="(GMT+04:30) Kabul" zone="Asia/Kabul" />
-	<zone name="(GMT+05:00) Ekaterinburg" zone="Asia/Omsk" />
+	<zone name="(GMT+05:00) Ekaterinburg" zone="Asia/Tashkent" />
 	<zone name="(GMT+05:00) Islamabad, Karachi, Tashkent" zone="Asia/Tashkent" />
 	<zone name="(GMT+05:30) Chennai, Kolkata, Mumbai, New Delhi" zone="Asia/Calcutta" />
 	<zone name="(GMT+05:45) Kathmandu" zone="Asia/Katmandu" />
-	<zone name="(GMT+06:00) Almaty, Novosibirsk" zone="Asia/Almaty" />
-	<zone name="(GMT+06:00) Astana, Dhaka" zone="Asia/Dhaka" />
+	<zone name="(GMT+06:00) Almaty, Astana" zone="Asia/Almaty" />
+	<zone name="(GMT+06:00) Novosibirsk" zone="Asia/Omsk" />
+	<zone name="(GMT+06:00) Dhaka" zone="Asia/Dhaka" />
 	<zone name="(GMT+06:00) Sri Jayawardenepura" zone="Asia/Colombo" />
 	<zone name="(GMT+06:30) Rangoon" zone="Asia/Rangoon" />
 	<zone name="(GMT+07:00) Bangkok, Hanoi, Jakarta" zone="Asia/Bangkok" />

any feedback welcome (esp. from users from changed timezones
(to test - replace /usr/share/enigma2/timezone.xml with the attached)

known issues: Kaliningrad, Ulaan Bataar , and Egypt (after May 1st) - have to wait for OE update...

Attached Files

•  timezone.xml   5.63KB   8 downloads

Edited by blzr, 20 April 2015 - 19:25.

[crazyyyk]

May be it is time to get rid of timezone.xml? Just use /usr/share/zoneinfo/ files?

Nowhere else (nix systems) use this timezone.xml file.

Edited by crazyyyk, 21 April 2015 - 04:12.

[zeros]

Today morning after update there was still three hours to Estonian time, I do not know, if turning back was already in force or not.

[blzr]

May be it is time to get rid of timezone.xml? Just use /usr/share/zoneinfo/ files?
Nowhere else (nix systems) use this timezone.xml file.

probably doable (I'm not a dev though )
but in this case I'm afraid you need to have full blown tzdata packages for all regions installed (which cost you ~1Mb of flash, for modern boxes it'd be negligible, but for some older...)

(unless there would be some smart mechanism of installation only needed timezone package implemented...)

[zeros]

I confirm that it is now OK after return (I upgraded just from a moment ago).

[Erik Slagter]

ok, test version that includes zone adjustments requested in this thread (Algiers, Samara, Yerevan) + some more outdated entries spotted:
 

diff --git a/data/timezone.xml b/data/timezone.xml
index db2bb0f..c08a138 100644
--- a/data/timezone.xml
+++ b/data/timezone.xml
@@ -16,7 +16,7 @@
 	<zone name="(GMT-05:00) Bogota, Lima, Quito" zone="America/Bogota" />
 	<zone name="(GMT-05:00) Eastern Time (Us and Canada)" zone="EST5EDT" />
 	<zone name="(GMT-05:00) Indiana (East)" zone="EST" />
-	<zone name="(GMT-04:00) Atlantic Time (Canada)" zone="Canada/Newfoundland" />
+	<zone name="(GMT-04:00) Atlantic Time (Canada)" zone="America/Halifax" />
 	<zone name="(GMT-04:00) Caracas, La Paz" zone="America/Caracas" />
 	<zone name="(GMT-04:00) Santiago" zone="America/Santiago" />
 	<zone name="(GMT-04:00) Brazil, West" zone="Brazil/West" />
@@ -36,7 +36,8 @@
 	<zone name="(GMT+01:00) Brussels, Copenhagen, Madrid, Paris" zone="CET" />
 	<zone name="(GMT+01:00) Sarajevo, Skopje, Warsaw, Zagreb" zone="CET" />
 	<zone name="(GMT+01:00) West Central Africa" zone="Africa/Kinshasa" />
-	<zone name="(GMT+02:00) Athens, Istanbul, Minsk" zone="Europe/Istanbul" />
+	<zone name="(GMT+01:00) Algiers, Tunis" zone="Africa/Kinshasa" />
+	<zone name="(GMT+02:00) Athens, Istanbul" zone="Europe/Istanbul" />
 	<zone name="(GMT+02:00) Bucharest" zone="Europe/Istanbul" />
 	<zone name="(GMT+02:00) Harare, Pretoria" zone="Africa/Harare" />
 	<zone name="(GMT+02:00) Helsinki, Kyiv, Sofia" zone="Europe/Istanbul" />
@@ -44,24 +45,28 @@
 	<zone name="(GMT+02:00) Jerusalem" zone="Asia/Jerusalem" />
 	<zone name="(GMT+03:00) Baghdad" zone="Asia/Baghdad" />
 	<zone name="(GMT+03:00) Kuwait, Riyadh" zone="Asia/Riyadh" />
+	<zone name="(GMT+03:00) Minsk" zone="Europe/Moscow" />
 	<zone name="(GMT+03:00) Moscow, St. Petersburg, Volgograd" zone="Europe/Moscow" />
 	<zone name="(GMT+03:00) Nairobi" zone="Africa/Nairobi" />
 	<zone name="(GMT+03:30) Tehran" zone="Asia/Tehran" />
 	<zone name="(GMT+04:00) Abu Dhabi, Muscat" zone="Asia/Muscat" />
-	<zone name="(GMT+04:00) Baku, Tbilisi, Yerevan" zone="Asia/Baku" />
+	<zone name="(GMT+04:00) Tbilisi, Yerevan" zone="Asia/Muscat" />
+	<zone name="(GMT+04:00) Samara" zone="Asia/Muscat" />
+	<zone name="(GMT+04:00) Baku" zone="Asia/Baku" />
 	<zone name="(GMT+04:30) Kabul" zone="Asia/Kabul" />
-	<zone name="(GMT+05:00) Ekaterinburg" zone="Asia/Omsk" />
+	<zone name="(GMT+05:00) Ekaterinburg" zone="Asia/Tashkent" />
 	<zone name="(GMT+05:00) Islamabad, Karachi, Tashkent" zone="Asia/Tashkent" />
 	<zone name="(GMT+05:30) Chennai, Kolkata, Mumbai, New Delhi" zone="Asia/Calcutta" />
 	<zone name="(GMT+05:45) Kathmandu" zone="Asia/Katmandu" />
-	<zone name="(GMT+06:00) Almaty, Novosibirsk" zone="Asia/Almaty" />
-	<zone name="(GMT+06:00) Astana, Dhaka" zone="Asia/Dhaka" />
+	<zone name="(GMT+06:00) Almaty, Astana" zone="Asia/Almaty" />
+	<zone name="(GMT+06:00) Novosibirsk" zone="Asia/Omsk" />
+	<zone name="(GMT+06:00) Dhaka" zone="Asia/Dhaka" />
 	<zone name="(GMT+06:00) Sri Jayawardenepura" zone="Asia/Colombo" />
 	<zone name="(GMT+06:30) Rangoon" zone="Asia/Rangoon" />
 	<zone name="(GMT+07:00) Bangkok, Hanoi, Jakarta" zone="Asia/Bangkok" />

any feedback welcome (esp. from users from changed timezones
(to test - replace /usr/share/enigma2/timezone.xml with the attached)

known issues: Kaliningrad, Ulaan Bataar , and Egypt (after May 1st) - have to wait for OE update...

 

Applied. Thanks!