120 replies to this topic

[Taapat]

@nikolasi please read what thawtes write.

 

The reason is not in the name.
He has a file Sintel-Bluray.iso which is located in the folder /media/hdd/bluray.

Without non standard symbols.

Edited by Taapat, 9 March 2016 - 09:02.

[Taapat]

Littlesat thanks!

I see that the plugin is added to the feed and I do not need to offer the latest versions here.

[Rob van der Does]

As the plugin apparently works fine now (thanks for that; I can't test atm), I suggest to embed this functionality in E2 instead of optional functionality via a plugin. Exactly the same as has been done ages ago for playing a DVD (-ISO).

[Taapat]

I agree that the best solution would be to embed this functionality in enigma.

Only, as I wrote before, I think that in such a case, the best would be to create a complete bluray support in enigma with libbluray library.
I'm afraid that I will not be able to do this.

Plugin currently only read titles and returns the corresponding m2ts file name to enigma player.

[littlesat]

Littlesat thanks!

I see that the plugin is added to the feed and I do not need to offer the latest versions here.

->

That was why I did it ...

First develop it as a plugin and when it is fine we should consider to embed it to the image... Step-by-Step...

Just a question as I did not look in the deep details... How do you see if the iso is a DVD, BlueRay or something else??? At this moment ISO = opened as DVD...

[Taapat]

I steals functions gotFilename and itemSelectedCheckTimeshiftCallback in MovieSelection: https://github.com/T...ngeFunctions.py

 

But to avoid problems when you change the code, I not change this functions.
I am execute my code, and if blurey test fails, call the original function.

 

The best would be add this my code in MovieSelection.
But before doing so, I would like to hear from users that everything is working well.

Edited by Taapat, 9 March 2016 - 14:49.

[littlesat]

 steals functions gotFilename and itemSelectedCheckTimeshiftCallback in MovieSelection:

-> 

Then I prefer a modification in MovieSelection... So you do not need to steal these functions anymore... But how does the BR check work? (is this a quick check????) Indeed it sounds better to migrate this part in E2...

We still can go for finetuning it plugin wise and once the plugin is perfect migrate the stuff...

Edited by littlesat, 9 March 2016 - 16:49.

[littlesat]

Me again...

 

Why not adapt it already to E2... and check for if blueray plugin exists try to check for blue ray... (by calling the plugin....)

[thawtes]

@thawtes if you are interested, maybe you can check this. Change the file in the plugin folder, restart enigma and check how now works with iso. For test I added a 2 second delay after iso mount.

 

@Taapat yes yes yes

 

direct iso file press OK and perfect workkkk

 

with you Attached File  ChangeFunctions.py

 

thank you cool work...

 

I continue to test...

 

what's next now? disc menu   hehe

Edited by thawtes, 9 March 2016 - 21:50.

[Taapat]

@thawtes and now please check this file.

Attached Files

•  ChangeFunctions.py   3.08KB   30 downloads

[Taapat]

@littlesat maybe first I'll try to fix the mount problem on some receivers, and then propose changes in enigma.
You not always pay attention to the pull requests .

 

Bluray folder test is relatively quick. It is a simple folder structure check in the same way as is for a DVD.

To check and used the iso, first it must be mount. This is a little longer, but it has to be done only at the moment when pressed ok on the iso file. So it can not be felt if it's not buray and after is played as a DVD.

[littlesat]

Good plan.... Step by step....

[thawtes]

@thawtes and now please check this file.

 

this also works no problem (new attached ChangeFunctions.py)

 

what is the difference between the current and the previous versions?

 

but I noticed that when I run iso first DVDPlayer worked but the film did not play.
Then I tried again, this time made out was functioning normally.

 

rhis event is made only once...

[littlesat]

In the new version there is a delay added to allow the BR to mount... (not an ideal solution but at least intended to investigate if mount time is related to an issue).

[Taapat]

Not exactly.

Delay are in both files.
In first I use the sleep that is simple for the code, but bad for the code style.
In the second instead of sleep I using eTimer.

Delay is used only in the case if bluray iso test file. In that case, I am waiting 2 seconds and try to test a second time.

[thawtes]

now everything is working great ..

[thawtes]

https://yadi.sk/d/D0iyuPUTpyZSy

now without Crash issues a warning that the name of the movie is not true

 

nikolasi plugin fixing ?

[Taapat]

I add pull reuests to add plugin support in MovieSelection:

https://github.com/O...nigma2/pull/223

https://github.com/O...oe-core/pull/49

 

Please use both pull reuests in enigma and openpli-oe-core simultaneously.

Edited by Taapat, 13 March 2016 - 19:06.

[Erik Slagter]

It seems they are merged by Littlesat?

[Taapat]

Yes, now they are merged, thank you!

 

As I understand the next step could be to port the library C code to C++, and put it somewhere in the enigma.

Move plugin code to the screen in enigma as it is done with DVD.

Edited by Taapat, 14 March 2016 - 19:26.