276 replies to this topic

[Dimitrij]

void eDVBScan::insertInto(iDVBChannelList *db, bool backgroundscanresult)
{
	if (m_flags & scanRemoveServices)
	{
		bool clearTerrestrial=false;
		bool clearCable=false;
		std::set<unsigned int> scanned_sat_positions;

		for (std::map<eServiceReferenceDVB, ePtr<eDVBService> >::const_iterator
			service(m_new_services.begin()); service != m_new_services.end(); ++service)
		{
			ePtr<eDVBService> dvb_service;
			if (!db->getService(service->first, dvb_service))
			{
				if (dvb_service->m_flags & eDVBService::dxDontshow)
					service->second->m_flags |= eDVBService::dxDontshow;
+				if (dvb_service->m_flags & eDVBService::dxHideVBI)
+					service->second->m_flags |= eDVBService::dxHideVBI;
			}
		}

scan.cpp

[littlesat]

This does just put the flag on ANY scanned service.... I'm afraid also not done....

[littlesat]

It's 0.28 % what you're missing.... But still the solution with the 'sjitty' Q&D plugin is 'struisvogelpolitiek'... and when you read it right it is more then about just VBI here...

Edited by littlesat, 27 September 2018 - 10:01.

[Rob van der Does]

It's 0.28 % what you're missing....

No: it's 0,185% and I I'm not missing that as that's invisible.

Edited by Rob van der Does, 27 September 2018 - 10:07.

[Pr2]

@littlesat,

 

You take my last 2 posts with the online DB to know if a channel needs the hide VBI and the other one with hash on channel name at 1st degree, really?

Sorry this was only humours looking for "state of the art" and complex solution for this very simple request. Please look at the end of the sentences I add a smiley.

 

About the picture lost, taking into consideration a Full HD picture:

 

1920 * 1080 = 2073600 pixels.

 

Since we suppress 2 lines: 2 * 1920 = 3840 pixels lost (what a shame!)

 

So  3840 / 2073600  =  0,001851851851852  = 0,18 % of the image is lost.

 

I must be crazy by guess what I can really live with this picture lost on every channels that I watch.

 

Please explain us your computation method? Because perhaps that if it is really 0,28% I can change my mind and you will finally convince me to use the channel per channel approach.   (look there is a smiley here too)

 

And please stop writing the the Mrvica plugin is Q&D (quick and dirty), this plugin is the only one that perform what normal end-users are asking you.

By the way I am still looking where I lose information in the skin with this plugin, so far no success but I continue my research.

 

Pr2

[ims]

Why so complicated ?   n/1080*100

[Robinson]

So  3840 / 2073600  =  0,001851851851852  = 0,18 % of the image is lost.

 

Which is really nothing, particularly if you compare it with overscan feature, which for some TV's is impossible to switch off.

Edited by Robinson, 27 September 2018 - 14:24.

[littlesat]

On 1920x1080 skins 3 lines are hidden as far I know.... 2 does not cover all the VBI lines...

[littlesat]

self.skin = """<screen position="0,0" size="%s,%s" flags="wfNoBorder" zPosition="1"/>""" % (getDesktop(0).size().width(), getDesktop(0).size().height() / 360 + 1)

[littlesat]

See previous post... 1080/360 + 1 = 4 lines are covered 4/1080 * 100 = 0.37 % So even one more line covered as I remembered...

 

But having an exact percentage is not the clue!!!

 

The issue is that when you clear services before a scan the flags (so also the VBI line covering flag) and prios are gone... - For this 'issue' we should find a solution which solves also other stuf that irritates not only me in E2 for a long long time...

 

At this moment I still have the feeling a delete 'flag' is a way that should work. Instead of deleting the services just set a flag... and during the scan when the service already exists clear that flags so we also keep the current prio's and other flags.... And when we (re)start enigma2 ignore/drop services that have the flag during parsing the lamedb... This means as long you are within an enigma2 session the flags are kept after you perform a new scan - think about the scan was not successfully due to some fappy parameters  (Then we also need some kind of 'clean transponders' after everything is parsed that deletes all the transponders without a service assigned to it in lamedb). Then we also avoid having a seperate flags/prio flag file (that grows forever).

Edited by littlesat, 27 September 2018 - 14:44.

[WanWizard]

Let's focus on the fact there are two issues here:

• the generic issue of data in a flat file (lamedb) of which the integrity can not be guaranteed due to (internal and external) manipulations of said file
• the issue that some people in some countries have now with lots of channels showing VBI lines

The first needs to be solved but will not be solved overnight, the second one can be worked around with an option to simply blank the VBI on all channels. If we don't want that in the image, I can understand that (no workarounds), but having a workaround in a plugin that solves the problem for these people is fine by me.

[littlesat]

The plugin should even be better when it only adds the cover on SD channels... or do we also have HD channels with VBI lines? But then we get into a problem that as soon the stream starts we know the service is HD or SD... so there is a delay you can still see these lines shortly...

This saying we can also add a feature into OpenPLi;s E2 that covers these lines on all SD channels... 

Edited by littlesat, 27 September 2018 - 14:57.

[WanWizard]

I only see them sometimes on HD channels, but that is because they patch some other signal through. Like when you watch the news, and they switch to a reporter on site. But that is only a short while, it doesn't bother me.

 

Otherwise I only see it on a few "low-budget" SD channels, but I don't know the situation in France.

[Pr2]

If you don't want workaround in the code then we should never accept this:

 

https://github.com/O...c62317670a7fc5d

 

This is not a solution this is a work-around!

If we start a remote stream exactely at the same time as people watching TV zap then this fix is ineffective.

 

@Littlesat,

 

Please understand that we also have the dotted line on HD channels!  When they decide to broadcast and old TV show or program we also saw sometimes those dotted lines.

Make this option available globally for people that want to turn it on, you don't have to judge if we should or not, this is our problem.

This is just a parameter to add and a "or" to set in the code to hide the line when individually set or globally set.

This is 5 minutes development for you and you will please OpenPLi end-users, isn't it the goal of all your work to improve OpenPLi and make it more user friendly for end-users?

[WanWizard]

Agreed.

 

That workaround needs to be removed as soon as we (I guess Erik?) had time to look at the code, as Enigma is clearly not Unicable/JESS ready at this point.

[littlesat]

I committed that one as it also solved an issue here when I start two non jess recordings that start at the same time...uuuh then here also I could have diseqc at the same time... and indeed it is a temporary ‘thing’

[Pr2]

And my issue here is to have hide vbi lines a one-shot permanant choice... can you also please "work-around" something for us?

[WanWizard]

I thought the plugin did that? And if that works, why does the image need a built-in workaround?

[Pr2]

Because it is stupid to need to use a plugin for something that is already build in OpenPLi and just need a flag to trigger it.

[littlesat]

Use the plugin or wait or help ti create a real solution...

Edited by littlesat, 27 September 2018 - 22:14.