22 replies to this topic

[HES OBUP]

Hi @all,

 

I always get the error switching to an empty service in the plugin GraphMultiEpg:

  File "/usr/lib/enigma2/python/Plugins/Extensions/GraphMultiEPG/GraphMultiEpg.py", line 540, in buildEntry
  TypeError: 'int' object has no attribute '__getitem__'

The same error occurs in line 536. 

 

The bug can be fixed:

1. Configuration "Überspringe leere Sender" (EN 'Skip empty services' ) set to 'Ja'
2. validate variable 'rec' ( source 'GraphMultiEpg.py' ) in line 536 && 540 != empty

Origin:

if rec is not None and rec[1][-1] in (2, 12, 17, 27):

fixed:

if rec is not None and len(rec) > 0 and rec[1][-1] in (2, 12, 17, 27):

Kind regards

 

Olaf

[WanWizard]

Thanks Olaf,

 

@littlesat, something for you to check?

[littlesat]

I hate those stupid s note None stuff.... Try if just removing is not None also solves the issue, which is less complicated....and even much better.... No len check required....

Edited by littlesat, 15 July 2017 - 10:50.

[WanWizard]

If "rec" is an "int" (what value then, and why suddenly an int?), and you remove that, wouldn't this fail too?

if rec[1][-1] in (2, 12, 17, 27):

[littlesat]

I meant

If rec and rec[1][-1] in .......

Just to remove the is not None....

In this case it is almost the same as

If rec is not None and len(rec)>0 and rec[1][-1] in....

Edited by littlesat, 15 July 2017 - 11:10.

[WanWizard]

Ah, ok.

 

Still begs the question where and why rec is suddenly an int (I assume a zero) instead of the expected type. So I think the root cause lies elsewhere.

[HES OBUP]

@littlesat:

If rec and rec[1][-1] in .......

changing works on my STB

 

@WanWizard:

 

source 'RecordTimer.py', method 'isInTimer' >> return 'returnValue':

def isInTimer(self, eventid, begin, duration, service):
    returnValue = None

...

if time_match:
  if type in (2,7,12,17,22,27):
	# When full recording do not look further
	returnValue = (time_match, [type])
	break
  elif returnValue:
	if type not in returnValue[1]:
	        returnValue[1].append(type)
	else:
		returnValue = (time_match, [type])

		return returnValue

imo line 1239 is the problem

 

kind  regards

 

Olaf

[littlesat]

The problem is the is not None check.....

I think we still should solve this for 6.0.... Someone needs to push sh it to rc.

Edited by littlesat, 15 July 2017 - 12:32.

[WanWizard]

I don't really agree.

 

I did some debugging:

[wanwizard@catwoman] $ python
Python 2.7.13 (default, May 10 2017, 20:04:28) 
[GCC 6.3.1 20161221 (Red Hat 6.3.1-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> rec = 12
>>> if rec is not None: 
...     rec
... 
12
>>> if rec[1][-1] is not None:
...     rec
... 
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'int' object has no attribute '__getitem__'
>>>

So the problem isn't in the "is not None", the problem is that something is returned on which "rec[1][-1]" doesn't work.

 

However, if I look at the isInTimer() method, returnvalue is returned as either None (no timers present), or a tuple (containing an int and a list of int's). I don't immediately see how that can ever return an int.

[littlesat]

Hold on....

Edited by littlesat, 15 July 2017 - 13:01.

[WanWizard]

If the list is empty, you will get "IndexError: list index out of range". If rec is a tuple without the list (not with an empty list), you will get the "TypeError: 'int' object has no attribute '__getitem__'" error.

 

But if you look at the code, it can't be that the list is empty, there is always at least one "type" in that list, no matter what the value of "type" is.

 

(this is a learning moment for me, I'd like to understand what is going on).

[littlesat]

It shoud return....

 

None

 

-or-

 

(time_match,[type values])

 

The list can't be empty... it is none or time_match with as second value in the tuple a list of types..

 

When I viewed the code or RerordTimer above our Looks different... So I suggest we already solved this issue...

if time_match:
  if type in (2,7,12,17,22,27):
  # When full recording do not look further
    returnValue = (time_match, [type])
    break
  elif returnValue:
    if type not in returnValue[1]:
    returnValue[1].append(type)
  else:
    returnValue = (time_match, [type])

Edited by littlesat, 15 July 2017 - 13:09.

[WanWizard]

That was the conclusion I was getting at as well, something installed that has overwritten RecordTimer.py?

[littlesat]

Yep there are plug-ins that might do this....
So I suppose we do not have a bug?

Edited by littlesat, 15 July 2017 - 13:17.

[WanWizard]

I don't think so, but perhaps Olaf can confirm?

[ims]

Hi @all,

 

I always get the error switching to an empty service in the plugin GraphMultiEpg:

 

Do you think "empty service" as service without EPG ? No problem here...

[HES OBUP]

I've to check the complete installation/setup.

 

First of all, if you - WanWizard and littlesat - think, that's no bug, o.k.

 

I'll examine the whole installation again - plugin , next plugin, and so on.

 

Thanks a lot

 

Olaf

 

P.S.: config set to skip empty services 

 

[HES OBUP]

 

Hi @all,

 

I always get the error switching to an empty service in the plugin GraphMultiEpg:

 

Do you think "empty service" as service without EPG ? No problem here...

 

@ims:

 

yeah

[Abu Baniaz]

If there is a sure/definite way of reproducing the crash, please post step by step instructions.

[WanWizard]

Looking at the code of RecordTimer.py, I can see no way that variable can ever contain either an int, or a tuple with an empty list.

 

So for the moment I don't think it is a bug, but caused by something that got overwritten when you installed some plugin (there are a lot of rubbish and therefore not compatible plugins out there, it is an illusion that all Enigma images are compatible).

 

I am also interested in the way to reproduce this problem.