2740 replies to this topic

[WanWizard]

It's because of the new changes in develop branch regarding model detection for flash image.

 

Did I make a mistake?

[Persian Prince]

I'm not sure but after recent changes we have this error:

File "/usr/lib/enigma2/python/Components/SystemInfo.py", line 3, in <module>
ImportError: No module named HardwareInfo

[arn354]

HardwareInfo.py

def get_machine_name(self)


misses a :

Edited by arn354, 21 April 2018 - 09:38.

[Persian Prince]

Thanks I guess we found it at the same time

https://github.com/O...igma2/pull/1479

[Beeker]

This does work for me.

diff --git a/lib/python/Tools/HardwareInfo.py b/lib/python/Tools/HardwareInfo.py
index 40896b7d0..dea6853bc 100644
--- a/lib/python/Tools/HardwareInfo.py
+++ b/lib/python/Tools/HardwareInfo.py
@@ -75,7 +75,7 @@ class HardwareInfo:
 			return "%s (%s)" % (hw_info.device_model, hw_info.device_version)
 		return hw_info.device_model
 
-	def get_machine_name(self)
+	def get_machine_name(self):
 		# get the reported device model
 		machine = get_device_model()
 		# map Xtrend device models to machine names

Edited by Beeker, 21 April 2018 - 09:45.

[Beeker]

All three at the same time...

[Persian Prince]

Yeah well done

The real question is why travis-ci gives it
a green check?

https://travis-ci.or...um=notification

And sometimes for correct commits it gives red error!

Edited by Persian Prince, 21 April 2018 - 09:53.

[Beeker]

Yes i noticed that also..

 

This commit doesn't break the build. So that's clear.

 

But why travis gives red error sometimes, devtools distro?

[Persian Prince]

Maybe we're looking for errors and travis is looking for us LOL

[WanWizard]

HardwareInfo.py

def get_machine_name(self)


misses a :

 

FCUK.

 

I seem to have a big issue with colon's...  fix pushed.

[Beeker]

Thanks..

 

Yes Python e.g.

else:

Why?

 

Anyway build dm920 and dm900 running....

[WanWizard]

My brain can't keep up with the differences between programming languages anymore.

[maxmazzinghi]

Hello, I had been away from thi s forum for some time and now...I came back and see it's possible to run Openpli on Raspberry 3??!!! Is it real???

But with DVB support??
If this is true I am the happiest man with a satellite dish on the roof!!! :-) :-)

So...can anyone please confirm this great news?

Thank you.

Max.

[Beeker]

Yeah... printf,  cout , Console.WriteLine(

 

 

Build dm920 ready, dm900 in a few minutes.

[Persian Prince]

My brain can't keep up with the differences between programming languages anymore.

Try Hawaii beach with a bottle of champagne and at least 2 completely different close friends

[WanWizard]

Can I send you the bill?   

[athoik]

Travis CI is checking only for C++ and translation errors.

Travis CI is not checking for python runtime errors (Although I have it ready on my GitHub fork).

Also Travis CI is failing to download packages sometimes (apt-get supidness, also I have it ready on my GitHub fork).

[WanWizard]

I'd thought I'd install pep8 so I can use that as linter in my editor. But the first random .py file I loaded and had checked, generated as much errors as it had lines...

 

I have now installed pylint, but even that gives false alarms, i..e

enigma_py_patcher.py:25: [E0001(syntax-error), ] invalid syntax (<string>, line 25)

which is

print "!!! Patch enigma.py line %d\n%s\n%s" %(line, oldstr[:len(oldstr)-1], str)

[starz]

For those who keep asking about other amlogic devices:

I can't fetch kernel sources and PLi's OE isn't recent enough to include latest bitbake features so you have to wait for next PLi update on develop branch.

Still I'm trying to find a way for this problem like changing all kernel recipes for amlogic which uses yocto recipes.

I'm just one person and can't handle all the heavy work.

Yes like engineerkhan15 said, take your time and no problem we'll wait:) thanks a lot for your hard works.

[WanWizard]

Not a success either. If I test it with "python2 pylint" I get:

python2 /usr/bin/pylint --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}"  --reports=n "HardwareInfo.py" (in directory: /data/Development/OpenPLi/0.0-develop/enigma2/lib/python/Tools)
No config file found, using default configuration
************* Module Tools.HardwareInfo
HardwareInfo.py:55: [C0326(bad-whitespace), ] Exactly one space required after assignment
        self.device_hdmi =  self.device_model not in ("dm7025", "dm800", "dm8000")
                         ^
HardwareInfo.py:73: [C0301(line-too-long), ] Line too long (105/100)
HardwareInfo.py:1: [C0103(invalid-name), ] Module name "HardwareInfo" doesn't conform to snake_case naming style
HardwareInfo.py:1: [C0111(missing-docstring), ] Missing module docstring
HardwareInfo.py:3: [C0103(invalid-name), ] Constant name "hw_info" doesn't conform to UPPER_CASE naming style
HardwareInfo.py:5: [C0111(missing-docstring), HardwareInfo] Missing class docstring
HardwareInfo.py:5: [C1001(old-style-class), HardwareInfo] Old-style class defined.
HardwareInfo.py:6: [E0602(undefined-variable), HardwareInfo] Undefined variable '_'
HardwareInfo.py:13: [W0603(global-statement), HardwareInfo.__init__] Using the global statement
HardwareInfo.py:13: [C0103(invalid-name), HardwareInfo.__init__] Constant name "hw_info" doesn't conform to UPPER_CASE naming style
HardwareInfo.py:22: [W0702(bare-except), HardwareInfo.__init__] No exception type(s) specified
HardwareInfo.py:28: [W0702(bare-except), HardwareInfo.__init__] No exception type(s) specified
HardwareInfo.py:34: [W0702(bare-except), HardwareInfo.__init__] No exception type(s) specified
HardwareInfo.py:40: [C0103(invalid-name), HardwareInfo.__init__] Variable name "l" doesn't conform to snake_case naming style
HardwareInfo.py:42: [C0103(invalid-name), HardwareInfo.__init__] Variable name "infoFname" doesn't conform to snake_case naming style
HardwareInfo.py:44: [C0103(invalid-name), HardwareInfo.__init__] Variable name "infoFname" doesn't conform to snake_case naming style
HardwareInfo.py:49: [W0702(bare-except), HardwareInfo.__init__] No exception type(s) specified
HardwareInfo.py:59: [C0111(missing-docstring), HardwareInfo.get_device_name] Missing method docstring
HardwareInfo.py:59: [R0201(no-self-use), HardwareInfo.get_device_name] Method could be a function
HardwareInfo.py:62: [C0111(missing-docstring), HardwareInfo.get_device_model] Missing method docstring
HardwareInfo.py:62: [R0201(no-self-use), HardwareInfo.get_device_model] Method could be a function
HardwareInfo.py:65: [C0111(missing-docstring), HardwareInfo.get_device_version] Missing method docstring
HardwareInfo.py:65: [R0201(no-self-use), HardwareInfo.get_device_version] Method could be a function
HardwareInfo.py:68: [C0111(missing-docstring), HardwareInfo.get_device_revision] Missing method docstring
HardwareInfo.py:68: [R0201(no-self-use), HardwareInfo.get_device_revision] Method could be a function
HardwareInfo.py:71: [C0111(missing-docstring), HardwareInfo.get_device_string] Missing method docstring
HardwareInfo.py:71: [R0201(no-self-use), HardwareInfo.get_device_string] Method could be a function
HardwareInfo.py:78: [C0111(missing-docstring), HardwareInfo.get_machine_name] Missing method docstring
HardwareInfo.py:80: [E0602(undefined-variable), HardwareInfo.get_machine_name] Undefined variable 'get_device_model'
HardwareInfo.py:78: [R0201(no-self-use), HardwareInfo.get_machine_name] Method could be a function
HardwareInfo.py:93: [C0111(missing-docstring), HardwareInfo.has_hdmi] Missing method docstring
HardwareInfo.py:93: [R0201(no-self-use), HardwareInfo.has_hdmi] Method could be a function
-------------------------------------------------------------------
Your code has been rated at 4.12/10 (previous run: -5.44/10, +9.56)
Compilation failed.

And this is after I dealt with all spaces and tabs indentation issues. Is our code this crap, or it the linter this crap?