38 replies to this topic

[blinkosm]

hi.. is there any way to add parentheses in the epg in the channelist ???

 

like  France2 (Roland Garros) you can take a look in the picture .

 

 

Attached Files

•  jo.jpg   98.87KB   5 downloads

[littlesat]

I do not see any France2 in the attached picture...

[blinkosm]

I do not see any France2 in the attached picture...

it was only an exemple ok discovery channel (Fast N Furiuos)  i'm talking about adding eventname between () parentheses because in the openpli i only see like discovery channel Fast N Furiuos without () parentheses

 

[littlesat]

Why should you want these extra two characters that are only taken space?

[WanWizard]

Because it might be easier to read, to see where the channel name stops and the programme name starts?

[blinkosm]

Because it might be easier to read, to see where the channel name stops and the programme name starts?

Yes that's right because sometime it looks like france2 france - ireland rugby and it looks confusing or beinlaliga liga barcelona -sevilla

Edited by blinkosm, 9 September 2018 - 18:19.

[Robinson]

Because it might be easier to read, to see where the channel name stops and the programme name starts?

Unless they are different colour. Like they are in FullNight skin, which I use. In such case extra parentheses would take away 2 characters without any value added.

[WanWizard]

It is all personal experience.

 

The FullNight skin has a similar problem with the selection bar, in which both the channel name and the programme name are in a virtually simular yellow on the same background. 

 

 

Attached Files

•  1_0_19_22E3_80D_2_11A0000_0_0_0_20180909202640.jpg   185.9KB   4 downloads

[blinkosm]

Any idea where is the python file who is responsble for this. serviceinfo.py maybe or it's c++ file ???

[littlesat]

I think keeping the font just white, the epg yellow and just the background gray might look better...... to add () there a code in cpp needs to be changed (in dmm’s image this is currently python stuff... but it slows down performance/speed)

Edited by littlesat, 9 September 2018 - 22:30.

[WanWizard]

In my personal opinion, for FullNight, yes.

 

But that doesn't answer the question of the TS. We don't know what skin is in use, and for all we know the TS could be colour blind and needs the brackets to see the difference clearly...

[blinkosm]

I think keeping the font just white, the epg yellow and just the background gray might look better...... to add () there a code in cpp needs to be changed (in dmm’s image this is currently python stuff... but it slows down performance/speed)

Witch code in cpp ??? So i can build my own image with making a patch in my local recipe

[littlesat]

This cannot be done by the skin as it needs a change in cpp code as extra feature. Currently dmm’s e2 has this in python (slower) they can change this more easily... somI think this is most likely a dmm’s e2 feature. I know this because a few years ago I was trying to do approx the same by moving the service ‘drawer’ to python.
The code need to be changed in servicelist.cpp... and of course to enable/disable it we need also some extra code. And then I don’t think it needs to be set by the skin so we’ll have an additional config... (adding configs is something we do with care as we already have too many)
In short a local change is somehow not done as it needs a change in the e2 binary!

Edited by littlesat, 10 September 2018 - 06:57.

[blinkosm]

This cannot be done by the skin as it needs a change in cpp code as extra feature. Currently dmm’s e2 has this in python (slower) they can change this more easily... somI think this is most likely a dmm’s e2 feature. I know this because a few years ago I was trying to do approx the same by moving the service ‘drawer’ to python.
The code need to be changed in servicelist.cpp... and of course to enable/disable it we need also some extra code. And then I don’t think it needs to be set by the skin so we’ll have an additional config... (adding configs is something we do with care as we already have too many)
In short a local change is somehow not done as it needs a change in the e2 binary!

Thanks for the info. And yes the dmm's image has an option with python code channellistdisplay.py or channellistdisplaysettings.py

Edited by blinkosm, 10 September 2018 - 10:29.

[littlesat]

At least I think we need to keep the selected channel name white to make the differentiation more clear.....

The () uses place so less available space for EPG data. But it can me made when the 'team' wants it... but it 'costs' an extra ui-config....

[blinkosm]

hi li

 

At least I think we need to keep the selected channel name white to make the differentiation more clear.....

The () uses place so less available space for EPG data. But it can me made when the 'team' wants it... but it 'costs' an extra ui-config....

yes i understand but i don't wanna to be a global change as the team don't want it but i want to build my own image and make a patch for me only in my own image . by the way i don't find servicelist.cpp i only find service.cpp and servicedvb.cpp any idea witch file is the target??

[littlesat]

Sorry it was listboxservice.cpp

 

https://github.com/O...tboxservice.cpp

 

Its within the function void eListboxServiceContent::paint

 

below line 786 the event info is added to the service list...

 

In line 793 the event text is derived... here you should add the "(" before and a ")" after a string (when the config option is enabled)...

 

When doing this please do not only do it by yourself... Please try to get it 'in'...

 

Mmmm and when I look to the code why to 'they' first put the event text in 'name' and then in 'text' ?

 

P.S. In DMMs E2 the painter is a swig to python code... (slower, but for non C++ programmers better adaptable)

                           case celServiceInfo:
                                  {
                                        if ( isPlayable && service_info && !service_info->getEvent(*m_cursor, evt) )
                                        {
                                               std::string name = evt->getEventName();
                                               if (name.empty())
                                                      continue;
                                               text = evt->getEventName();
                                               if (serviceAvail)
                                               {
                                                      if (!selected && m_color_set[eventForeground])
                                                             painter.setForegroundColor(m_color[eventForeground]);
                                                      else if (selected && m_color_set[eventForegroundSelected])
                                                             painter.setForegroundColor(m_color[eventForegroundSelected]);
                                                      else
                                                             painter.setForegroundColor(gRGB(0xe7b53f));
      
 
                                                      if (serviceFallback && !selected && m_color_set[eventForegroundFallback]) // fallback receiver
                                                             painter.setForegroundColor(m_color[eventForegroundFallback]);
                                                      else if (serviceFallback && selected && m_color_set[eventForegroundSelectedFallback])
                                                             painter.setForegroundColor(m_color[eventForegroundSelectedFallback]);
      
 
                                               }
                                               break;
                                        }
                                        continue;
                                  }
 

Edited by littlesat, 10 September 2018 - 14:28.

[blinkosm]

Sorry it was listboxservice.cpp

https://github.com/O...tboxservice.cpp

Its within the function voideListboxServiceContent::paint

below line 786 the event info is added to the service list...

In line 793 the event text is derived... here you should add the "(" before and a ")" after a string (when the config option is enabled)...

When doing this please do not only do it by yourself... Please try to get it 'in'...

Mmmm and when I look to the code why to 'they' first put the event text in 'name' and then in 'text' ?

P.S. In DMMs E2 the painter is a swig to python code... (slower, but for non C++ programmers better adaptable)

                           case celServiceInfo:
								  {
									    if ( isPlayable && service_info && !service_info->getEvent(*m_cursor, evt) )
									    {
											   std::string name = evt->getEventName();
											   if (name.empty())
													  continue;
											   text = evt->getEventName();
											   if (serviceAvail)
											   {
													  if (!selected && m_color_set[eventForeground])
													  	   painter.setForegroundColor(m_color[eventForeground]);
													  else if (selected && m_color_set[eventForegroundSelected])
													  	   painter.setForegroundColor(m_color[eventForegroundSelected]);
													  else
													  	   painter.setForegroundColor(gRGB(0xe7b53f));
	  
 
													  if (serviceFallback && !selected && m_color_set[eventForegroundFallback]) // fallback receiver
													  	   painter.setForegroundColor(m_color[eventForegroundFallback]);
													  else if (serviceFallback && selected && m_color_set[eventForegroundSelectedFallback])
													  	   painter.setForegroundColor(m_color[eventForegroundSelectedFallback]);
	  
 
											   }
											   break;
									    }
									    continue;
								  }
 

Thanks littlesat i will take a look

Edited by blinkosm, 10 September 2018 - 15:39.

[blinkosm]

maybe the use "name" for the skin and the" text"  for the python code like in the eventname.py at the end you will find  text = property(getText) so finally you will get a text no a name .

 

i wanna make () by default not until the config option is enabled so  should i add () like this  text = (evt->getEventName()) ; ????

Edited by blinkosm, 11 September 2018 - 13:55.

[littlesat]

The string in 'text' is rendered later. Here only the pencil and background colors are defined.... The text in name is never used elsewhere... So that stuff can be changed as...

 

-                                    std::string name = evt->getEventName();
-                                             if (name.empty())
+                                    std::string text = evt->getEventName();
+                                            if (text .empty())
                                                     continue;
-                                             text = evt->getEventName();

 

Than after we retrieve the text we need something that reads a config that arrange the "(" and ")" are added to the text std:string.