Jump to content


Photo

develop: python3 transition


  • Please log in to reply
371 replies to this topic

Re: develop: python3 transition #221 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 6 January 2022 - 19:12

PR https://github.com/O...igma2/pull/3255



Re: develop: python3 transition #222 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 6 January 2022 - 19:14

Can you also check this... It prevents from scanning for services, as the newly found services are stored into a FIFOlist

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ServiceScan.py", line 238, in newService
    self.servicelist.addItem((newServiceName, newServiceRef))
  File "/usr/lib/enigma2/python/Components/FIFOList.py", line 12, in addItem
    self.l.setList(self.list[-self.len:])
TypeError: slice indices must be integers or None or have an __index__ method
[ePyObject] (CallObject(<bound method ServiceScan.newService of <Components.ServiceScan.ServiceScan object at 0xb1689f58>>,()) failed)


Re: develop: python3 transition #223 Beeker

  • PLi® Contributor
  • 1,602 posts

+203
Excellent

Posted 6 January 2022 - 19:25

Try

 

self.l.setList(self.list[-self.len:])

 

to

 

self.l.setList(self.list[-int(self.len):])


Dreambox dm920, Uclan Ustym4Kpro, Gigablue UHD TRIO 4K and Dreambox dm8000. Wavefrontier T55 13.0|19.2|23.5|28.2 + Ziggo.


Re: develop: python3 transition #224 WanWizard

  • PLi® Core member
  • 70,523 posts

+1,810
Excellent

Posted 6 January 2022 - 19:36

@wanwizard, which boxes still fail at build?

 

I'll let you know when the current run is finished ;).
 


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: develop: python3 transition #225 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 6 January 2022 - 19:40

Try

 

self.l.setList(self.list[-self.len:])

 

to

 

self.l.setList(self.list[-int(self.len):])

Crash fixed, I can now scan for services.



Re: develop: python3 transition #226 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 6 January 2022 - 19:42

More crashes... In satfinder plugin

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 78, in action
    return ActionMap.action(self, contexts, action)
  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 58, in action
    res = self.actions[action]()
  File "/usr/lib/enigma2/python/Screens/Menu.py", line 62, in okbuttonClick
    selection[1]()
  File "/usr/lib/enigma2/python/Tools/BoundFunction.py", line 10, in __call__
    return self.fnc(*self.args + args, **newkwargs)
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/Satfinder/plugin.py", line 591, in SatfinderMain
    session.openWithCallback(boundFunction(SatfinderCallback, close), Satfinder)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 303, in openWithCallback
    dlg = self.open(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/StartEnigma.py", line 316, in open
    self.execBegin()
  File "/usr/lib/enigma2/python/StartEnigma.py", line 241, in execBegin
    c.show()
  File "/usr/lib/enigma2/python/Screens/Screen.py", line 129, in show
    x()
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/Satfinder/plugin.py", line 84, in prepareFrontend
    self.retune()
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/Satfinder/plugin.py", line 485, in retune
    self.retuneSat()
  File "/usr/lib/enigma2/python/Plugins/SystemPlugins/Satfinder/plugin.py", line 480, in retuneSat
    self.tuner.tune(transponder)
  File "/usr/lib/enigma2/python/Components/TuneTest.py", line 15, in tune
    parm.frequency = transponder[0] * 1000
TypeError: in method 'eDVBFrontendParametersSatellite_frequency_set', argument 2 of type 'unsigned int'
[ePyObject] (CallObject(<bound method NumberActionMap.action of <Components.ActionMap.NumberActionMap object at 0xb16d21c0>>,('OkCancelActions', 'ok')) failed)

Another one, when saving configuration settings

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/StartEnigma.py", line 224, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/Menu.py", line 106, in menuClosedWithConfigFlush
    configfile.save()
  File "/usr/lib/enigma2/python/Components/config.py", line 1889, in save
    config.saveToFile(self.CONFIG_FILE)
  File "/usr/lib/enigma2/python/Components/config.py", line 1862, in saveToFile
    f.write(text)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 973-979: ordinal not in range(128)
[ePyObject] (CallObject(<bound method Session.processDelay of <__main__.Session object at 0xb2349178>>,()) failed)


Re: develop: python3 transition #227 foxbob

  • Senior Member
  • 624 posts

+18
Neutral

Posted 6 January 2022 - 20:09

More crashes.

Choice of resolution at start

18:59:02.5625   File "/usr/lib/enigma2/python/Screens/StartWizard.py", line 33, in __init__
18:59:02.5628     WizardLanguage.__init__(self, session, showSteps=False)
18:59:02.5628   File "/usr/lib/enigma2/python/Screens/WizardLanguage.py", line 8, in __init__
18:59:02.5630     Wizard.__init__(self, session, showSteps, showStepSlider, showList, showConfig)
18:59:02.5631   File "/usr/lib/enigma2/python/Screens/Wizard.py", line 187, in __init__
18:59:02.5634     self["config"] = ConfigList([], session=session)
18:59:02.5635   File "/usr/lib/enigma2/python/Components/ConfigList.py", line 16, in __init__
18:59:02.5637     height, space = parameters.get("ConfigListSlider", applySkinFactor(17, 0))
18:59:02.5638 ValueError: not enough values to unpack (expected 2, got 0)
18:59:02.5639 [ePyObject] (CallObject(<bound method Session.processDelay of <__main__.Session object at 0xb1228370>>,()) failed)

More

18:58:58.3714   File "/usr/lib/enigma2/python/Plugins/Extensions/SocketMMI/plugin.py", line 4, in <module>
    from Plugins.Extensions.SocketMMI.SocketMMI import SocketMMIMessageHandler
18:58:58.3715   File "/usr/lib/enigma2/python/Plugins/Extensions/SocketMMI/SocketMMI.py", line 4, in <module>
    from Plugins.Extensions.SocketMMI import socketmmi
18:58:58.3715 ImportError: dynamic module does not define module export function (PyInit_socketmmi)

When you select the add-ons menu by the blue button

19:00:32.0772   File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 2331, in showExtensionSelection
19:00:32.0798     list and self.session.openWithCallback(self.extensionCallback, ChoiceBox, title=_("Please choose an extension..."), list=list, keys=keys, skin_name="ExtensionsList", reorderConfig="extension_order", windowTitle=_("Extensions menu"))
19:00:32.0799   File "/usr/lib/enigma2/python/StartEnigma.py", line 348, in openWithCallback
19:00:32.0805     dlg = self.open(screen, *arguments, **kwargs)
19:00:32.0805   File "/usr/lib/enigma2/python/StartEnigma.py", line 361, in open
19:00:32.0811     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
19:00:32.0811   File "/usr/lib/enigma2/python/StartEnigma.py", line 301, in instantiateDialog
19:00:32.0816     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
19:00:32.0817   File "/usr/lib/enigma2/python/StartEnigma.py", line 318, in doInstantiateDialog
19:00:32.0821     dlg = screen(self, *arguments, **kwargs)
19:00:32.0822   File "/usr/lib/enigma2/python/Screens/ChoiceBox.py", line 62, in __init__
19:00:32.0825     self.list.append(ChoiceEntryComponent(key=strpos, text=x))
19:00:32.0825   File "/usr/lib/enigma2/python/Components/ChoiceList.py", line 15, in ChoiceEntryComponent
19:00:32.0827     x, y, w, h = parameters.get("ChoicelistName", applySkinFactor(45, 0, 800, 25))
19:00:32.0828 ValueError: not enough values to unpack (expected 4, got 0)
19:00:32.0829 [ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.HelpableActionMap object at 0xb0d5c8c8>>,('InfobarExtensions', 'extensions')) failed)

If I removed for the sample applySkinFactor,then there is no crash, but only the emergency skin works.



Re: develop: python3 transition #228 Beeker

  • PLi® Contributor
  • 1,602 posts

+203
Excellent

Posted 6 January 2022 - 21:08

@nautilus7

 

Can try in enigma2/lib/python/Plugins/SystemPlugins/Satfinder/plugin.py  line 477

 

from:

				transponder = (tp[1] / 1000, tp[2] / 1000,

To:

				transponder = (tp[1] // 1000, tp[2] // 1000,

 


Dreambox dm920, Uclan Ustym4Kpro, Gigablue UHD TRIO 4K and Dreambox dm8000. Wavefrontier T55 13.0|19.2|23.5|28.2 + Ziggo.


Re: develop: python3 transition #229 Beeker

  • PLi® Contributor
  • 1,602 posts

+203
Excellent

Posted 6 January 2022 - 21:23

@foxbob

 

What Enigma2 do you use? From Fairbird, OpenVision, OpenATV, OpenPLi develop?


Edited by Beeker, 6 January 2022 - 21:24.

Dreambox dm920, Uclan Ustym4Kpro, Gigablue UHD TRIO 4K and Dreambox dm8000. Wavefrontier T55 13.0|19.2|23.5|28.2 + Ziggo.


Re: develop: python3 transition #230 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 6 January 2022 - 21:39

https://github.com/O...igma2/pull/3256

 

the satfinder plugin works now with your fix.



Re: develop: python3 transition #231 foxbob

  • Senior Member
  • 624 posts

+18
Neutral

Posted 6 January 2022 - 22:01

OpenPli.



Re: develop: python3 transition #232 WanWizard

  • PLi® Core member
  • 70,523 posts

+1,810
Excellent

Posted 6 January 2022 - 22:28

I'll let you know when the current run is finished ;).

Build is still running, but sofar the VU Duo 4K, VU Ultimo 4K and Lunix3-4k have failed:

ERROR: enigma2-plugin-systemplugins-bluetoothsetup-1.0-20171115.r0 do_compile: ExecutionError('/openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20171115.r0/temp/run.do_compile.29801', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20171115.r0/temp/log.do_compile.29801
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/bluetoothsetup-vuultimo4k.bb:do_compile) failed with exit code '1'
| ERROR: ExecutionError('/openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20171115.r0/temp/run.do_compile.29801', 1, None, None)
ERROR: vuplus-enigma2-packages-experimental-gitAUTOINC+b0fb2521ce-r6 do_install: ExecutionError('/openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/run.do_install.29979', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/log.do_install.29979
| ERROR: ExecutionError('/openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/run.do_install.29979', 1, None, None)
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/vuplus-enigma2-packages.bb:do_install) failed with exit code '1'
Summary: There were 2 ERROR messages shown, returning a non-zero exit code.
! ERRORS BITBAKE openpli-enigma2-image for vuultimo4k
ERROR: enigma2-plugin-systemplugins-bluetoothsetup-1.0-20171115.r0 do_compile: ExecutionError('/openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20171115.r0/temp/run.do_compile.29801', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20171115.r0/temp/log.do_compile.29801
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/bluetoothsetup-vuultimo4k.bb:do_compile) failed with exit code '1'
ERROR: vuplus-enigma2-packages-experimental-gitAUTOINC+b0fb2521ce-r6 do_install: ExecutionError('/openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/run.do_install.29979', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuultimo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/log.do_install.29979
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/vuplus-enigma2-packages.bb:do_install) failed with exit code '1'
ERROR: enigma2-plugin-systemplugins-bluetoothsetup-1.0-20181109.r1 do_compile: ExecutionError('/openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20181109.r1/temp/run.do_compile.21498', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20181109.r1/temp/log.do_compile.21498
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/bluetoothsetup-vuduo4k.bb:do_compile) failed with exit code '1'
| ERROR: ExecutionError('/openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20181109.r1/temp/run.do_compile.21498', 1, None, None)
ERROR: vuplus-enigma2-packages-experimental-gitAUTOINC+b0fb2521ce-r6 do_install: ExecutionError('/openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/run.do_install.22876', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/log.do_install.22876
| ERROR: ExecutionError('/openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/run.do_install.22876', 1, None, None)
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/vuplus-enigma2-packages.bb:do_install) failed with exit code '1'
Summary: There were 2 ERROR messages shown, returning a non-zero exit code.
! ERRORS BITBAKE openpli-enigma2-image for vuduo4k
ERROR: enigma2-plugin-systemplugins-bluetoothsetup-1.0-20181109.r1 do_compile: ExecutionError('/openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20181109.r1/temp/run.do_compile.21498', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/enigma2-plugin-systemplugins-bluetoothsetup/1.0-20181109.r1/temp/log.do_compile.21498
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/bluetoothsetup-vuduo4k.bb:do_compile) failed with exit code '1'
ERROR: vuplus-enigma2-packages-experimental-gitAUTOINC+b0fb2521ce-r6 do_install: ExecutionError('/openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/run.do_install.22876', 1, None, None)
ERROR: Logfile of failure stored in: /openpli/oe/python3/build/tmp/work/vuduo4k-oe-linux-gnueabi/vuplus-enigma2-packages/experimental-gitAUTOINC+b0fb2521ce-r6/temp/log.do_install.22876
ERROR: Task (/openpli/oe/python3/meta-vuplus/recipes-bsp/drivers/vuplus-enigma2-packages.bb:do_install) failed with exit code '1'
ERROR: Nothing RPROVIDES 'webkit-hbbtv-plugin' (but /openpli/oe/python3/meta-xsarius.pli5/recipes-webkit/webkit/enigma2-plugin-extensions-hbbtv-webkit.bb RDEPENDS on or otherwise requires it)
ERROR: Required build target 'openpli-enigma2-image' has no buildable providers.
Summary: There were 2 ERROR messages shown, returning a non-zero exit code.
! ERRORS BITBAKE openpli-enigma2-image for lunix3-4k
ERROR: Nothing RPROVIDES 'webkit-hbbtv-plugin' (but /openpli/oe/python3/meta-xsarius.pli5/recipes-webkit/webkit/enigma2-plugin-extensions-hbbtv-webkit.bb RDEPENDS on or otherwise requires it)
ERROR: Required build target 'openpli-enigma2-image' has no buildable providers.

 


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: develop: python3 transition #233 nikos100

  • Senior Member
  • 25 posts

0
Neutral

Posted 7 January 2022 - 00:40

good evening and Happy New Year. it will go out get out soon? for sf8008 with python 3 images



Re: develop: python3 transition #234 foxbob

  • Senior Member
  • 624 posts

+18
Neutral

Posted 7 January 2022 - 07:20

Good afternoon.With this I managed to collect for ultimo4k.Maybe for other models it is necessary to change the checksum.

Attached Files



Re: develop: python3 transition #235 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 7 January 2022 - 12:17

@WanWizard, can you create a python3 branch in the epgimport repository, so I can push some changes the coming days? Or do you prefer to make the changes in a python2 and python3 compatible way, using e.g. the six module, etc, so it is easier to maintain?



Re: develop: python3 transition #236 Pr2

  • PLi® Contributor
  • 6,181 posts

+261
Excellent

Posted 7 January 2022 - 13:28

Good question indeed I was wondering if we need to turn the plugins into something compatible or if can go straight forward and drop all python2 support and focus on python3 in a specific branch.


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)

AB-Com: PULSe 4K 1*DVB-S2X (+ DVB-C/T/T2)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 


Re: develop: python3 transition #237 Huevos

  • PLi® Contributor
  • 4,661 posts

+163
Excellent

Posted 7 January 2022 - 13:52

Good question indeed I was wondering if we need to turn the plugins into something compatible or if can go straight forward and drop all python2 support and focus on python3 in a specific branch.

IMO, Maintaining multiple branches of plugins for Py3 is a nightmare. If the plugins are for sharing make them compatible with both versions on the same branch. Otherwise if they are just for PLi drop py2 compatibility.

 

All my plugins have one branch and everybody builds from that branch irrespective of Python version. Same at OE-A plugins.
 



Re: develop: python3 transition #238 nautilus7

  • Senior Member
  • 229 posts

+6
Neutral

Posted 7 January 2022 - 14:15

That was my thought. They should remain python2 compatible since they will not be used just for the upcoming pli, but for older pli versions as well. Having to push any plugin update to a supposed python3 branch demands more effort and time.


Edited by nautilus7, 7 January 2022 - 14:17.


Re: develop: python3 transition #239 WanWizard

  • PLi® Core member
  • 70,523 posts

+1,810
Excellent

Posted 7 January 2022 - 14:54

+1.

 

Compatibility can always be removed at a later date when Py2 is a distant memory... ;)


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: develop: python3 transition #240 blzr

  • PLi® Core member
  • 2,270 posts

+118
Excellent

Posted 7 January 2022 - 18:00

crash in unicable steup:

...
  File "/usr/lib/enigma2/python/Components/NimManager.py", line 1426, in unicableManufacturerChanged
    productslist = [p.get("name") for p in [m.getchildren() for m in unicable_xml.find(lnb_or_matrix) if m.get("name") == configEntry.value][0]]
  File "/usr/lib/enigma2/python/Components/NimManager.py", line 1426, in <listcomp>
    productslist = [p.get("name") for p in [m.getchildren() for m in unicable_xml.find(lnb_or_matrix) if m.get("name") == configEntry.value][0]]
AttributeError: 'xml.etree.ElementTree.Element' object has no attribute 'getchildren'
[ePyObject] (CallObject(<bound method NumberActionMap.action of <Components.ActionMap.NumberActionMap object at 0xb0c5aa90>>,('SetupActions', 'right')) failed)

getchildern element is deprecated in python3,

this has fixeed issue for me:

diff --git a/lib/python/Components/NimManager.py b/lib/python/Components/NimManager.py
index 11d58b0b9..15300c481 100644
--- a/lib/python/Components/NimManager.py
+++ b/lib/python/Components/NimManager.py
@@ -1409,7 +1409,7 @@ def InitNimManager(nimmgr, update_slots=[]):
 				def unicableProductChanged(manufacturer, lnb_or_matrix, configEntry):
 					config.unicable.unicableProduct.value = configEntry.value
 					config.unicable.unicableProduct.save()
-					productparameters = [p for p in [m.getchildren() for m in unicable_xml.find(lnb_or_matrix) if m.get("name") == manufacturer][0] if p.get("name") == configEntry.value][0]
+					productparameters = [p for p in [m for m in unicable_xml.find(lnb_or_matrix) if m.get("name") == manufacturer][0] if p.get("name") == configEntry.value][0]
 					section.bootuptime = ConfigInteger(default=int(productparameters.get("bootuptime", 1000)), limits=(0, 9999))
 					section.bootuptime.save_forced = True
 					section.powerinserter = ConfigYesNo(default=SystemInfo["FbcTunerPowerAlwaysOn"])
@@ -1423,7 +1423,7 @@ def InitNimManager(nimmgr, update_slots=[]):
 				def unicableManufacturerChanged(lnb_or_matrix, configEntry):
 					config.unicable.unicableManufacturer.value = configEntry.value
 					config.unicable.unicableManufacturer.save()
-					productslist = [p.get("name") for p in [m.getchildren() for m in unicable_xml.find(lnb_or_matrix) if m.get("name") == configEntry.value][0]]
+					productslist = [p.get("name") for p in [m for m in unicable_xml.find(lnb_or_matrix) if m.get("name") == configEntry.value][0]]
 					if not config.unicable.content.items.get("unicableProduct", False) or config.unicable.unicableProduct.value not in productslist:
 						config.unicable.unicableProduct = ConfigSelection(productslist)
 					config.unicable.unicableProduct.save_forced = True
@@ -1819,3 +1819,4 @@ def InitNimManager(nimmgr, update_slots=[]):
 
 
 nimmanager = NimManager()

Edited by blzr, 7 January 2022 - 18:02.

True sarcasm doesn't need green font...


4 user(s) are reading this topic

0 members, 4 guests, 0 anonymous users