1139 replies to this topic

[WanWizard]

I don't see any issue, I thought this was already merged, it was discussed quite some time ago.

[gjstroom]

Something wrong with the forum ?

It seems I can reply here, but can't create a new thread.

Already wrote this in dutch, but can't post it .....

 

Weet niet of het al bekent is maar er lijkt wat mis met het forum (misschien door de werkzaamheden van paar dagen terug ?)
Ik krijg een Forbidden pagina als ik direct naar specifieke pagina van een forum item wil gaan.
Bv:
https://forums.openp...starten-opname/
Als dan meteen klik op het '4' icoontje dan gaat het fout. Het geldt voor alle pagina's en ook voor alle items die meerdere pagina's hebben.
De url hiervan is: https://forums.openp...n-opname/?st=60
Ik kan wel prima eerst de hoodpagina openen en dan door naar de laatste.

And sorry for posting this here, but it seems to be the only possibility to reply in a existing thread

Edited by gjstroom, 15 February 2024 - 13:30.

[WanWizard]

Creating new topics should be fixed again. New security filter a bit too tight...

[littlesat]

So it is fine and we do not worry about the load of our epg servers as soon everyone does it once a hour? Maybe to save upload when twice a day is sufficiant we can at least limit it ?

Edited by littlesat, 15 February 2024 - 14:37.

[littlesat]

The commit also has two parts... as the plugin was it imports enigma... and now what is needed from enigma is imported.... so there are (at least) two different things in the commit. 

[WanWizard]

The potential problem is that epgimport imports ALL defintiions on EVERY import, so if you schedule an import once every x hours, it will also import the EPG that isn't changed again.

 

I understand that, but I also understand users with providers like that have a need to have their problems addressed to.

 

So instead of simply blocking this, maybe we should spend some time thinking about how to address the potential problems.

 

I think technically it is not that complicated:

• keep a log of the last time a URL was fetched (e.g. a xmltv file was downloaded)
• use that time to add a request header to the next download: "If-Modified-Since: Thu, 15 Feb 2024 07:28:00 GMT"
• if the request now returns HTTP 304 NOT MODIFIED, there is nothing downloaded and no new EPG to process

[littlesat]

You understand that it looks like a simple patch (while even an extra thing was included), but there is more behind it than just streamlining it…

[WanWizard]

I have no clue what you are on about.

 

I understand what Dimitrij's requirements are, and I understand your concerns. And I gave a possible solution for those concerns.

[littlesat]

The clue is that you can make a merge suggestion... where two things are mixed.... (removing enigma. a lot of times + the repeated reload patch in one).... but is is something better to think about it longer... E.g. your suggestion with files and timestamps where you can check if there is really something new is a huge improvement...

 

Beside this I also have no idea about the real impact when everyone starts downloading each hour...and try to get all... -> "The potential problem is that epgimport imports ALL defintiions on EVERY import,'

Edited by littlesat, 15 February 2024 - 18:32.

[WanWizard]

It is your assumption that everybody will start doing that, I doubt that, 99.9999% of people use Rytec's EPG which is only updated once a day.

 

And if you are so afraid of that, implement my suggestion before the code gets into 9.1-release. Problem solved.

[littlesat]

Then at least Dimitrij should split the merge request…. One for the repeated ego load patch and the other for the enigma2 import stuff.

Edited by littlesat, 15 February 2024 - 19:55.

[WanWizard]

Yes, ideally one change = one PR.

 

But as you've merged it, that is water under the bridge for THIS PR And it doesn't help fixing the outstanding issue.

[littlesat]

Then merge it…

[WanWizard]

??? I thought you already did?

 

edit: appearently not.

 

The "problem" is for a large part with github, it allows only one open PR between fork and upstream, and as long as that isn't accepted and merged, a new one can't be made.

So Dimitrij can't create two PR's for the two changes, not until you accept and merge the first one. As long as that doesn't happen, you block all his work.

Edited by WanWizard, 15 February 2024 - 20:54.

[DimitarCC]

If you make two separate branches in the fork you can make two PRs...

[Huevos]

So it is fine and we do not worry about the load of our epg servers as soon everyone does it once a hour? Maybe to save upload when twice a day is sufficiant we can at least limit it ?

+1, we also provide one of the servers.

[Huevos]

??? I thought you already did?

 

edit: appearently not.

 

The "problem" is for a large part with github, it allows only one open PR between fork and upstream, and as long as that isn't accepted and merged, a new one can't be made.

So Dimitrij can't create two PR's for the two changes, not until you accept and merge the first one. As long as that doesn't happen, you block all his work.

For each unrelated project a new feature branch should be created. That way you can have multiple PR's to different features available in parallel.

[Dimitrij]

Big thanks

and excuse me (again two in one).

But everything is clear .

[EPGConfig/filtersServices] add support - .zip file/any ignore ref

[littlesat]

Merged

[Dimitrij]

Merged

thanks