60 replies to this topic

[Stan]

I'd like to report a bug in the FritzCall plugin. On the status screen, guest WLAN is always displayed as disabled.

 

 FritzCall_Status_incorrect_guest_WLAN.jpg   105.83KB   1 downloads

 

I have narrowed it down to this commit:

 

https://github.com/O...FritzCallFBF.py

 

Can someone please take a look? Thx

Edited by Stan, 3 November 2022 - 09:06.

[Dimitrij]

Original plugin

https://github.com/o...aster/fritzcall

[Stan]

I have just tried the latest original version of the plugin. I can confirm that v1620 does not have this problem.

[scriptmelvin †]

What is your FRITZ!OS version?

[mimisiku]

Mine is a 7583 VDSL connected to Genexis fiber port (1 Gbit). Fritz!OS 7.31 is on the device.. Guest access is reported as disabled (which it isn’t)

[scriptmelvin †]

Thanks @mimisiku, I'll assume TS also has a recent version.

 

master: Fix guest WLAN always displayed as disabled #836

 

python3: Fix guest WLAN always displayed as disabled #837

[Stan]

My Fritz!OS version is 7.29.

[scriptmelvin †]

Thanks.

[WanWizard]

master: Fix guest WLAN always displayed as disabled #836

python3: Fix guest WLAN always displayed as disabled #837

 

Both merged.

[scriptmelvin †]

[fritzcall] update pinning #1139

[Stan]

@scriptmelvin

 

I have tested your patch on Fritz!OS version 7.13 and it does not work.

[scriptmelvin †]

It works on my fritzbox. What is your OpenPLi version? How did you test the patch?

[Stan]

I am running OpenPLi 8.3.

I removed FritzCall from the box and re-installed the new version (with your patch) from the feed.

 

I have also tested the current original plugin. It does not contain your patch, and works fine.

Edited by Stan, 5 November 2022 - 16:22.

[scriptmelvin †]

The fixed version is not on the feed yet. Please wait until the next build finishes (see top-right corner of openpli.org for status), then try again.

Edit: first the above "update pinning" PR must be merged.

Edited by scriptmelvin, 5 November 2022 - 16:51.

[Stan]

I have now installed the modified FritzCallFBF.py manually for testing. Same result. It does not fix the problem.

 

How come, that the original plugin works without this patch?

Edited by Stan, 5 November 2022 - 17:17.

[WanWizard]

Edit: first the above "update pinning" PR must be merged.

 

Done.

[scriptmelvin †]

I have now installed the modified FritzCallFBF.py manually for testing. Same result. It does not fix the problem.

Now my local version doesn't work anymore either... I see I made changes in the wrong place... I'll fix it.
 
 

How come, that the original plugin works without this patch?

Probably because of this piece of code, which isn't in the OpenPLi version. I'll add it.

I also noticed that I can activate WLAN guest access with yellow, but not deactivate it. I'll look into it.

[scriptmelvin †]

Now my local version doesn't work anymore either... I see I made changes in the wrong place... I'll fix it.

Fixed.
 

I also noticed that I can activate WLAN guest access with yellow, but not deactivate it. I'll look into it.

Fixed.

@Stan or @mimisiku, would you like to test before I PR? FritzCallFBF.py

[Stan]

It still does not work. I should mention, that I use the german language version of Fritz!OS..

[scriptmelvin †]

I should mention, that I use the german language version of Fritz!OS..

Aaahhh. Yes you should Great, language-dependent text in API responses...   

{
    'linktxt': 'WLAN-Gastzugang',
    'details': 'aktiv (2,4/5 GHz), gesichert, 0 Geräte, Funknetz: XXXXXXXX',
    'link': 'wGuest'
}

I'll fix it for German too.