2041 replies to this topic

[littlesat]

Does this mean all the other skins are not compatible anymore? So the developers did not thought of this?
But I agree it might be a better added value when we get the option with the height somewhere merged…. Then there is also a better sync between images here.

Edited by littlesat, 24 November 2023 - 08:32.

[littlesat]

The path in the menus is indeed a configurable option.

[DimitarCC]

There is no problem in old skins since they was using double height of the item for the 2 lines layouts.

We made it to switch to the new layout automatically if user was picked previously one of the old 2 line layouts.

 

So rendering is extended with new attributes that are anyway option and have default values. So not breaking of old skins. They will work like now.

[DimitarCC]

The path in the menus is indeed a configurable option.

 

OK then i may think about a way to put it in the screen title. Maybe a custom widget that will render "Screen Title (screen path)". And the path to be there only if it is enabled in the config.

[littlesat]

Then please offer a merge request when it is not too much work.

[littlesat]

I suggest put them in the back part above the menu title right aligned in the black two lines also the extreme small letters we have now and make the list a bit smaller in (max) height.

Edited by littlesat, 24 November 2023 - 08:35.

[DimitarCC]

Umm can you give me more details about this?

I am not sure i understood....

 

Here is the config screen (I think paths are useful mainly for config menu screens...Right?)

 

 configscreen.jpg   82.46KB   0 downloads

 

 

Where should be that path displayed? And you suggests to be with backslashes? e.g. / screen path /

Edited by DimitarCC, 24 November 2023 - 08:41.

[DimitarCC]

Something like that?

 

 configscreen_alt.jpg   83.66KB   0 downloads

 

or

 

 configscreen_alt2.jpg   83.55KB   0 downloads

Edited by DimitarCC, 24 November 2023 - 08:58.

[Tech]

During updating, the number of updates is not shown, as some information is missing.

 Scherm­afbeelding 2023-11-24 om 09.17.38.png   1.47MB   1 downloads

[DimitarCC]

Could be. PLi specific screens have to be worked on. But i need help with that

[littlesat]

Regarding this...

 

https://github.com/O...350914805a7555f

 

It looks now Huevos considered to add a sort for the attributes.... Maybe better arrange that further in the code and give it a kind of priority. When the two have the same value and this is something we expect I think this is not needed.

 

At software update you still get a full screen that could also be a smaller one.

[littlesat]

Could be. PLi specific screens have to be worked on. But i need help with that 

Sure... but better get the whole stuff aligned somehow... working 'together' on so many images is not that helpful at this time

[DimitarCC]

The sorting is for backward compatability since some skins in OBH doesnt have itemHeight attribute, but have only serviceItemHeight instead.

So if there is serviceItemHeight then take it. If not try to take itemHeight. If not take default.

[DimitarCC]

 

Could be. PLi specific screens have to be worked on. But i need help with that 

Sure... but better get the whole stuff aligned somehow... working 'together' on so many images is not that helpful at this time

 

 

Any suggestions about this?

[littlesat]

I also discovered that the two line 'differences' are not that old... I also see other alignments....

https://github.com/O...0fe4fc9f987820b

[littlesat]

Any suggestions about this?

 

Offline actually, but a (pain)point for years...

 

I prefer not to repeat the history. That is something I prefer to do in person of line when you're interested

 

It will be difficult as in > 10 years the images are different. This simply happens with forking and this is one of the disadvantages about let's say an 'uncontrolled' open source project.

There are also features people are used to, or behavior people are used to. When you merge there are also things that are not there right away and then a new team needs to decide something will never come back.... I'm afraid for this stage it is too late or maybe stuff get too complicated. But my meaning is still, as the community gets smaller, that working better together and indeed consider a kind of merge might be helpful.

 

P.S. the work in the servicelist looks really good... as well in cpp and in python.... (unless I do not like the sort Huevos added)....

Edited by littlesat, 24 November 2023 - 09:39.

[littlesat]

And did I see a mode is removed? This looks kind of obvious for me...

 

- config.usage.servicelist_twolines = ConfigSelection(default="0", choices=[("0", _("None")), ("1", _("two lines")), ("2", _("two lines and next event")), ("3", _("two lines alternative"))])

+ config.usage.servicelist_twolines = ConfigSelection(default="0", choices=[("0", _("None")), ("1", _("two lines"))])

+ if config.usage.servicelist_twolines.value not in ("0", "1"):

+ config.usage.servicelist_twolines.value = "1"

Edited by littlesat, 24 November 2023 - 09:42.

[littlesat]

I prefer having itemHeight="43" serviceItemHeight="43" for the channellist as you have then exactly 20 lines.... and it fits... and it is aligned to what we're used to....

I already did some tests with the different two lines option..... but I cannot get it exactly aligned yet at e.g. the bottom. Looks like there are kind of round-up issues. But in size etc even itemHeightTwoLine="58" looks good.... which makes the two lines view more suitable and much better usable,,,, But 15 channels do fit than but the last line does not fit in two line mode (it does 'almost' fit with next event mode)

 

I think we should simply add the serviceItemHeight="43" in the py code.... Then you can remove the dual attribute stuff in your skin and Huevos does not to take care of the sort stuff...

 

but it is not concequent as itemHeightTwoLine whould then also become serviceitemHeightTwoLine..... so why was this ever changed before.?

 

We now toggle between the channellist modes with the text button... as kind of quick button....but we do not have the config in the menu yet. Maybe I need to add the config also in the menu so people find it and then in the menu make a remark that the text button (or maybe reroute it to the PVR/List/Movie button).... can be used as quick button or hot key toggle thing.

Edited by littlesat, 24 November 2023 - 10:21.

[littlesat]

For your reference two snapshots....where I quick and dirty made some patches to the servicelist.py code... (I also discovered some risky lines there regarding py2->py3 stuff  and maybe lines that can be simplified due to py3).

 

 

 20-oneliners.jpg   144.5KB   0 downloads

 twoliners with next.jpg   146.86KB   0 downloads

Edited by littlesat, 24 November 2023 - 10:26.

[littlesat]

This is already a good location for the menu path.... but then on the 'config screens etc... I have no idea where to put them.. I suggest the same location bottom right might be a good one.... But I did not dive through your skin yet... on the top there is not enough space for it (yet)...

 

 menupath.jpg   190.7KB   0 downloads

[code=auto:0]
        <screen name="MenuTemplate">
                <panel name="FrameTemplate"/>
 
                <widget source="title" render="Label" position="72,864" size="544,62" font="Regular; 34" halign="right" valign="center" backgroundColor="black" transparent="1" />
+                <widget source="ScreenPath" render="Label" position="72,800" size="544,62" backgroundColor="secondBG" transparent="1" zPosition="1" font="Regular;19" valign="bottom" halign="right"/>
                <widget source="menu" render="Listbox" position="72,277" size="564,540" scrollbarMode="showNever" enableWrapAround="1" transparent="1">
                        <convert type="TemplatedMultiContent">
                                                {"template": [ MultiContentEntryText(pos = (97,5),size = (435,45),flags = RT_HALIGN_LEFT|RT_VALIGN_CENTER,text = 0),
                                                                           MultiContentEntryPixmapAlphaBlend(pos = (32,5),size = (48,48), png = 5)],
                                                "fonts": [gFont("Regular",34)],
                                                "itemHeight": 60
                                                }
                        </convert>
                </widget>
                <widget addon="Pager" connection="menu" position="72,827" size="564,25" transparent="1" backgroundColor="background"/>
                <widget source="global.CurrentTime" render="BoxLogo" position="203,175" size="302,65" zPosition="10" alphatest="blend" />
                <eLabel position="102,259" size="506,2" backgroundColor="separator" zPosition="-5" />

        </screen>

Edited by littlesat, 24 November 2023 - 10:58.