2041 replies to this topic

[DimitarCC]

OK so what you suggest? Making selected color lighter?

[DimitarCC]

Why should these be in the base image, instead of in the skin, like all other graphical elements?

 

Well because other image have that in the python code and i just used it...It will be duplication if i make a special renderer for that....

[WanWizard]

Not sure about that, as OpenATV 7.3 doen't seem to have the same issues.

 

 

Just double checked, ATV doesn't have this issue. Can't compare like for like, as your skin isn't in the ATV 7.3 feed.

[WanWizard]

Well because other image have that in the python code and i just used it...It will be duplication if i make a special renderer for that....

 

You mean they haven't bothered to properly separate concerns between core enigma code and UI components?

[WanWizard]

Just double checked, ATV doesn't have this issue. Can't compare like for like, as your skin isn't in the ATV 7.3 feed.

 

Manually installed it.

 

ATV indeed doesn't have the rollout effect, but there is a (at least a) second delay before the infobar is shown on OK.

Not sure whether that id because they use a different sync mechanism, of they have worked around the driver issue and it is just slow like other parts of the image...

[littlesat]

With adding this and a small change to the cpp I get the icon on the gray part... But maybe for the new skin it is better to add the picons for these somehow.... but as far I can see the picons cannot show everything that is possible there....

  <!-- PVR State -->
  <screen name="PVRState" position="92,900" size="225,90" backgroundColor="transparent" zPosition="5" flags="wfNoBorder">
    <widget name="state" position="0,0" size="225,90" backgroundColor="background5" borderWidth="2" font="Regular;84" borderColor="black" halign="center" alphatest="on"/>
  </screen>
 
In infobargenerics.py:
 

class InfoBarPVRState:
                def __init__(self, screen=PVRState, force_show=False):
                                self.onPlayStateChanged.append(self.__playStateChanged)
                                self.pvrStateDialog = self.session.instantiateDialog(screen)
                                self.onShow.append(self._mayShow)
                                self.onHide.append(self.pvrStateDialog.hide)
                                self.force_show = force_show
 
                def _mayShow(self):
-                                if self.shown and self.seekstate != self.SEEK_STATE_PLAY:
+                                if self.shown:
                                                self.pvrStateDialog.show()
 
                def __playStateChanged(self, state):
                                playstateString = state[3]
                                self.pvrStateDialog["state"].setText(playstateString)
 
                                # if we return into "PLAY" state, ensure that the dialog gets hidden if there will be no infobar displayed
                                if not config.usage.show_infobar_on_skip.value and self.seekstate == self.SEEK_STATE_PLAY and not self.force_show:
                                                self.pvrStateDialog.hide()
                                else:
                                                self._mayShow()

Edited by littlesat, 27 November 2023 - 18:31.

[littlesat]

Because you need to wait for a response I'm afraid they have worked around the driver issue and it is just slow like other parts of the image...

 

The skin has also svg. This is structural better... but this does also mean more capacity is needed so this also slows down. Exactly the reason where I was doubting about implement this good sounded idea....

 

Maybe also better to consider to put a picon or png with cover on the gray part of a recording and move the PVR state in a smaller font or icon in the bar behind the times -or- make the title a bit shorter and put it behind the title, and then only show something there when it is there (so with a normal initial play you do not see '>', you only see it with pauze, move forward etc....)

Edited by littlesat, 27 November 2023 - 18:37.

[WanWizard]

ATV displays this when pausing a recording. Not really an improvement...

 

 

Attached Files

•  1_0_0_0_0_0_0_0_0_0_20231127173929.jpg   84.54KB   1 downloads

[littlesat]

With my suggestion I have now this..... but with real picons it look better... but I saw the code and as far I can see you cannot do >>2x >>4x >>8x or \4x with these picons... (I can make a mistake)... and that was exactly the reason for a long time ago I did not took that code... 

 

This is what I get when I add the pvrstate screen and change the code a bit (now initially for play it has a static field '>' and it puts it over... why we create this I do not really know or understand....)

 movieplayer.jpg   104KB   1 downloads

But I still think this place is better for a picon from the channel or show (later) a png from the movie or so.... and then move this as text or picture somewhere else.

Edited by littlesat, 27 November 2023 - 18:51.

[WanWizard]

+1

 

It will also make for a uniform infobar for both live and playback.

[littlesat]

Just a cut and paste example... As this was exactly the perspective I saw in this skin... and putting play/pauze etc. there as picon exacty breaked my thoughts ...

 

 movieplayer2.jpg   106.63KB   4 downloads

Edited by littlesat, 27 November 2023 - 18:58.

[littlesat]

Also the HD SD icons in the servicelist do not really work.... as they depend on the information the providers are giving.... e.g. with that stupid fastscan you get SD icons all over the place....

 

When I have time tomorrow I'll look after that 3rd infobar we have... Maybe other images may also adapt as this is a cool feature ...

Edited by littlesat, 27 November 2023 - 19:00.

[WanWizard]

Interesting, the current programme selector in the GMEPG is a lot more visible on my el-cheapo test TV.

 

So it may be related to brightness and contrast settings, my Plasma is set to THX Cinema settings, which locks out any manual settings.

[DimitarCC]

 

Well because other image have that in the python code and i just used it...It will be duplication if i make a special renderer for that....

 

You mean they haven't bothered to properly separate concerns between core enigma code and UI components?

 

 

Well it is what it is

[DimitarCC]

With my suggestion I have now this..... but with real picons it look better... but I saw the code and as far I can see you cannot do >>2x >>4x >>8x or \4x with these picons... (I can make a mistake)... and that was exactly the reason for a long time ago I did not took that code... 

 

This is what I get when I add the pvrstate screen and change the code a bit (now initially for play it has a static field '>' and it puts it over... why we create this I do not really know or understand....)

movieplayer.jpg

But I still think this place is better for a picon from the channel or show (later) a png from the movie or so.... and then move this as text or picture somewhere else.

 

It is displayed 2x, 4x etc. But that is text ofcource.

 

 rew4x.jpg   119.85KB   1 downloads

[DimitarCC]

Also the HD SD icons in the servicelist do not really work.... as they depend on the information the providers are giving.... e.g. with that stupid fastscan you get SD icons all over the place....

 

When I have time tomorrow I'll look after that 3rd infobar we have... Maybe other images may also adapt as this is a cool feature ...

 

That is true but there is no other option to display such an icons in service list. If you use fast scan yes it may not be correct. And it depends on the provider too. But it cant be helped. For that it may be added an option to be hidden by user if it bothers him.

[DimitarCC]

Just a cut and paste example... As this was exactly the perspective I saw in this skin... and putting play/pauze etc. there as picon exacty breaked my thoughts ...

 

movieplayer2.jpg

 that may work but i whould put the play, pause, etc. icons in front of the description of the movie.

 

However there are several problems.... there is no suitable place for 2x,4x, etc (or they have to be small) and also if you record iptv channel (4097) it never show picons nor movie covers. So it will stay empty which i dont think is very good.

 

Thats why i occupied that space with playback icons because in most cases i never get picons and when i get them they are wrong in some cases.

Edited by DimitarCC, 27 November 2023 - 20:01.

[DimitarCC]

Interesting, the current programme selector in the GMEPG is a lot more visible on my el-cheapo test TV.

 

So it may be related to brightness and contrast settings, my Plasma is set to THX Cinema settings, which locks out any manual settings.

 

It could be that. I have bigger contrast setting and maybe thats why is better on my side.

[littlesat]

I just added support for the graphical PVRstate icons.... 

[DimitarCC]

OK. So for screen paths i came to this visualization

 

 screenpath3.png   434.4KB   3 downloads

 

 screenpath2.png   453.88KB   3 downloads

 

 screenpath1.png   468.47KB   3 downloads