2041 replies to this topic

[Tech]

We do the same with the openwebif, we remove all unnecessary picons and png’s so only the box-related items will be left.

[DimitarCC]

Ok. Like @Huevos suggested i propose the logos to be in /etc/enigma2 and the names to be boxmodel.svg and boxlogo.svg.

[littlesat]

Having them in /etc/enigma2 is I think not a good idea (settings belong to there and no pictures)...

Better to let them land in a subfolder on /usr/share/enigma2/ something like the rc_models.... but then in another subfolder... e.g. box_model... (without s)... so /usr/share/enigma2/box_model

And put the skin specific in the skin and use a renderer to decide to display the box specific one when it exists...

Then we can put the box specific svgs somewhere on github. Could be a shared location as I hate forking.... So also here a structure is welcome... 

Edited by littlesat, 13 December 2023 - 10:47.

[WanWizard]

They should be in /usr/share/enigma2, they are not configuration files.

[DimitarCC]

OK. But the idea was to not have any python files in the skin. Then that renderer have to be in core enigma files...

[Huevos]

They should be in /usr/share/enigma2, they are not configuration files.

This is a misunderstanding. I said "Just put a logo on the box, e.g. in /usr/share/enigma2/skin_default/logo.png". /usr/share/enigma2 would also work.

[littlesat]

Then I prefer a subfolder in there.... /usr/share/enigma2/box_model or something like that... (when you compare it with rc_models)

[WanWizard]

I have no preference.

 

Where is the logic to determine which image is required? In the python code? Or in the build recipe (and only install one image file with a generic name)?

 

If in the code, we need to add logic to the recipe to remove all unwanted images, like we do for the WebIf.

[DimitarCC]

Keep in mind that images have to be svgs since png have huge quality loss when they are scaled down.

Or have to be decide the size of them but that will not give flexibility to the skinner...

[littlesat]

Which image should appear should be arranged in the build process.... (and partly in a renderer when the icon does not exist that a default is shown)

[DimitarCC]

So renderer have to be in base code....

[Huevos]

Where is the logic to determine which image is required? In the python code? Or in the build recipe (and only install one image file with a generic name)?

 

If in the code, we need to add logic to the recipe to remove all unwanted images, like we do for the WebIf.

Has to be done in the build  so each box has one image for model and one for brand.

 

So should work pretty much the same as the rc.png image for the help screens and wizards.
 

[WanWizard]

Don't see that being a problem.

 

The only challenge will be the fact we still don't have any boxinfo, and build a 1:N between image and box model, so displaying the correct image in all cases will be complex without some runtime code.

[Huevos]

Don't see that being a problem.

 

The only challenge will be the fact we still don't have any boxinfo, and build a 1:N between image and box model, so displaying the correct image in all cases will be complex without some runtime code.

 

Let's not complicate things. You don't need boxinfo. If the file is in /usr/share/enigma2 it will be found on a SCOPE lookup. The file will be named the same on all boxes irrespective of model, brand, distro.

Edited by Huevos, 13 December 2023 - 14:22.

[littlesat]

So renderer have to be in base code....-> I think always... at least never in the skin package as they can 'eat' each other when you have e.g. two skins that have the same filenames... but e.g. different code insider and/or you remove a skin and the renderer is gone.

 

When they get too much maybe put in a dependency package....  but this can be considered later... when it is really getting to much... and special...

Edited by littlesat, 13 December 2023 - 14:52.

[WanWizard]

Let's not complicate things. You don't need boxinfo. If the file is in /usr/share/enigma2 it will be found on a SCOPE lookup. The file will be named the same on all boxes irrespective of model, brand, distro.

 

You missed my point.

 

We build one image for lets say the Zgemma H9. So we can only include one box zvg. But Zgemma has multiple H9 models. For the WebIf, we include all images, and determine which one is displayed at runtime using box detection.

 

OE-A has a 1:1 between build and box, so those images don't have that problem.
 

[Huevos]

So how do you show the correct model in the about screen?

 

The whole point was that the was selected by the build and the box didn't have to do anything... but if PLi build is not capable of that what do you suggest?

[WanWizard]

If the about screen shows detailed model info, it is because of runtime code in systeminfo. The same happens in Owif.

 

My suggestion is that someone implements a compatible boxinfo as soon as possible, like yesterday...

 

I'm willing to cooperate with whoever does the Python side, and deal with the OE side of things ( as that will work differently from how OE-A does it ).

I was planning to do this, but I don't have the time and the energy for it. And we need to have it anyway, if we want to switch to the new WebIf.

 

We need runtime code in bash that can complete the boxinfo data at first boot, and can also rename the correct box model image.

Edited by WanWizard, 13 December 2023 - 15:58.

[DimitarCC]

Well we all also dont have much spare time... We are doing all this in the free time...

Isnt there in PLi team someone that have time to do this? We are not even members of PLi team so not expect to share much time on it

[WanWizard]

It wasn't directed at you. Or Huevos... .