2041 replies to this topic

[littlesat]

So i've been told that for svgs is forced alphablending even if it is not enabled....so thats why it could be sluggish on problematic boxes if you have many svgs

->

This is a fact....see the fragment below in skin.py.

 

I looks like we're not really ready for svg... and I also remember it from the time it was introduced. I was happy as for programming it sounds good... but in practice some drivers/hardware are not helpful here... I was also busy with vectorize icons in our recent standard skin but I quickly stopped this project due to the same issues.... That was also why I recommend to change back to png.

def pixmap(self, value):
    if value.endswith(".svg"): # if graphic is svg force alphatest to "blend"
        self.guiObject.setAlphatest(BT_ALPHABLEND)
    self.guiObject.setPixmap(loadPixmap(value, self.desktop, self.guiObject.size().width(), self.guiObject.size().height()))

Edited by littlesat, 28 November 2023 - 15:39.

[WanWizard]

So i've been told that for svgs is forced alphablending even if it is not enabled....so thats why it could be sluggish on problematic boxes if you have many svgs

 

I'm not sure.

If I look at picload.cpp, all images are converted to plain RGBA on load, regardless of the type, unless the "forcergb" flash is used in E2, in which case the alpha channel is stripped.

 

This suggests that the actual rendering happens indepdent of the image type used.

[DimitarCC]

Well if you are willing to force alphatest="on" for unsupported HiSi boxes in a trade with halo around the rounded images then will be fine

[littlesat]

Please not! better find a solution (when possible)....Or I'm afraid get rid of svg.... I understand you tried but I know from experience in the past it does not really work for a lot of boxes due to driver/hardware issues. At least I'm convinced... and maybe this is also the reason why the movieplayer icons do not really work. And I agree also blend is a topic here...

Edited by littlesat, 28 November 2023 - 15:50.

[WanWizard]

I see ATV once added some HiSil specific support, but only for the Dinobot boxes, it was never expanded.

[WanWizard]

Please not! better find a solution (when possible)....Or I'm afraid get rid of svg.... I understand you tried but I know from experience in the past it does not really work for a lot of boxes due to driver/hardware issues. At least I'm convinced... and maybe this is also the reason why the movieplayer icons do not really work. And I agree also blend is a topic here...

 

Can we do some root-cause analysis first, before resorting to drastic measures?

1. what is exactly causing the issues?
2. can we fix it?
3. can we work around it?

Don't start with 3 if 1 and 2 haven't been looked at.

[DimitarCC]

 

Please not! better find a solution (when possible)....Or I'm afraid get rid of svg.... I understand you tried but I know from experience in the past it does not really work for a lot of boxes due to driver/hardware issues. At least I'm convinced... and maybe this is also the reason why the movieplayer icons do not really work. And I agree also blend is a topic here...

 

Can we do some root-cause analysis first, before resorting to drastic measures?

1. what is exactly causing the issues?
2. can we fix it?
3. can we work around it?

Don't start with 3 if 1 and 2 haven't been looked at.

 

 

So i dont know what exactly causing the issues. But it is notably better with alphatest="on". So i suppose it has something to do with the hardware aceleration of alphablended pngs (as you also mentioned).

 

I dont think can be easily fixed because i suppose a hardware acceleration have to be added and i am not sure who can do this.

 

But definitely the problem is not SVGs. The problem is more general and it is for all images that are PNG and SVG. So removing SVGs will not solve the problem.

[DimitarCC]

Please not! better find a solution (when possible)....Or I'm afraid get rid of svg.... I understand you tried but I know from experience in the past it does not really work for a lot of boxes due to driver/hardware issues. At least I'm convinced... and maybe this is also the reason why the movieplayer icons do not really work. And I agree also blend is a topic here...

 

SVGs in the movie player infobar doesnt work for another reason. They was rendering very well on PLi before with my old code in the skin (it was custom in my custom build).  So there is generally not issue with rendering SVGs (at least on Duo4KSE, Uno4KSE)

[littlesat]

Here it seems not to work.. but I did not try on a VU+.... 

[Huevos]

 

Please not! better find a solution (when possible)....Or I'm afraid get rid of svg.... I understand you tried but I know from experience in the past it does not really work for a lot of boxes due to driver/hardware issues. At least I'm convinced... and maybe this is also the reason why the movieplayer icons do not really work. And I agree also blend is a topic here...

 

Can we do some root-cause analysis first, before resorting to drastic measures?

1. what is exactly causing the issues?
2. can we fix it?
3. can we work around it?

Don't start with 3 if 1 and 2 haven't been looked at.

 

 

1. Blending on HiSi. Nothing to do with svg because that is not used on InfoBar.
2. Well maybe rewrite c++ to take advantage of any hardware acceleration that may be available.
3. Switch "blend" to "on" in HiSi boxes. That will speed things up, but will also not render images correctly.
4. Throw the box in the garbage.

[DimitarCC]

Here it seems not to work.. but I did not try on a VU+.... 

 

The problem on your screenshot is a scaling problem with the svg. An issue in LoadPixmap i guess. It shows only upper section of the svg which is wrong.

[WanWizard]

1. Blending on HiSi. Nothing to do with svg because that is not used on InfoBar.
2. Well maybe rewrite c++ to take advantage of any hardware acceleration that may be available.
3. Switch "blend" to "on" in HiSi boxes. That will speed things up, but will also not render images correctly.
4. Throw the box in the garbage.

 

hehehe...

 

It whould be a bit sad for everyone with a HiSil box to be advised 4, when the issue may well be 2.

[DimitarCC]

The problem with option 2 is who will do that....

So more possible options are 3 and 4 hahahhah

[DimitarCC]

Here it seems not to work.. but I did not try on a VU+.... 

 

So to work svgs correct is needed a modification of MultiPixmap. I have it modified here.

 

to the loadPixmap you have to supply a width because that is strongly required for svg.

Edited by DimitarCC, 28 November 2023 - 16:58.

[WanWizard]

The problem with option 2 is who will do that....

So more possible options are 3 and 4 hahahhah

 

Well, the first step is identifying the problem.

 

Second step is to see if we can do something about it, and how.

[littlesat]

So to work svgs correct is needed a modification of MultiPixmap. I have it modified here.

 

to the loadPixmap you have to supply a width because that is strongly required for svg.

It looks indeed we're looking at a kind of zoomed in icon.... So it sounds we have to wait for the little change.... ) Sounds this one will also be resolved....

Edited by littlesat, 28 November 2023 - 17:00.

[DimitarCC]

Well i can make a pull for that....But i am not sure is the code will be optimized. Maybe i can give you the py and you can change it if you like?

Attached Files

•  Pixmap.zip   1.2KB   6 downloads

Edited by DimitarCC, 28 November 2023 - 17:06.

[littlesat]

+1

[littlesat]

I at least could confirm here that setting the size during loading and scale to -1 retrieves a good picture.

[DimitarCC]

Ok. So it works at least.