242 replies to this topic

[WanWizard]

@Stan, @paneologist,

 

How well is this reproducable? Every recording? Once a day? Once a week? Random?

 

Would it be an option to flash the box, and run with the bare minimum of plugins, to rule that out? Something must be blocking signals...

[WanWizard]

p.s. I have this installed:

root@vuduo4k:~# opkg list-installed | grep "enigma2-"
enigma2-fonts - 2020.10.17-r0.0
enigma2-plugin-extensions-audiosync - git5638+db6a7fb-r0.0
enigma2-plugin-extensions-autobackup - 2.0+git170+34fbb1e-r1.2
enigma2-plugin-extensions-autotimer - git5638+db6a7fb-r0.0
enigma2-plugin-extensions-cutlisteditor - 3.9+git20812+59df728-r0.0
enigma2-plugin-extensions-epgimport - 1.0+git242+e698e22-r0.0
enigma2-plugin-extensions-epgimport-rytec - 20230617-r0.0
enigma2-plugin-extensions-epgrefresh - git5638+db6a7fb-r0.0
enigma2-plugin-extensions-epgsearch - git5638+db6a7fb-r0.0
enigma2-plugin-extensions-filecommander - 2.0+git200+76d5946-r1.0
enigma2-plugin-extensions-graphmultiepg - 3.9+git20812+59df728-r0.0
enigma2-plugin-extensions-mediaplayer - 3.9+git20812+59df728-r0.0
enigma2-plugin-extensions-mediascanner - 3.9+git20812+59df728-r0.0
enigma2-plugin-extensions-moviecut - git5638+db6a7fb-r0.0
enigma2-plugin-extensions-openwebif - 1.5.2-182-g4c4a1cea-r0.0
enigma2-plugin-extensions-oscamstatus - 2.0+git55+0004ed5-r1.2
enigma2-plugin-extensions-pictureplayer - 3.9+git20812+59df728-r0.0
enigma2-plugin-skins-pli-hd - 0.1+git2244+ccbacf7-r0.0
enigma2-plugin-softcams-oscam - git10626+c41959f-r0.3
enigma2-plugin-softcams-oscam-emu - git1988+a137cbf-r0.4
enigma2-plugin-systemplugins-bluetoothsetup - 1.0-20221118-py3.r1.1
enigma2-plugin-systemplugins-cablescan - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-fastchannelchange - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-fastscan - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-hdmicec - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-hotplug - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-mphelp - git5638+db6a7fb-r0.0
enigma2-plugin-systemplugins-networkbrowser - git5638+db6a7fb-r0.0
enigma2-plugin-systemplugins-osd3dsetup - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-osdpositionsetup - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-positionersetup - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-remotecontrolcode - experimental-git8516+b0fb252-r6.2
enigma2-plugin-systemplugins-satfinder - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-servicemp3 - git46+a6b2178-r0.71
enigma2-plugin-systemplugins-transcodingsetup - git5638+db6a7fb-r0.0
enigma2-plugin-systemplugins-videomode - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-videotune - 3.9+git20812+59df728-r0.0
enigma2-plugin-systemplugins-wirelesslan - 3.9+git20812+59df728-r0.0
enigma2-plugins - git5638+db6a7fb-r0.0

and it does run both epgimport, epgrefresh and autotimer on a daily basis. It stores about 27Mb of EPG data.
 

[Stan]

I had experienced the problem on an ET7500 back in January 2021, not now! It was then somehow solved by Erik. (see link to the topic in my previous post).

It was assumed that only MIPS-based boxes were affected. But @paneologist has an ARM box. I wonder if over 130 plugins and systemplugins installed could have an impact.

[ims]

Is it on VU+ Duo 4K SE only or on any VU+ ?

I'm recording more programs daily at the same time on my Vu Duo 4K (in standby) and in same time from this box is streamed to my client box.

Time to time is box online too. I never had this problem on my Duo 4K. Never.

Problem with hanging enigma I had only, when I used VU Turbo USB DVB-T2 tuner. 

[ims]

I saw in installed.txt:

enigma2-plugin-drivers-dvb-usb-turbo - 1.0-r0.5
enigma2-plugin-drivers-dvb-usb-turbo2 - 1.0-r0.0
enigma2-plugin-drivers-s2-usb-dvbsky-s960 - 1.0-r0.5

As I wrote, when I had problems with enigma2 in "D" mode, it was with pluged in USB-DVB-T2 (and I have suspicious, that helped using owif with it too) only.

Edited by ims, 7 August 2023 - 08:16.

[paneologist]

thank you for all the effort you're putting into this.

 

p.s. You are running a release image from the looks of it.

 

So start by installing the current develop, because that is the only codebase that will be changed, if a fix can be found.

will make a backup and try

 

Does it always happen when you stream from the box when recordings are running? Or also when you don't stream from the box?

it's totally random and als happens, when nothing is streamed

 

As far as I remember from Erik's comments, it is a time-critical construct.

 

@paneologist

You have installed more than 100 plugins. Could you try a fresh install with minimum plugins and see if the problem persists?

uff.. that will be hard. I first try removing any I do not necessarily need, and then maybe a reinstall only with those.

 

Just a thought…maybe some wrong data in the epg…: maybe stop enigma2, remove epg.dat and then restart enigma2 might already resolve it?

will try that too, but sounds unlikely, as the issue existed from beginning (the box was set up on July 5th)

 

@Stan, @paneologist,

 

How well is this reproducable? Every recording? Once a day? Once a week? Random?

 

Would it be an option to flash the box, and run with the bare minimum of plugins, to rule that out? Something must be blocking signals...

It's randomly, it happens sometimes after timer recordings, when zapping (timeshift record stops) or epgrefresh (using fake recordings)

Is it on VU+ Duo 4K SE only or on any VU+ ?

I'm recording more programs daily at the same time on my Vu Duo 4K (in standby) and in same time from this box is streamed to my client box.

Time to time is box online too. I never had this problem on my Duo 4K. Never.

Problem with hanging enigma I had only, when I used VU Turbo USB DVB-T2 tuner. 

The problem already existed, before I plugged in the USB tuner, which...
 

 

 

I saw in installed.txt:

enigma2-plugin-drivers-dvb-usb-turbo - 1.0-r0.5
enigma2-plugin-drivers-dvb-usb-turbo2 - 1.0-r0.0
enigma2-plugin-drivers-s2-usb-dvbsky-s960 - 1.0-r0.5

As I wrote, when I had problems with enigma2 in "D" mode, it was with pluged in USB-DVB-T2 (and I have suspicious, that helped using owif with it too) only.

... by the way doesn't work for me (yet): https://forums.openp...se-dvb-t-stick/

something btw surprised me, as the box was stuck again at 4:15 this morning (epgrefresh). I looked which file handles are open by the enigma2 process and no recording files showed up.

[littlesat]

as the box was stuck again at 4:15 this morning (epgrefresh)

 

Then try again without epgrefresh + clear the EPG cache... I already mentioned that it could be EPG related... We need to find the trigger first...

Edited by littlesat, 7 August 2023 - 13:20.

[WanWizard]

That suggests more is going on.

 

My box also runs epgrefresh (and epgimport) every morning.

 

Would it be an option to restart it into debug mode every evening before you put it into standby for the night, so we have a debug log if this happens again?

 

You do need to keep an eye of the file size though, it is written to /home/root, which is in flash, and you don't want to run out of flash...

[paneologist]

 

as the box was stuck again at 4:15 this morning (epgrefresh)

 

Then try again without epgrefresh + clear the EPG cache... I already mentioned that it could be EPG related... We need to find the trigger first...

 

I deactivated many plugins. after some more reinstalling, see below. I created dozens of timers for 2 hours, recording frm many tuners simultanously and started epgrefresh - problem did not yet occur again.

 

That suggests more is going on.

 

My box also runs epgrefresh (and epgimport) every morning.

 

Would it be an option to restart it into debug mode every evening before you put it into standby for the night, so we have a debug log if this happens again?

 

You do need to keep an eye of the file size though, it is written to /home/root, which is in flash, and you don't want to run out of flash...

I managed to set up, that the debug output is always sent to a syslog server (some minor changes in inittab and enigma2.sh).

so I will have the debug logs if it should happen again. in my first message I appended 3 excerpts. didn't see anything what may be correlated beforehand.
But if it happens again, I'll upload from just before begin of epgrefresh starts.

If it doesn't happen again, I might track down, which plugin may be the culprit.

 

what I noticed through deinstallation and getting an unstartable enigma2, that some package dependencies seem to be not maintained well.

what I remember:

removing enigma2-plugin-systemplugins-videomode lead to a greenscreen starting enigma2

enigma2-plugin-extensions-dlnabrowser relies on enigma2-plugin-extensions-pictureplayer

and something, i don't remember, needed enigma2-plugin-extensions-vlcplayer

Edited by paneologist, 7 August 2023 - 15:25.

[WanWizard]

As to your last remark, quite possible.

 

There is a lot of junk in the 3rd-party feed (which are binary ipk files reqeusted by users which we don't maintain, don't have source of, and are rarely updated). For OpenPLi 9 (and the current develop) we have deleted all of them as part of the transition to Python 3.

[paneologist]

As of this morning, the problem did not occur again.

I will install one plugin (preferably, those I find usefull) per day, and look if the problem reappears.

 

List of uninstalled plugins, and thus possible culprits:

root@stb1:~# opkg list-installed > nowinstalled; diff installedpackages nowinstalled | grep -e "-enigma"
-enigma2-plugin-drivers-dvb-usb-turbo - 1.0-r0.5
-enigma2-plugin-drivers-dvb-usb-turbo2 - 1.0-r0.0
-enigma2-plugin-drivers-s2-usb-dvbsky-s960 - 1.0-r0.5
-enigma2-plugin-extensions-addstreamurl - 2.0+git14+245d49e-r0.7
-enigma2-plugin-extensions-audiosync - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-babelzapper - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-bitrate - 2.0+git44+d6b0aad-r1.7
-enigma2-plugin-extensions-cooltvguide - Coolman_V7.3.0
-enigma2-plugin-extensions-cooltvguideskin - Coolman_V5.0
-enigma2-plugin-extensions-dreamexplorer - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-dreammediathek - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-dvdbackup - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-easymedia - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-eibox - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-epgimportfilter - 1.0+git30+b20621e-r0.1
-enigma2-plugin-extensions-filecommander - 2.0+git177+b73f12b-r1.1
-enigma2-plugin-extensions-fstabeditor - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-ftpbrowser - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-graphmultiepg - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-extensions-hdmitest - 2.0+git25+0da5420-r0.0
-enigma2-plugin-extensions-imdb - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-kodi - 0.5+git18+241a5aa-r0.6
-enigma2-plugin-extensions-logomanager - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-mediadownloader - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-mediascanner - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-extensions-merlinepg - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-merlinmusicplayer - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-mosaic - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-moviemanager - 2.0+git241+0f14ada-r0.0
-enigma2-plugin-extensions-movieretitle - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-movietagger - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-multirc - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-netcaster - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-netzkino - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-newsreader - 2.0+git22+3acb4e8-r1.7
-enigma2-plugin-extensions-orfat - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-partnerbox - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-picturecenterfs - 8.41
-enigma2-plugin-extensions-ppanel - 2.0+git21+caf8aa0-r1.7
-enigma2-plugin-extensions-ppanel-example - 2.0+git21+caf8aa0-r1.7
-enigma2-plugin-extensions-primetimemanager - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-refreshbouquet - 2.0+git187+763ba6b-r0.1
-enigma2-plugin-extensions-remotecontrolchannel - 2.0+git10+a06b266-r1.7
-enigma2-plugin-extensions-remotestreamconvert - 2.0+git45+135ae1d-r1.1
-enigma2-plugin-extensions-sdgradio - 1+git106+3577df7-r1.1
-enigma2-plugin-extensions-seekbar - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-shootyourscreen - 0.2+git20+d27a15e-r0.6
-enigma2-plugin-extensions-shoutcast - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-showclock - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-simplerss - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-simpleumount - 0.1+git31+8c82986-r0.1
-enigma2-plugin-extensions-snmpagent - 2.0+git22+31dd52b-r1.7
-enigma2-plugin-extensions-socketmmi - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-extensions-streaminterface - 2.0+git28+1c832b7-r1.7
-enigma2-plugin-extensions-subssupport - 1.5.8-r0.7
-enigma2-plugin-extensions-tageditor - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-tmbd - 1+git90+0bfb62d-r0.1
-enigma2-plugin-extensions-ts-sateditor - 1+git36+7a930d6-r0.1
-enigma2-plugin-extensions-virtualzap - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-webcamviewer - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-webmedia - 10.0_r01_oe2.0
-enigma2-plugin-extensions-webradiofs - 17.26
-enigma2-plugin-extensions-werbezapper - z-git5264+85eb4b9-r0.0
-enigma2-plugin-extensions-xbmcaddons - 6.0_r0
-enigma2-plugin-extensions-yampmusicplayer - 3.2.2
-enigma2-plugin-extensions-zapstatistic - z-git5264+85eb4b9-r0.0
-enigma2-plugin-systemplugins-autobouquetsmaker - 3.3+git975+b23fccb-r0.47
-enigma2-plugin-systemplugins-autoresolution - z-git5264+85eb4b9-r0.0
-enigma2-plugin-systemplugins-bluetoothsetup - 1.0-20200320.r0.5
-enigma2-plugin-systemplugins-cablescan - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-crossepg - 0.8.6+gitr506+7f38537-r0.1
-enigma2-plugin-systemplugins-defaultservicesscanner - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-devicemanager - 1+git49+0b7ff9a-r0.0
-enigma2-plugin-systemplugins-diseqctester - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-fastchannelchange - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-fastscan - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-mountmanager - 1+git56+63646c2-r0.0
-enigma2-plugin-systemplugins-networkwizard - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-pipservicerelation - experimental-git20161118-r1
-enigma2-plugin-systemplugins-positionersetup - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-remotecontrolcode - experimental-git8516+b0fb252-r6.5
-enigma2-plugin-systemplugins-satelliteequipmentcontrol - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-satfinder - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-signalfinder - 1+git67+5167e4a-r0.1
-enigma2-plugin-systemplugins-swapmanager - 1.0-r3
-enigma2-plugin-systemplugins-terrestrialscan - 1.0+git45+182b8b9-r0.106
-enigma2-plugin-systemplugins-videoenhancement - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-videotune - 2.7+git19711+2d6416e-r0.0
-enigma2-plugin-systemplugins-vps - z-git5264+85eb4b9-r0.0
-enigma2-plugin-systemplugins-wirelesslan - 2.7+git19711+2d6416e-r0.0

As to your last remark, quite possible.

 

There is a lot of junk in the 3rd-party feed (which are binary ipk files reqeusted by users which we don't maintain, don't have source of, and are rarely updated). For OpenPLi 9 (and the current develop) we have deleted all of them as part of the transition to Python 3.

nice idea, I hope nothing disappears I rely on. Python is unfortunately not one of my programming/scripting capatibilities.

[Dimitrij]

You're wasting your time, plugins have nothing to do with this problem.

[paneologist]

you may be right. and I crowed to soon.
It happened again. Just installed "enigma2-plugin-extensions-multirc", rebooted (unintentially while a recording was made), looked into openwebif, looked through timers and recordings and.. spinner.

 

here's the full debug log starting from boot.

 stb1debuglog.txt   2.36MB   3 downloads

 

I'll install develop image next

 

Edit: is there an easier way, then flashing using usb? and not loosing config and additional installed items?

Edited by paneologist, 8 August 2023 - 09:30.

[WanWizard]

If you flash with a backup, and allow it to restore after flash, you will have your config back. Additional items are restored if they are available for the new image, and if they exist in the feed.

[WanWizard]

you may be right. and I crowed to soon.
It happened again. Just installed "enigma2-plugin-extensions-multirc", rebooted (unintentially while a recording was made), looked into openwebif, looked through timers and recordings and.. spinner.

 

Please disable automatic timeshift (which is also a recording), and see if that makes a difference.

 

I have a feeling that nobody here that don't experience this issue uses timeshift? @Abu, do you?

[WanWizard]

Looking at the log, it happens directly after you started playing a radio recording. Which would immediately (try to) stop the timeshift recording.

 

I have also never seen this, what is this? The log is full of it...

2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBServiceRecord] RECORD service event 13
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBSatelliteEquipmentControl] [prepare] UnicableTuningWord 0x1940, guard_offset 0
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: 7004b306(?)
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBServiceRecord] RECORD service event 13
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBSatelliteEquipmentControl] [prepare] UnicableTuningWord 0x1940, guard_offset 0
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: 7004b306(?)
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBServiceRecord] RECORD service event 13
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBSatelliteEquipmentControl] [prepare] UnicableTuningWord 0x1940, guard_offset 0
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: 7004b306(?)
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBServiceRecord] RECORD service event 13
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBSatelliteEquipmentControl] [prepare] UnicableTuningWord 0x1940, guard_offset 0
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: 7004b306(?)
2023-08-08T10:17:28+02:00 stb1.swabian.net enigma2: [eDVBServiceRecord] RECORD service event 13

 

[Dimitrij]

Problem this

 

2023-08-08T10:19:04+02:00 stb1.swabian.net enigma2: [eFilePushThreadRecorder] stopping thread: 74
2023-08-08T10:19:04+02:00 stb1.swabian.net enigma2: [gRC] main thread is non-idle! display spinner! ---->!!!!
2023-08-08T10:19:04+02:00 stb1.swabian.net enigma2: [eFilePushThreadRecorder] stopping thread: 73

 

safeguard = 0  Why???

not run kill();

 

2023-08-08T10:19:12+02:00 stb1.swabian.net enigma2: [eFilePushThreadRecorder] thread could not be stopped!

	if(safeguard > 0)
		kill();
	else
		eWarning("[eFilePushThreadRecorder] thread could not be stopped!");

original code

void eFilePushThreadRecorder::stop()
{
	static const struct timespec timespec_1 = { .tv_sec =  0, .tv_nsec = 1000000000 / 10 };
	int safeguard;

	if (m_stop == 1)
	{
		eDebug("[eFilePushThreadRecorder] requesting to stop thread but thread is already stopped");
		return;
	}

	m_stop = 1;

	for(safeguard = 100; safeguard > 0; safeguard--)
	{
		eDebug("[eFilePushThreadRecorder] stopping thread: %d", safeguard);
		sendSignal(SIGUSR1);

		nanosleep(&timespec_1, nullptr);

		if(m_stopped)
			break;
	}

	if(safeguard > 0)
		kill();
	else
		eWarning("[eFilePushThreadRecorder] thread could not be stopped!");

maybe...

+	kill();
-	if(safeguard > 0)
-		kill();
-	else
-		eWarning("[eFilePushThreadRecorder] thread could not be stopped!");
}

or

safeguard >= 1

Edited by Dimitrij, 8 August 2023 - 18:06.

[WanWizard]

That is not the problem, that is a symptom.

 

Something is called that doesn't return control to the reactor main loop, and that triggers the spinner (so you can see that is the case).

 

There is also nothing wrong with the safeguard code: you get the eWarning (safeguard == 0) when the for loop finishes without m_stopped being set to 1 while the safeguard loop waits.

 

Simply killing the thread might fix the problem, but will not fix the bug, which is why I am against your suggestion.

 

The main question is, why isn't m_stopped set?

 

It is set here: https://github.com/O...lepush.cpp#L223

 

For that to happen, the do loop in the thread needs to be terminated by setting m_stop to 1, which is happening before the safeguard loop starts.

 

It would be handy to create an enigma2 binary with more debug logging in that do loop, so we can see what the value of m_stop and m_stopped is, and find out why the loop isn't terminated (in time).

[WanWizard]

@paneologist,

 

willing to install a test image?

[Dimitrij]

Need this

	for(safeguard = 100; safeguard > 0; safeguard--)
	{
		eDebug("[eFilePushThreadRecorder] stopping thread: %d", safeguard);
		sendSignal(SIGUSR1);

		nanosleep(&timespec_1, nullptr);

-		if(m_stopped)
+		if ((m_stopped) || (safeguard == 1))
			break;
	}