81 replies to this topic

[Stan]

The instant recording, where you can enter the duration in minutes, seems faulty in the nightly build. It ignores the input.

Besides that, there's an issue with the Cancel button.

 

This is what it looks like:

Add a recording (enter recording duration)
 - Instead of the custom duration, the recording lasts until the end of the current event. [bug present in nightly build only]
 - Buttons [Cancel] and [OK] are missing on this screen. [Release 8.3 is also affected]
 - Pressing Cancel/Exit activates recording [Release 8.3 also affected]

Add a recording (enter recording endtime)
 - Pressing "Cancel" starts recording, same fault as above

[ims]

Note: instant recording was never meant to have Yes/Cancel. It's instant recording, assuming the user needs to quickly add a time and not contemplate whether yes or no. Therefore, all keys are labeled as Yes.

 

 

- Instead of the custom duration, the recording lasts until the end of the current event.

yes, it could be bug ... 

 

evening I will try see on it...

Edited by ims, 12 August 2023 - 11:09.

[Stan]

[...] not contemplate whether yes or no. Therefore, all keys are labeled as Yes.

Seriously? I mean, like in real life, NO means NO!

[ims]

And - where you saw NO ???

[Stan]

Here.

 InstantRecording_Cancel_Button.jpg   67.71KB   0 downloads

The user should have the option to abort at this stage.

Edited by Stan, 12 August 2023 - 11:34.

[Dimitrij]

 

Note: instant recording was never meant to have Yes/Cancel. It's instant recording, assuming the user needs to quickly add a time and not contemplate whether yes or no. Therefore, all keys are labeled as Yes.

Yes, that's how it's meant to be.

Recording always starts, even if you canceled the time.

 

 

By the way, I worked a lot on this code.

https://github.com/O...7fe3eaae02aad5b

[Stan]

So the Cancel button has been canceled because the user is not able to press OK?

[ims]

'Instant recording' means immediate. It starts recording immediately, and if the user happens to change their mind, they can cancel by pressing the record button again and even delete what was recorded.

But Dima must fix several items there...

[Stan]

If there's work to be done in that area anyway, please keep the Cancel button working on every screen. It's only common sense and good practice.

Edited by Stan, 12 August 2023 - 16:04.

[Stan]

And btw. it's not truly instant recording as it does not automatically begin at the push of the button.

[Dimitrij]

And btw. it's not truly instant recording as it does not automatically begin at the push of the button.

Hotkey add

"Start recording current event"

"Start instant recording"

[Stan]

I know. I use "Start recording current event" on key "Rec long". Very usefull ideed.

 

"Start instant recording" as a hot key not so much... Every push of the button starts another instance of the recording...

[Dimitrij]

[InfoBarInstantRecord‎] fix check value.isdigit()

[WanWizard]

Merged.

[Abu Baniaz]

Wanwizard run a build for me and I also fetched the infobargenerics file. It will record for 5 minutes (I checked the timers) but the message had said indefinite. I would be grateful if you could look into the tweak required

Attached Files

•  192.168.1.179-20230812-181253.log.txt   70.48KB   2 downloads

[Dimitrij]

Abu Baniaz

 

First start recording as  show message "Default duration: xxxx"

 

Then you change the time.

[Abu Baniaz]

Recording is set for 5 minutes, but  the issue is the message after the recording is set. Hopefully the video shows description of issue better. Link below. Please let me know when you have seen it so I can delete it.

https://www.mediafir...222329.mp4/file

 

As an aside, which file/line can I change the 5 minute default? 

Edited by Abu Baniaz, 13 August 2023 - 22:48.

[Dimitrij]

[InfoBarInstantRecord] hide duration if set manual end time

 

 

 

As an aside, which file/line can I change the 5 minute default?

https://github.com/O...nerics.py#L2730

text="5  "

[Abu Baniaz]

Thank you

[WanWizard]

[InfoBarInstantRecord‎] fix check value.isdigit()

 

Just for my understanding, what does this do, and why not use strip() instead? Are you expecting " 5 5 " as input for 55 minutes?