81 replies to this topic

[ims]

@littlesat - similar problem exists for MinuteInput in seekFwdManual/seekBackManual there in InfoBarGeneric.py - it using Input.py too. There Is possible put big number and then e2 crashes.

OverflowError: in method 'iSeekableServicePtr_seekRelative', argument 3 of type 'pts_t'

There in Input.py should be some parameter for max number (default as None) and then fix limit in calling, imho.  
 

[tension]

For the input box a limit :

.....................
	def keyNumberGlobal(self, number):
		self["input"].number(number)
		if int(self["input"].getText()) > 1440:
			self.keyBackspace()
.....................

with the message to add minutes modified to informi on max 1440 minutes limit.

 

The minuteinput should be called with new parameter of recording duration....

 

 
 

[littlesat]

The input function is indeed terrible... it also does not have cancel.... cancel = OK... That I never noticed this....

Edited by littlesat, 25 August 2023 - 12:53.

[Stan]

Finally someone takes notice. Can it be fixed?

Edited by Stan, 25 August 2023 - 18:31.

[littlesat]

The input stuff can now do maxValue for numbers… the cancel is under investigation.

[ims]

Why you want looking for cancel ? Due it is there for runing instant recording in submenu items for Cancel, Cancel and remove recording etc ...

 

Input has small problem still:  remove "5" (with "Prev") and then type "10" and you will see... 

[littlesat]

It is a crazy part of software that inputbox…. My feeling says complete revision recommended… someone dronk a lot of bear and smoke special stuff at the moment it was created.
When you remove the 5 you should see a 0 as default… then with 1 the zero should be overwritten an then with the other 0 you should see 10…. Or do you get something else?

there are also too many options here actually…

Edited by littlesat, 26 August 2023 - 08:21.

[ims]

try remove 5, type 10, remove again and type again. It is cosmetics only, but in one moment, when you type 1, there is still 0 (10)
 

But when you use twice remove, then is all ok.

Edited by ims, 26 August 2023 - 08:47.

[tension]

I think that inputbox with the message advising of its limited input, message in infobargenerics call, to 1440 min is ok.

What i woul change is the calls in infobargenerics for the minuteinput, i would not modify minuteinput.

 

infobargenerics.py: i found a method not used in enigma (?)

def calcRemainingTime(self)

i'm trying to use it to check the minutes passed by MinuteInput.py, in ff and rw seek, but.....

something as:

ffd: If minutes passed > remaining then seek remaining or nothing

rwd: If minutes passed > played time (playposition) then move to start position (played time)

Edited by tension, 26 August 2023 - 09:07.

[ims]

in minuteinput it is prevention against e2 crash...don't look for anything sensational in it... I doubt anyone will jump farther than 24 hours.

Edited by ims, 26 August 2023 - 09:09.

[tension]

sorry did not see last changes............

ok added parameter to minuteinput....

Edited by tension, 26 August 2023 - 09:19.

[ims]

It doesn't crash due to jumping to a nonexistent place, but because a user can input a large number, leading to an 'overflow'.

Edited by ims, 26 August 2023 - 09:12.

[tension]

exactly. the minuteinput parameter was the first think,

when i found that apparently unused method i looked only at how using it....

Edited by tension, 26 August 2023 - 09:36.

[littlesat]

Rare behavior with previous, then 10 (and other scenarios) confirmed. Now I have to find a solution for it. Issue seems to be nothing is selected so I have to select somehow that 0 (zero)… or arrange something that we can just start with an empty string.

[littlesat]

Rare behavior with previous, then 10 (and other scenarios) confirmed. Now I have to find a solution for it

Done... l

 

When you enter cancel on duration the recording is already started.... so we can decide to just continue as is when you click cancel I think.... it does just not change the duration in that case.... So I think we're done for now....

[ims]

I am affraid, that still it not works well... run instant recording and when there is 5, then remove it, type 10, remove both and then type f.eg. 20 and you will see...

[littlesat]

What happens? When you remove the 10 you should see a zero….

Edited by littlesat, 27 August 2023 - 12:12.

[ims]

Yes, but next typing "2" is again as "20" and next "5" is then "50" ... try it

[Stan]

@littlesat: As an alternative, you could deactivate buttons "left" and "right" for numbers input. Pros: less code and failsafe. (try the attached file)

What do you think?

 

 Input.py   7.05KB   0 downloads

[littlesat]

Can you please show the diff? Left and right is not only the issue here you also have forward delete and backward delete and the insert etc so it gives a revision feeling. But text it could be helpful. Removing left right is not done due to text I’m afraid.
Please wait for Tuesday. Now I do not have time.

@ims so you lost the cursor again and it behaves the same?

Edited by littlesat, 27 August 2023 - 20:14.