59 replies to this topic

[Moonwalker]

This happens with trying to search for subtitles in XStreamity with Subs support. Happens when trying to edit the the search title.

Any idea where the problem is?

 

OpenPLi Enigma2 crash log

 

crashdate=Sat Apr 27 22:52:46 2024

compiledate=Apr  5 2024

skin=PLi-FullNightHD/skin.xml

sourcedate=2024-04-04

branch=develop

rev=154e2b3

component=Enigma2

 

stbmodel=gbtrio4k

stbmodel=dm8000

kernelcmdline=console=ttyAMA0,115200 root=/dev/mmcblk0p16 rootsubdir=linuxrootfs1 rootfstype=ext4 kernel=/dev/mmcblk0p12 userdataroot=/dev/mmcblk0p16 userdatasubdir=userdata1 blkdevparts=mmcblk0:1M(boot),1M(bootargs),1M(bootoptions),3M(baseparam),4M(pqparam),4M(logo),4M(deviceinfo),4M(softwareinfo),4M(loaderdb),32M(loader),8M(trustedcore),16M(linuxkernel1),16M(linuxkernel2),16M(linuxkernel3),16M(linuxkernel4),-(userdata) coherent_pool=2M mem=1G mmz=ddr,0,0,72M vmalloc=500M MACHINEBUILD=gbtrio4k OEM=gigablue MODEL=gbtrio4k

nimsockets=NIM Socket 0:

imageissue=openpli develop %h

 

 

REMOVE Peer gbtrio4k

REMOVE Peer gbtrio4k

REMOVE Peer gbtrio4k

ADD Peer vuzero4k=vuzero4k.local:8001

ADD Peer vuzero4k=vuzero4k.local:8001

/usr/lib/enigma2/python/Plugins/Extensions/SubsSupport/seekers/utilities.py:192: FutureWarning: Possible nested set at position 1

  response_file = re.findall(regex, file)

Traceback (most recent call last):

  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 77, in action

  File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action

  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 256, in keyBackspace

  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 43, in handleKey

  File "/usr/lib/enigma2/python/Plugins/Extensions/SubsSupport/subtitles.py", line 3307, in handleKey

    ConfigText.handleKey(self, key, callback)

TypeError: handleKey() takes 2 positional arguments but 3 were given

[ePyObject] (CallObject(<bound method NumberActionMap.action of <Components.ActionMap.NumberActionMap object at 0xac54c598>>,('SetupActions', 'deleteBackward')) failed)

 

[Tech]

There is a good chance that this problem will disappear if you update the develop image online to the latest version.

[Moonwalker]

No still happening. Even going directly to subsSupport downloader any try editing the title it crashes again.

Uninstalled Subssupport and reinstalled from feed but still getting same problem

[WanWizard]

How could that have ever worked? I've checked Enigma's history, ConfigText.handleKey() never had 3 arguments.

[littlesat]

Where did you get the plugin from?

[Moonwalker]

I removed the plugin from plugins menu but there was still the older version showing in plugins so I deleted the folder in python plugins. Then installed subssupport from feed. 

 

Originally I was using enigma2-plugin-extensions-subssupport_1.5.8-r9-py3_all.ipk

[littlesat]

Where did you get the ipk from?

[Moonwalker]

https://github.com/biko-73/SubsSupport

[WanWizard]

It is ATV specific, it is not compatible with OpenPLi. https://github.com/o...nfigList.py#L70

[Moonwalker]

Umm ok. Any chance someone can port it to OpenPli as otherwise it works fine?

[WanWizard]

That would require someone who uses it, as it would need testing. Which rules me out .

 

Chances are btw that it is sufficient to remove the callback, so not

    def handleKey(self, key, callback=None):
        ConfigText.handleKey(self, key, callback)

but

    def handleKey(self, key):
        ConfigText.handleKey(self, key)

 

[littlesat]

Why is the callback there in the first place?

[WanWizard]

Ask your friend IanSav, he added it in https://github.com/o...e8e08d95afada44
 

- Use callbacks from ConfigList.py to more efficiently allow config.py to notify ConfigList.py that data has changed during an edit

Edited by WanWizard, 28 April 2024 - 17:16.

[littlesat]

Again a thing I’m happy it is not in ours… but in openatv. He is master in breaking things. And at the end it is not a real performance winner…

[Moonwalker]

 

That would require someone who uses it, as it would need testing. Which rules me out .

 

Chances are btw that it is sufficient to remove the callback, so not

    def handleKey(self, key, callback=None):
        ConfigText.handleKey(self, key, callback)

but

    def handleKey(self, key):
        ConfigText.handleKey(self, key)

 

Worked thanks!

[littlesat]

Sure..:: some are master in breaking things as they are… maybe the coding is better and more efficient but enigma2 also has a history. And I also now python 3 breaks especially closed source plugins…. But it was weighted. I still think you should improve and optimize stuff but you still need balance in not breaking a lot of stuff when it is not really needed. When you optimize things then at least try to keep it as compatible as possible.

Edited by littlesat, 2 May 2024 - 23:06.

[Huevos]

Isn't it time PLi had the setup code that everyone else has been using for years? So much can't be done on current PLi. If a PR is supplied will it be accepted/rejected?

[littlesat]

when you have a merge request that is good it will be excepted of course… Think about that skin process… 

Actually most other image are initially a fork from us… and not many do merge requests here… and be aware we try to make things better so please also accept comments/questions/suggestions….

Edited by littlesat, 4 May 2024 - 11:47.

[Huevos]

My question is about the the setup code. You can view it on vix repo. If you want it I can get it running for PLi. I wasn't talking about making custom code.

[littlesat]

To see the differences is not possible anymore… over thousand lines are changed.
I see a lot of change calls that are moved into a callback, which makes code easier, but it will break stuff when used. But it is backwards compatible. This is a point that should be weighted.
In the commit of openatv I only see the change change as GitHub does not show the complete commit. A huge impact in enigma2

Edited by littlesat, 6 May 2024 - 12:41.