eesatfan

Dont expect they send you a medal for it in return... Please remember DMM is a commercial manufacturer who has null interest in the opensource community.

I rather give them the same kind of support they give to us!

I expect only that this wired situation with our subtitles is fixed allso on newer DMM hardware. As long time developer I understund why they closed own source. I dont say thats good, but at least I understund. Now in our interests is only get subtitles fixed.

i think, DMM will take it from our repo without thanks, as usually

I sent patch for older (last free from dmm) enigma2 to DMM allso.

Changes are commited.

Thanks

This should be correct now

 0001-This-patch-improves-teletext-subtitleing.patch.gz   5.03KB   20 downloads

Please ignore previous patch, this is allso not correct for use in only git way.

The patch format is incorrect....

The idea looks good...

 

$ git am -s ../subtitle.patch
Patch format detection failed.

 

And I do not understand why this is required...

+  {
+   for (int ii=0; ii < m_teletext_parser->max_id; ii++){
+    if (!memcmp(m_teletext_parser->my_country_codes[ii], lang.c_str(), 3)) break;
+   }
+   if (ii > m_teletext_parser->max_id-2) ii = 0;
+   m_dvb_service->setCacheEntry(eDVBService::cSUBTITLE,((pid&0xFFFF)<<16)|((page&0xFF)<<8)|((ii&0x1F)<<3)|(magazine&0x7));
+  }

Hopefully this time is patch correctly formatted.

 subtitle.patch.gz   4.72KB   4 downloads

The code fragment stores used language code to Cache in 5 higher bits of magazine byte ( in teletext mode magazine has only 3 bits).

Hi all

My idea is use language code from PMT table subtitle info for teletext pid for selecting correct charset when broadcaster ( in our country Viasat ) is not sending charset selecting triplets in X/28/0 or X/29/0. Select subtitle language is allso cached for every channel together with pid and page and magazine number. When just upgrading enigma2 then subtitle cache (if it exists) does not have language info cached and you should manually reselect subtitle ).

Additionally I implemented cyrillic charsets.

Here is the patch allso, hopefully somebody will commit it to git.

 subtitle.patch.gz   4.42KB   29 downloads